From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 1/3] ob-table: Fix org-sbe's handling of quotes in
 arguments
Date: Mon, 19 Mar 2018 00:30:22 +0100
Message-ID: <87605tc67l.fsf@nicolasgoaziou.fr>
References: <20180307225847.24068-1-git@thecybershadow.net>
	<20180307225847.24068-2-git@thecybershadow.net>
	<87muzcans9.fsf@nicolasgoaziou.fr>
	<9107300b-c95d-ad16-ca03-088d173c90d9@gmail.com>
	<87605yn4x3.fsf@nicolasgoaziou.fr>
	<8258182a-5d7e-d8c9-96c2-1a76dd9e143c@gmail.com>
	<87fu52ln2g.fsf@nicolasgoaziou.fr>
	<d1d7f4fc-1ec9-a517-58e1-c1f7e5189d9f@gmail.com>
	<87a7v5c99c.fsf@nicolasgoaziou.fr>
	<f714e008-e66e-3c96-e01c-2f0129ee1046@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46833)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1exhl1-0001vM-MS
	for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 19:30:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1exhkw-0007Nd-PL
	for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 19:30:31 -0400
Received: from relay8-d.mail.gandi.net ([217.70.183.201]:33817)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1exhkw-0007Mt-I5
	for emacs-orgmode@gnu.org; Sun, 18 Mar 2018 19:30:26 -0400
In-Reply-To: <f714e008-e66e-3c96-e01c-2f0129ee1046@gmail.com> (Vladimir
	Panteleev's message of "Sun, 18 Mar 2018 22:43:43 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Vladimir Panteleev <thecybershadow@gmail.com>
Cc: emacs-orgmode@gnu.org, Vladimir Panteleev <git@thecybershadow.net>

Vladimir Panteleev <thecybershadow@gmail.com> writes:

> Ah! Well, thanks for the clarification, and apologies for the
> confusion.

Well, thanks for bearing with me.

>> I consider it to be a bug if you need to write $"string" instead of
>> "string" in any `org-sbe' call. We should not test such a mis-feature,
>> which should be removed.
>
> Agreed completely, but, wouldn't this be a breaking change? So far
> I've tried to avoid breaking any meaningful existing uses of org-sbe.

We probably need to break `org-sbe' so as to improve it. In particular,
its syntax ought to evolve, as you pointed out. However, such changes
would obviously go into master branch, not in maint.

> No problem. To clarify, would you prefer tests which still use
> $-prefixing, but with a table cell reference to get the value in the
> cell (i.e. $$2), or tests which do not use $-prefixing in order to
> interpret the string in the table cell as a reference to another block
> in the org-mode document?

At the moment, both are features described in `org-sbe' docstring, so
I think they should be both tested, if appropriate. However, I had the
former in mind when I suggested to change tests; the latter sounds very
much like over-engineering.