From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: patch: adding split-window-right option for src block editing Date: Mon, 15 Jul 2019 12:02:04 +0200 Message-ID: <875zo3obtv.fsf@nicolasgoaziou.fr> References: <87wogosyxw.fsf@ucl.ac.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:59660) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmxpV-00071e-Hw for emacs-orgmode@gnu.org; Mon, 15 Jul 2019 06:03:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmxpU-00054A-Lb for emacs-orgmode@gnu.org; Mon, 15 Jul 2019 06:03:33 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:42443) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmxpU-000527-F6 for emacs-orgmode@gnu.org; Mon, 15 Jul 2019 06:03:32 -0400 In-Reply-To: <87wogosyxw.fsf@ucl.ac.uk> (Eric Fraga's message of "Thu, 11 Jul 2019 09:27:56 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: "Fraga, Eric" Cc: Emacs Org mode mailing list Hello, "Fraga, Eric" writes: > most of my work now involves using quite large wide monitors and having > the editing of src blocks open windows below is less convenient than > splitting horizontally. I have added the option to split > horizontally. See attached patch. Thank you. Could you provide an entry in ORG-NEWS, too? > > However, ideally, I would like the option to specify a function as > context matters: sometimes a vertical split is better, sometimes > not. But implementing this was beyond my emacs-fu. Allowing one to use a function is easy. It entails one additional value in the defcustom, and one case in `org-src-switch-to-buffer': ((pred functionp) (funcall org-src-window-setup)) probably near the end since some symbols also are function names (e.g., `other-frame'). Implementing an interesting function is harder, but not necessary for Org for the time being. Regards, -- Nicolas Goaziou