From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Bastien <bzg@gnu.org>,
Brandon Guttersohn <brandon@guttersohn.org>,
emacs-orgmode@gnu.org
Subject: Re: Possible fix for :includes header argument in org-babel C source blocks
Date: Thu, 28 May 2020 10:25:12 +0200 [thread overview]
Message-ID: <875zcgwjo7.fsf@gmail.com> (raw)
In-Reply-To: <87imggx045.fsf@kyleam.com> (Kyle Meyer's message of "Thu, 28 May 2020 02:30:02 +0000")
Kyle Meyer <kyle@kyleam.com> writes:
> I think this discussion was on emacs-devel only, so here are some links
> for others who might go looking for more context:
>
> https://lists.gnu.org/archive/html/emacs-devel/2020-04/msg01880.html
> https://lists.gnu.org/archive/html/emacs-devel/2020-05/msg03051.html
(Thanks, I should have thought to add some context before forwarding.)
>> I guess there might be some people out there who will expect things to
>> keep working without double-quotes? I have never used Babel, so I have
>> no idea…
>
> I don't know either, but the test does make me think so. Hopefully
> Brandon, Bastien, or someone else will chime in if that's not the case.
My opinion should only carry so much weight since I don't use Babel, but
from a quick reading of the sources, I couldn't find other examples of
this (symbol → string) coercion. The only other instances of
lists-of-strings I could find in testing/examples were
> :var a='("abc" "def")
That leads me to believe that the coercion was an unintended side-effect
of (format …).
Of course, backward compatibility alone would mandate keeping the
coercion.
> Could you send the first patch with a commit message tacked on?
Will do ASAP.
BTW, does the change from 44cb98fdb deserve an ORG-NEWS entry?
next prev parent reply other threads:[~2020-05-28 8:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <21b0cd85-d678-2fe6-3c22-e41abc6cf242@guttersohn.org>
[not found] ` <87wo51jo5w.fsf@gnu.org>
2020-05-27 22:20 ` Possible fix for :includes header argument in org-babel C source blocks Kévin Le Gouguec
2020-05-28 2:30 ` Kyle Meyer
2020-05-28 8:25 ` Kévin Le Gouguec [this message]
2020-05-28 10:09 ` Kévin Le Gouguec
2020-05-29 2:47 ` Kyle Meyer
2020-05-29 12:41 ` Failing tests (was: Possible fix for :includes header argument in org-babel C source blocks) Kévin Le Gouguec
2020-05-31 4:59 ` Kyle Meyer
2020-06-01 14:48 ` Failing tests Kévin Le Gouguec
2020-06-01 14:56 ` Kévin Le Gouguec
2020-06-03 4:20 ` Kyle Meyer
2020-06-01 13:54 ` Bastien
2020-05-29 3:37 ` Possible fix for :includes header argument in org-babel C source blocks Brandon Guttersohn
2020-05-29 9:57 ` Kévin Le Gouguec
2020-05-30 17:29 ` Brandon Guttersohn
2020-06-01 13:55 ` Bastien
2020-06-01 20:17 ` Kévin Le Gouguec
2020-06-02 0:02 ` Brandon Guttersohn
2020-05-29 2:45 ` Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zcgwjo7.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=brandon@guttersohn.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=kyle@kyleam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).