From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YNQZNIc/gl89MgAA0tVLHw (envelope-from ) for ; Sat, 10 Oct 2020 23:11:03 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ABjWL4c/gl/zGQAA1q6Kng (envelope-from ) for ; Sat, 10 Oct 2020 23:11:03 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 19AB49402C2 for ; Sat, 10 Oct 2020 23:11:01 +0000 (UTC) Received: from localhost ([::1]:47666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kRO0x-00078n-3a for larch@yhetil.org; Sat, 10 Oct 2020 19:10:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kRO0a-00078h-7n for emacs-orgmode@gnu.org; Sat, 10 Oct 2020 19:10:36 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:46358) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kRO0Y-0005VO-Cl for emacs-orgmode@gnu.org; Sat, 10 Oct 2020 19:10:35 -0400 Received: by mail-pf1-x443.google.com with SMTP id y14so10080560pfp.13 for ; Sat, 10 Oct 2020 16:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=0mecJLL5XuxcYIdr8fXNCjMMMk08+phxMwJikcLUa5U=; b=vXgv5CUgXTITUrG5e0Gug4kc+LtZaIocNtOZTmcPXYp20p7N7hhA+F3VitMQGWTDo1 yroMIW8rR6ILFnLoGEw43wD8sEX9/HOKMj8yEPlilkWKXs5O5Df2bjE1GrNyHTmyCoQZ K6IZpTzzKd4WgqGfce4GzwU9FtVc0FCLQmV9gxNKqRp9vlLFgNpwlrHSbCkiSP+nO0mi TAhshmHG2/PLv3ir42OZH8A0t6f4PYJLUn3W2kCQBqe6V48G9UjA3SxT6nt7MhfK5Sv3 slycDKZc7sjZpz9TM6HlpkAvF96lXxQBeDWp/yz+pYUBJFEtTKMg9E6Scww8+eXOPdpU 8oWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=0mecJLL5XuxcYIdr8fXNCjMMMk08+phxMwJikcLUa5U=; b=CO9IjHNQbRj6IyO40KYjtF49kG2YgU6c1mUU2u2NqRhNdHcysYBPQ0l2Z4WTPUQhDO ORWB3zpAeVR77UgeOq1vOS9FyGH48jmNhctTPfJ9cARXQoCQQkCb3d+vSP8VIyuNfDZT Rhd0vAUWQQ+QrmiitO2CdYRraATewnuytSbDiYBr48uIvR/Gzq6biW9bupZ86O+rxPCU BPbpVkRB7D0THzCmRKdiQc4c/nfWHbOhrpzxtN2Y28IpkDOzCA6o06wDV8yNh0z/GYRw DoNDcgETY/RoaKB65m+atMvE02uQOGvY7f5mZ9ln8gCLvbP4ASVwdup/ZU8bJVhgiMFH nlDA== X-Gm-Message-State: AOAM532rELRJrY24HEo36lpOhm/bOn4jHeeDhUQG/ETsLbe63ZB37G7Q a2GCKHlkZL/jDWFUIr+a5VM0YVRDeOQ= X-Google-Smtp-Source: ABdhPJzti1glEONHvOkLOWv/mkPaWamQEaX3Yoxt/URo8dqMDdGxOaQQBgpv02f/lhWR5dR8uXSN2g== X-Received: by 2002:a63:1e61:: with SMTP id p33mr5392067pgm.50.1602371432202; Sat, 10 Oct 2020 16:10:32 -0700 (PDT) Received: from localhost (199-83-220-90.PUBLIC.monkeybrains.net. [199.83.220.90]) by smtp.gmail.com with ESMTPSA id e23sm8167724pfi.191.2020.10.10.16.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2020 16:10:31 -0700 (PDT) From: Jack Kamm To: Adrian =?utf-8?Q?Kummerl=C3=A4nder?= , emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-python: Rename exec tmpfile handle to prevent conflict In-Reply-To: <87pn5uzh2i.fsf@student.kit.edu> References: <87pn5uzh2i.fsf@student.kit.edu> Date: Sat, 10 Oct 2020 16:10:30 -0700 Message-ID: <875z7hwuc9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::443; envelope-from=jackkamm@gmail.com; helo=mail-pf1-x443.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=vXgv5CUg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.21 X-TUID: gvDKS7XWH+yw Hi Adrian, Adrian Kummerl=C3=A4nder writes: > I noticed that after updating to Org 9.4 many of my Python-based Org > files fail to execute with various `io.TextIOWrapper' related error > messages. The reason for this is that opening the exec tmpfile as `f' > shadows this possibly user-defined variable. > > The attached patch fixes this problem for me. As this is my first > time contributing to Org I am especially open for any suggestions! The patch looks good. I've pushed it to master, after making a couple minor fixes to the commit message (adding a TINYCHANGE cookie and adjusting some of the spacing). Thanks for your contribution! Jack