* Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
@ 2020-12-16 8:48 Ihor Radchenko
2020-12-16 11:40 ` Bastien
0 siblings, 1 reply; 12+ messages in thread
From: Ihor Radchenko @ 2020-12-16 8:48 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
When using org-contacts and org-id simultaneously, org-contacts
unconditionally makes org-store-link use file:name.org:*Headline link
style instead of id:UUID link style expected when using org-id. The
problem does not only appears when storing links to contact.org
headlines, but for any headlines.
Probably, org-contacts should be integrated with org-id or at least not
interfere with links to ordinary headlines.
Best,
Ihor
Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.16.0)
of 2020-12-12
Package: Org mode version 9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-16 8:48 Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
@ 2020-12-16 11:40 ` Bastien
2020-12-17 0:25 ` stardiviner
0 siblings, 1 reply; 12+ messages in thread
From: Bastien @ 2020-12-16 11:40 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: emacs-orgmode
Hi,
Ihor Radchenko <yantar92@gmail.com> writes:
> When using org-contacts and org-id simultaneously, org-contacts
> unconditionally makes org-store-link use file:name.org:*Headline link
> style instead of id:UUID link style expected when using org-id. The
> problem does not only appears when storing links to contact.org
> headlines, but for any headlines.
>
> Probably, org-contacts should be integrated with org-id or at least not
> interfere with links to ordinary headlines.
Agreed. Stardiviner, can you have a look?
Thanks,
--
Bastien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-16 11:40 ` Bastien
@ 2020-12-17 0:25 ` stardiviner
2020-12-17 3:30 ` Ihor Radchenko
0 siblings, 1 reply; 12+ messages in thread
From: stardiviner @ 2020-12-17 0:25 UTC (permalink / raw)
To: Bastien; +Cc: Org-mode, Ihor Radchenko
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
Sure, I didn't expected that soon bug appears. I checked source code, I
commented out an condition accidentally.
Here is the patch. Tested it should work now.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Wed, Dec 16, 2020 at 7:40 PM Bastien <bzg@gnu.org> wrote:
> Hi,
>
> Ihor Radchenko <yantar92@gmail.com> writes:
>
> > When using org-contacts and org-id simultaneously, org-contacts
> > unconditionally makes org-store-link use file:name.org:*Headline link
> > style instead of id:UUID link style expected when using org-id. The
> > problem does not only appears when storing links to contact.org
> > headlines, but for any headlines.
> >
> > Probably, org-contacts should be integrated with org-id or at least not
> > interfere with links to ordinary headlines.
>
> Agreed. Stardiviner, can you have a look?
>
> Thanks,
>
> --
> Bastien
>
[-- Attachment #1.2: Type: text/html, Size: 2048 bytes --]
[-- Attachment #2: 0001-org-contacts-Fix-org-store-link-error-caused-by-org-.patch --]
[-- Type: text/x-patch, Size: 1179 bytes --]
From db33924b9439a5a787b30e985cf005ba11347642 Mon Sep 17 00:00:00 2001
From: stardiviner <numbchild@gmail.com>
Date: Thu, 17 Dec 2020 08:19:35 +0800
Subject: [PATCH] org-contacts: Fix org-store-link error caused by
org-contacts-link-store
* contrib/lisp/org-contacts.el (org-contacts-link-store): Fix Org store
link by adding missing condition for org-contacts.
---
contrib/lisp/org-contacts.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 310166d53..44ba455c4 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -1157,8 +1157,8 @@ (org-link-set-parameters "org-contact"
(defun org-contacts-link-store ()
"Store the contact in `org-contacts-files' with a link."
- (when (eq major-mode 'org-mode)
- ;; (member (buffer-file-name) (mapcar 'expand-file-name org-contacts-files))
+ (when (and (eq major-mode 'org-mode)
+ (member (buffer-file-name) (mapcar 'expand-file-name org-contacts-files)))
(let ((headline-str (substring-no-properties (org-get-heading t t t t))))
(org-store-link-props
:type "org-contact"
--
2.29.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 0:25 ` stardiviner
@ 2020-12-17 3:30 ` Ihor Radchenko
2020-12-17 5:03 ` Bastien
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Ihor Radchenko @ 2020-12-17 3:30 UTC (permalink / raw)
To: stardiviner, Bastien; +Cc: Org-mode
stardiviner <numbchild@gmail.com> writes:
> Sure, I didn't expected that soon bug appears. I checked source code, I
> commented out an condition accidentally.
> Here is the patch. Tested it should work now.
What about adding support for org-id? Is it necessary to use headline
text as a search string even when org-id is being used (and
org-id-link-to-org-use-id is set to non-nil)?
Best,
Ihor
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 3:30 ` Ihor Radchenko
@ 2020-12-17 5:03 ` Bastien
2020-12-17 5:08 ` stardiviner
2020-12-17 5:07 ` stardiviner
2020-12-17 6:40 ` stardiviner
2 siblings, 1 reply; 12+ messages in thread
From: Bastien @ 2020-12-17 5:03 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Org-mode
Ihor Radchenko <yantar92@gmail.com> writes:
> stardiviner <numbchild@gmail.com> writes:
>
>> Sure, I didn't expected that soon bug appears. I checked source code, I
>> commented out an condition accidentally.
>> Here is the patch. Tested it should work now.
>
> What about adding support for org-id? Is it necessary to use headline
> text as a search string even when org-id is being used (and
> org-id-link-to-org-use-id is set to non-nil)?
I don't know what's the best solution here, but stardiviner feel free
to commit patches yourself, as this is part of contrib/.
--
Bastien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 5:03 ` Bastien
@ 2020-12-17 5:08 ` stardiviner
2020-12-17 5:18 ` Bastien
0 siblings, 1 reply; 12+ messages in thread
From: stardiviner @ 2020-12-17 5:08 UTC (permalink / raw)
To: Bastien; +Cc: Org-mode, Ihor Radchenko
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
Does that means I can push to org-contacts.el directly by myself?
That's simpler. Thanks.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Thu, Dec 17, 2020 at 1:03 PM Bastien <bzg@gnu.org> wrote:
> Ihor Radchenko <yantar92@gmail.com> writes:
>
> > stardiviner <numbchild@gmail.com> writes:
> >
> >> Sure, I didn't expected that soon bug appears. I checked source code, I
> >> commented out an condition accidentally.
> >> Here is the patch. Tested it should work now.
> >
> > What about adding support for org-id? Is it necessary to use headline
> > text as a search string even when org-id is being used (and
> > org-id-link-to-org-use-id is set to non-nil)?
>
> I don't know what's the best solution here, but stardiviner feel free
> to commit patches yourself, as this is part of contrib/.
>
> --
> Bastien
>
[-- Attachment #2: Type: text/html, Size: 2025 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 5:08 ` stardiviner
@ 2020-12-17 5:18 ` Bastien
2020-12-17 5:25 ` stardiviner
0 siblings, 1 reply; 12+ messages in thread
From: Bastien @ 2020-12-17 5:18 UTC (permalink / raw)
To: stardiviner; +Cc: Org-mode, Ihor Radchenko
stardiviner <numbchild@gmail.com> writes:
> Does that means I can push to org-contacts.el directly by myself?
Yes indeed. Thanks to you!
--
Bastien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 5:18 ` Bastien
@ 2020-12-17 5:25 ` stardiviner
2020-12-17 5:52 ` Bastien
0 siblings, 1 reply; 12+ messages in thread
From: stardiviner @ 2020-12-17 5:25 UTC (permalink / raw)
To: Bastien; +Cc: Org-mode, Ihor Radchenko
[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]
I seems don't have permission to do `git push` directly.
Got error:
```
128 git … push -v upstream master\:refs/heads/master
Pushing to code.orgmode.org:bzg/org-mode.git
Gogs: You do not have sufficient authorization for this action
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
```
Is this git address "git@code.orgmode.org:bzg/org-mode.git" correct?
I got from https://code.orgmode.org/bzg/org-mode.
I also tried http protocol. Also failed with following error:
```
1 git … push -v upstream master\:refs/heads/master
Pushing to https://code.orgmode.org/bzg/org-mode.git
Writing objects: 100% (5/5), 970 bytes | 970.00 KiB/s, done.
Total 5 (delta 3), reused 0 (delta 0), pack-reused 0
POST git-receive-pack (1123 bytes)
Icon theme "ubuntu-mono-dark" not found.
Icon theme "Mint-X" not found.
Icon theme "elementary" not found.
POST git-receive-pack (1123 bytes)
error: RPC failed; HTTP 401 curl 22 The requested URL returned error: 401
fatal: the remote end hung up unexpectedly
fatal: the remote end hung up unexpectedly
Everything up-to-date
```
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Thu, Dec 17, 2020 at 1:18 PM Bastien <bzg@gnu.org> wrote:
> stardiviner <numbchild@gmail.com> writes:
>
> > Does that means I can push to org-contacts.el directly by myself?
>
> Yes indeed. Thanks to you!
>
> --
> Bastien
>
[-- Attachment #2: Type: text/html, Size: 3554 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 5:25 ` stardiviner
@ 2020-12-17 5:52 ` Bastien
0 siblings, 0 replies; 12+ messages in thread
From: Bastien @ 2020-12-17 5:52 UTC (permalink / raw)
To: stardiviner; +Cc: Org-mode, Ihor Radchenko
stardiviner <numbchild@gmail.com> writes:
> I seems don't have permission to do `git push` directly.
I just added you as a "collaborator" on bzg/org-mode.
Please clone and push again. If things don't go right, let's sort
this out in private.
Thanks,
--
Bastien
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 3:30 ` Ihor Radchenko
2020-12-17 5:03 ` Bastien
@ 2020-12-17 5:07 ` stardiviner
2020-12-17 6:40 ` stardiviner
2 siblings, 0 replies; 12+ messages in thread
From: stardiviner @ 2020-12-17 5:07 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Bastien, Org-mode
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
Supporting org-id has been considered.
I will see is it easy to integrated it in. If simple, I will do it soon.
Thanks for your suggestion. More detailed discussion can reference another
thread in this mailing list.
"More on design of org-contacts.el - Re: [UPDATED PATCH] Re: add new link
type "contact:" for org-contacts.el"
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Thu, Dec 17, 2020 at 11:26 AM Ihor Radchenko <yantar92@gmail.com> wrote:
>
> stardiviner <numbchild@gmail.com> writes:
>
> > Sure, I didn't expected that soon bug appears. I checked source code, I
> > commented out an condition accidentally.
> > Here is the patch. Tested it should work now.
>
> What about adding support for org-id? Is it necessary to use headline
> text as a search string even when org-id is being used (and
> org-id-link-to-org-use-id is set to non-nil)?
>
> Best,
> Ihor
>
>
[-- Attachment #2: Type: text/html, Size: 2149 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)]
2020-12-17 3:30 ` Ihor Radchenko
2020-12-17 5:03 ` Bastien
2020-12-17 5:07 ` stardiviner
@ 2020-12-17 6:40 ` stardiviner
2020-12-17 7:20 ` Ihor Radchenko
2 siblings, 1 reply; 12+ messages in thread
From: stardiviner @ 2020-12-17 6:40 UTC (permalink / raw)
To: Ihor Radchenko; +Cc: Bastien, Org-mode
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
Ok, I added `org-id-link-to-org-use-id` support now. Check out the latest
update in Git.
[stardiviner] <Hack this world!> GPG key ID: 47C32433
IRC(freeenode): stardiviner Twitter: @numbchild
Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433
Blog: http://stardiviner.github.io/
On Thu, Dec 17, 2020 at 11:26 AM Ihor Radchenko <yantar92@gmail.com> wrote:
>
> stardiviner <numbchild@gmail.com> writes:
>
> > Sure, I didn't expected that soon bug appears. I checked source code, I
> > commented out an condition accidentally.
> > Here is the patch. Tested it should work now.
>
> What about adding support for org-id? Is it necessary to use headline
> text as a search string even when org-id is being used (and
> org-id-link-to-org-use-id is set to non-nil)?
>
> Best,
> Ihor
>
>
[-- Attachment #2: Type: text/html, Size: 1667 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-12-17 7:18 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-16 8:48 Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2020-12-16 11:40 ` Bastien
2020-12-17 0:25 ` stardiviner
2020-12-17 3:30 ` Ihor Radchenko
2020-12-17 5:03 ` Bastien
2020-12-17 5:08 ` stardiviner
2020-12-17 5:18 ` Bastien
2020-12-17 5:25 ` stardiviner
2020-12-17 5:52 ` Bastien
2020-12-17 5:07 ` stardiviner
2020-12-17 6:40 ` stardiviner
2020-12-17 7:20 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).