From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SJj1H+Pm2l+ECwAA0tVLHw (envelope-from ) for ; Thu, 17 Dec 2020 05:04:35 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id +Fu4G+Pm2l+aZwAAB5/wlQ (envelope-from ) for ; Thu, 17 Dec 2020 05:04:35 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E6EE4940821 for ; Thu, 17 Dec 2020 05:04:34 +0000 (UTC) Received: from localhost ([::1]:40776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kplSq-0005mj-QU for larch@yhetil.org; Thu, 17 Dec 2020 00:04:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kplRv-0005m1-0c for emacs-orgmode@gnu.org; Thu, 17 Dec 2020 00:03:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44586) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kplRu-0006aH-OU; Thu, 17 Dec 2020 00:03:34 -0500 Received: from [2a01:e35:2fe1:f780:b096:619d:f942:2c4f] (port=38056 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kplRk-00068h-5C; Thu, 17 Dec 2020 00:03:29 -0500 Received: by guerry (Postfix, from userid 1000) id 029BE1A60DAE; Thu, 17 Dec 2020 06:03:20 +0100 (CET) From: Bastien To: Ihor Radchenko Subject: Re: Bug: org-contacts.el: org-contacts-link-store breaks org-id [9.4.2 (release_9.4.2-307-g8840af @ /home/yantar92/.emacs.d/straight/build/org/)] References: <87zh2e5e7t.fsf@localhost> <87sg86uggl.fsf@gnu.org> <87sg855ct6.fsf@localhost> Date: Thu, 17 Dec 2020 06:03:20 +0100 In-Reply-To: <87sg855ct6.fsf@localhost> (Ihor Radchenko's message of "Thu, 17 Dec 2020 11:30:45 +0800") Message-ID: <875z51nhwn.fsf@bzg.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org-mode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.81 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E6EE4940821 X-Spam-Score: -2.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: FgT0oVMWDTsk Ihor Radchenko writes: > stardiviner writes: > >> Sure, I didn't expected that soon bug appears. I checked source code, I >> commented out an condition accidentally. >> Here is the patch. Tested it should work now. > > What about adding support for org-id? Is it necessary to use headline > text as a search string even when org-id is being used (and > org-id-link-to-org-use-id is set to non-nil)? I don't know what's the best solution here, but stardiviner feel free to commit patches yourself, as this is part of contrib/. -- Bastien