From: Ihor Radchenko <yantar92@gmail.com>
To: Caleb Chase <caleb@chasecaleb.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-capture-kill: doesn't remove the right text region
Date: Sun, 31 Jul 2022 13:06:34 +0800 [thread overview]
Message-ID: <875yjdkh0l.fsf@localhost> (raw)
In-Reply-To: <874jz7rpx4.fsf@localhost>
Ihor Radchenko <yantar92@gmail.com> writes:
> Caleb Chase <caleb@chasecaleb.com> writes:
>
>> I discovered a bug with org-capture and org-capture kill when
>> canceling an item or plain type template on a heading that has only an
>> empty line for content. Minimal reproduction is as follows:
>
> The fix is attached.
> The reason why this bug is happening is `org-capture-empty-lines-before`
> adding/removing the lines before the capture region. This situation was
> not considered by org-capture.
>
> Note that `org-capture-empty-lines-before` changes are not going to be
> restored upon capture abortion. Fixing this will not be trivial (AFAIU,
> suggestions are welcome) and the gains are marginal - I doubt that
> anyone is going to care much about this side effect. Of course, feel
> free to disagree by replying.
Applied onto main via 2ea0830f0.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2ea0830f07fa81b6e22ccdd43ad351ad76fcc097
Best,
Ihor
prev parent reply other threads:[~2022-07-31 5:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-14 21:24 [BUG] org-capture-kill: doesn't remove the right text region Caleb Chase
2022-07-17 10:00 ` Ihor Radchenko
2022-07-24 6:21 ` Ihor Radchenko
2022-07-31 5:06 ` Ihor Radchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yjdkh0l.fsf@localhost \
--to=yantar92@gmail.com \
--cc=caleb@chasecaleb.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).