From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id gNI6Dijr9GLeaAEAbAwnHQ (envelope-from ) for ; Thu, 11 Aug 2022 13:42:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id yA1EDijr9GILTwAA9RJhRA (envelope-from ) for ; Thu, 11 Aug 2022 13:42:32 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BD42E29AC4 for ; Thu, 11 Aug 2022 13:42:31 +0200 (CEST) Received: from localhost ([::1]:40600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oM6a6-00044E-Os for larch@yhetil.org; Thu, 11 Aug 2022 07:42:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM6Xl-0003zR-6F for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 07:40:05 -0400 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:41634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oM6Xj-0002bS-EA for emacs-orgmode@gnu.org; Thu, 11 Aug 2022 07:40:04 -0400 Received: by mail-qv1-xf35.google.com with SMTP id d10so7517912qvn.8 for ; Thu, 11 Aug 2022 04:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=wDkOqu1+CFaLxEGzjM5/tfyNeDZb+Ynwb7X1lLqN1fA=; b=DM1vKwxtlMJAJVtzSDsjv9Qv4yQ1t3Crw6E+g0GHogwkl9SA/AO44BTOEplSkNSJ8A zmUR96coWGcMv8zpA4DzS0Sg1jbu9fQsBeWxRB7aa1fsLxitgHlBiaW5QIRpGYkB2VoY rSsQIAne/t8RddpGw4jduVKEHWC5MvhUcLQopETBLPO2bLGjYrbXmeCyFfsf+4fkRAdM if+LR1UDcXCxFMt+eaKDIs44S5eI9rsDsCljbSsCMBZWpRJhH/jQstilyX/w9RuF2fqb M1YsVQvNN0kx/ESaAi2e3gWl4XR+aMHqT8QFwSOk8MBiWklvQ8+c3YoMBf/1b7VJhkk6 n3dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=wDkOqu1+CFaLxEGzjM5/tfyNeDZb+Ynwb7X1lLqN1fA=; b=OIVxmqfpSV0IDcAxvDm5rId13Jd7G+FVpmVqJoerBFV+Gw6rjj6Rr41lDhlb7IRhbh rTPshWgYSL6drGiINU8LI3bORsZVQohyPBqRdL6Dy56nC2sL0JwWfzSsh8CzXNNXageO xCP9liyIhG0LPklKsgBm/w4hheuDfCp6J5TW3s3G52EmvgT0Io/6OUCkwAaUAxH3yP/B OGKFFI8oeUxmsTtJ7/wrV0mYhs0nD0y8EPrexJLNCgerIToyxSfekXQS8Y0GRL2PfEYL 2xZXPMv4bXf3gTFF2D7BLdqPFSiT2nqTuRLTK9lEJS1dPs0Kjs6FXf6JkuvoPSg/a+Qr lDQA== X-Gm-Message-State: ACgBeo257lVD5zCIo60pGem1Yw9pt9S4lbP/EerjbwjIFHN4cOVF0b6Z DV3lWnGP3a5zcyjTL96BbhA30nz7vOhNZg/x X-Google-Smtp-Source: AA6agR7mXRPtW2zj5w4nCAGJrNhEejRDgSosoTn/if9OuxsAAZz39wNgymVxwUHpwc0lwonWdZ0HJA== X-Received: by 2002:a17:903:18b:b0:16e:f09c:919b with SMTP id z11-20020a170903018b00b0016ef09c919bmr32331796plg.135.1660217991682; Thu, 11 Aug 2022 04:39:51 -0700 (PDT) Received: from localhost ([2409:8a70:2bf:80b0:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id b10-20020a170902650a00b0016f14abb9b2sm14740360plk.125.2022.08.11.04.39.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 04:39:51 -0700 (PDT) From: Ihor Radchenko To: Anders Johansson Cc: org-mode-email Subject: Re: [BUG] org-get-buffer-tags no longer strips text properties In-Reply-To: References: Date: Thu, 11 Aug 2022 19:40:52 +0800 Message-ID: <875yiz9fej.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=yantar92@gmail.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1660218151; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=wDkOqu1+CFaLxEGzjM5/tfyNeDZb+Ynwb7X1lLqN1fA=; b=CmVY6p+jYvYApXCPmCnwb0NOoQCwPxvlNzMFsywEdvJHHz4CNwwiG1oVmkNhLU3vLbS356 0cgeNLHb6fRdPC2WpRh2alDKZmnoUav6lUyWvyHN500POlxLVzftNRy8fvLg00nJK4iZz5 Z6lm5z6w2eBsLj9bCJCCOcW0Kj07yc6XGXrNgGsbI99FFS+wrVfVBF4OsZtOZ0si+xsldz AOOy1n3/v6UYbTvKw+5pvtkaOEOONF7itMUiJFsMvtrzUC/4ChuaI+/T3vwLdPyhCQgvZA hLMTyvj2xIVeqpPxOZBcwSo2aXwy0Ytpaq09JhOTrW0sAobJfWIxEgj9z9agww== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1660218151; a=rsa-sha256; cv=none; b=RWxpGsghEKZ3Au775totQILEQtwPrSa2XY9y5RdylkmJZ1qp/SnhhAG1mYy4/RQpSG1FlN YN5bAmdNEvjk//qroPAIFKnu+w7wJI48gYHEQgQoY2mZWENkx7oDeSsNqFrjwCl0RAxXal gkUPjnGftEmvlah6QECbZ9AuCaXpMWk7w7c4mpKXOa/wT0UPOKJKrtWmf9slcJLfcNXioH sY+846Uh2RgfZcSOkISwu8pGG2fe5cUhzfHDn6LR2AspI8cEP2dN3DF+eRBIjCW/Ll2ZdI 2J03tONQoFV6ncPwbTl661duDmDMS0suQ24yqXkOnmFGf+r/QHFQOBaY1/sY+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DM1vKwxt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.38 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=DM1vKwxt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BD42E29AC4 X-Spam-Score: -3.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: laRH4BQOb25e Anders Johansson writes: > Hi, > Commit 819409 introduced a change where the text-properties of tags > collected from a buffer are no longer stripped, which means tags may be > fontified in unwanted ways in completing-read (this became especially ugly > using org-modern and code for right aligning tags with display properties). > > Something like this would fix it: > @@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags () > (org-element-cache-map > (lambda (el) > (dolist (tag (org-element-property :tags el)) > - (puthash (list tag) t hashed)))) > + (puthash (list (substring-no-properties tag)) t hashed)))) Thanks for reporting! Fixed on main via 6acc58c9c. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6acc58c9c6bcfd45dcc5964cac7e3df8347121cc -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92