* [BUG] org-get-buffer-tags no longer strips text properties
@ 2022-08-11 9:31 Anders Johansson
2022-08-11 11:40 ` Ihor Radchenko
0 siblings, 1 reply; 2+ messages in thread
From: Anders Johansson @ 2022-08-11 9:31 UTC (permalink / raw)
To: org-mode-email
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
Hi,
Commit 819409 introduced a change where the text-properties of tags
collected from a buffer are no longer stripped, which means tags may be
fontified in unwanted ways in completing-read (this became especially ugly
using org-modern and code for right aligning tags with display properties).
Something like this would fix it:
@@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags ()
(org-element-cache-map
(lambda (el)
(dolist (tag (org-element-property :tags el))
- (puthash (list tag) t hashed))))
+ (puthash (list (substring-no-properties tag)) t hashed))))
Best,
Anders Johansson
[-- Attachment #2: Type: text/html, Size: 815 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [BUG] org-get-buffer-tags no longer strips text properties
2022-08-11 9:31 [BUG] org-get-buffer-tags no longer strips text properties Anders Johansson
@ 2022-08-11 11:40 ` Ihor Radchenko
0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2022-08-11 11:40 UTC (permalink / raw)
To: Anders Johansson; +Cc: org-mode-email
Anders Johansson <mejlaandersj@gmail.com> writes:
> Hi,
> Commit 819409 introduced a change where the text-properties of tags
> collected from a buffer are no longer stripped, which means tags may be
> fontified in unwanted ways in completing-read (this became especially ugly
> using org-modern and code for right aligning tags with display properties).
>
> Something like this would fix it:
> @@ -11974,7 +11974,7 @@ (defun org-get-buffer-tags ()
> (org-element-cache-map
> (lambda (el)
> (dolist (tag (org-element-property :tags el))
> - (puthash (list tag) t hashed))))
> + (puthash (list (substring-no-properties tag)) t hashed))))
Thanks for reporting!
Fixed on main via 6acc58c9c.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6acc58c9c6bcfd45dcc5964cac7e3df8347121cc
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-11 11:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-11 9:31 [BUG] org-get-buffer-tags no longer strips text properties Anders Johansson
2022-08-11 11:40 ` Ihor Radchenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).