[PATCH] Fast tag de-selection face

[PATCH] Fast tag de-selection face

[Daniel Fleischer]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]


Bumping a patch; it solves a minor bug in which the tags in the fast tag
selection buffer do not toggle their face back to default after being
selected and deselected.

Attached.

 

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 1055 bytes --]

From 50fd7e953eed7c339886722c8247d9e492113eb8 Mon Sep 17 00:00:00 2001
From: Daniel Fleischer <danflscr@gmail.com>
Date: Fri, 8 Oct 2021 12:55:04 +0300
Subject: [PATCH] lisp/org.el: Fast tag selection disabled tag face

* lisp/org.el (org-fast-tag-selection): Disabled tags face

A tag can be either selected in "current", "inherited" or disabled. When
disabled, it should have the default face. Previously, if a tag was
already selected, when deselection it will still have an org-todo face.
---
 lisp/org.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lisp/org.el b/lisp/org.el
index 21b2c5470..bcc8356bb 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -12566,8 +12566,7 @@ (defun org-fast-tag-selection (current inherited table &optional todo-table)
 			       (cond
 				((member tag current) c-face)
 				((member tag inherited) i-face)
-				(t (get-text-property (match-beginning 1) '
-						      face))))))))
+				(t 'default)))))))
 		  (goto-char (point-min)))))
 	(delete-overlay org-tags-overlay)
 	(if rtn
-- 
2.33.1


[-- Attachment #3: Type: text/plain, Size: 23 bytes --]


-- 

Daniel Fleischer

Re: [PATCH] Fast tag de-selection face

[Ihor Radchenko]

Daniel Fleischer <danflscr@gmail.com> writes:

> Bumping a patch; it solves a minor bug in which the tags in the fast tag
> selection buffer do not toggle their face back to default after being
> selected and deselected.
>
> Attached.

For record, this patch has been applied.
Applied.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>