From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aBowB1DyL2RydgEASxT56A (envelope-from ) for ; Fri, 07 Apr 2023 12:37:04 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qOnpBlDyL2Q/NAEAauVa8A (envelope-from ) for ; Fri, 07 Apr 2023 12:37:04 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D72963D959 for ; Fri, 7 Apr 2023 12:37:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkjRz-0003bb-PH; Fri, 07 Apr 2023 06:36:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkjRx-0003Zg-It for emacs-orgmode@gnu.org; Fri, 07 Apr 2023 06:36:09 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkjRv-0001jp-Ax for emacs-orgmode@gnu.org; Fri, 07 Apr 2023 06:36:09 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F2B972402D5 for ; Fri, 7 Apr 2023 12:36:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680863765; bh=WV8vb9Au/PUuD0vaEi84LGrGWFXuegN6yg7YMqn52VA=; h=From:To:Cc:Subject:Date:From; b=SYcwBa/8+p6o2cSUUEO26jwaEXtpMu06KWMnUHZHZS3nwAyeCI9tZr+h+Td0yIkTh j1kx/yJTiv7WDENV1IPYPQd9hEY9SKSdddWFfcbP9Hg4SQfavxYpOB/qANkDI5A//U 00gxYNkL16vxBdmYKGZ/va3MXepSY+w7XAlTDR7lkmz+S1iDtT5AtRl/UdyOoxg8ng CMEpChlR+fVzdN7Fr4WOJLd46lbh3ySW/NbF6JJAqN5FMTuWcZCN3FIc3MoC/VIvSw j+RKFL9Z9M6NxVV8IchpLrIFvrmLieUBHDnx1LtcRbHh1RTHhaX3PHeA+IlVapDkJk jgEtWJCILHVEg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PtFC820Yvz6tvb; Fri, 7 Apr 2023 12:36:04 +0200 (CEST) From: Ihor Radchenko To: Aaron Zeng Cc: emacs-orgmode@gnu.org, app-emacs-dev@janestreet.com Subject: Re: [PATCH] Fix bug in orgtbl-self-insert-command when used with evil-escape In-Reply-To: References: Date: Fri, 07 Apr 2023 10:38:25 +0000 Message-ID: <875ya8kme6.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680863823; a=rsa-sha256; cv=none; b=ST9fchKvOme9hz3xqoZhSaoIaJ03vLgeJQZy+QGsAfBDStYQ7yh+2saKVFdhQbdhk2umWh zEcFwpC4/tbZ3PP2a+nUuzCrhkN8uQ4vnN+2cD809qfgErnc22VbG55/K6dEo5f1u0S7+H baU8gTzIRVad51E2OYWL6dBwwY4rBTQzTt6sl8SzsSSM74jr1XtbRahevjvbB52r9vrEvn jP5sYev+i7m7A1LMl0CcxkQbAe/+QoPBFZKjo3Em8M9ky9kWbiLs1zNf5tBdumBjDmwduY fhUZx5R4JWc2zCw91pwIsJk7+N2ZYRAQ7dFVXg4SyhjphdSZBzUbPxGY6JR3AA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="SYcwBa/8"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680863823; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=RlnglCltL11Dw5ihLeFBYuB04gDDgTTGfF5bqjHxqiU=; b=U2wHkQsXGerGrSVL0W1U+lgC9lst3cwrxedadWnv9z7Ta+hJE+DrdHcAoQ4wA4fig7Cd8o 3qwM31MrjKCN+f26lpmJ2YaJcOZG2xoQT/R/tGkeMdSMbKpmvRZWs7e5PxtbbKLZcyNx6o q2jCwGi/idI6pZ22qNHucEs+NktXv29vQQLXMkbJicZ/8zAJGYdpVH8lTV5dylhtS5B0VC WhRz+YrvzxxmUCG0cngEifR0ib6RjsvpLT0JLkA6DaEnXuypKJGnvA6p1TSJ2rRqzXfhcO Z6ZlQ4St/o03+yYzleCdcmFulI9FCftKJKrGaY/2A70UWGklAwuuFbpZiqj1og== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="SYcwBa/8"; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -9.72 X-Spam-Score: -9.72 X-Migadu-Queue-Id: D72963D959 X-TUID: 7GA1G+awByqN Aaron Zeng writes: > There appears to be a bug in orgtbl-self-insert-command, which uses last-input-event instead of last-command-event. self-insert-command itself uses the latter variable. > ... > With the patch, the above steps correctly insert f and then a newline. Thanks! Applied, onto bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=54a743cd7 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=19b0d0e5a -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at