From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id gNFVDXWJ7ma0PAAA62LTzQ:P1 (envelope-from ) for ; Sat, 21 Sep 2024 08:53:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id gNFVDXWJ7ma0PAAA62LTzQ (envelope-from ) for ; Sat, 21 Sep 2024 10:53:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gtp1R1Jb; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1726908789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=yOuQr2bmm2aGU/PYc+03bKKu9xTwkcYZ1s+LGv7EJxY=; b=Xak4TjPfZyfeZ8iW/x4vimoRiiL3v+TVCPru5dxcRHgdUd2UXpizKgL2SGqo+CLGWBeG6O 0ygrL/Pa/zkunGJ57pLRCLrEw79ks1uv1mD8HEsShPlzlU+vSYF7drdlqUXOAKA6l1/guZ CQemw/sPP7QpZntku/xXOHeg9CJBKAGMXS001KI23n8DOY6Yv6UzdasMhMbChbcVlk0B5/ FGMSVicgviaCGx4zf15v0gUr9jZ2/CzyudC+B9fZ0MREy6vrFfXH5moZrjc6Y7dLbQx1mY vC0tSBPFmwFn1XP1vXEwLTd0qdXCf8DJv3KTcys/W9+pGAvTpi0CKIEn4blF0A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1726908789; a=rsa-sha256; cv=none; b=u4+LO4g4t3AUNdzOkxexUNGudMYFk0TTkuWNTl9xje/xBIhiLUvT3AnYcJSSj7AeOOsY2Q /XhOdLjw6MGsSltCdmgjoNzC30zlAXN2K5uoilob4xgox5Tfyf1P6VgSebTCsAOiXlZsl8 YAKCQm5QOiQ38FknmyaUIKbN9FI2LZz6/cRzHN/faugaMVUrBU4eOB4JjY5AjwUzIok+iw 490Y6/XKgVBmtHRUKimWeY+pesPHB+DmPBnCZ4xRAcN0wsjYKxQtkfY6cQx9SEOPG/Y0+a Eyxz/oOapRh0lzDH00F+lmF3FCgQAQbAzzYjNIUTz5RE40Ap84Eezf7X8qAHXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gtp1R1Jb; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DD21381C20 for ; Sat, 21 Sep 2024 10:53:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srvqb-000834-LG; Sat, 21 Sep 2024 04:52:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srvqZ-00082v-M2 for emacs-orgmode@gnu.org; Sat, 21 Sep 2024 04:52:07 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srvqX-0004BU-Rm for emacs-orgmode@gnu.org; Sat, 21 Sep 2024 04:52:07 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 440E9240101 for ; Sat, 21 Sep 2024 10:52:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726908720; bh=5kyIjiEf9l4HTd/ccG7RD8Af2IQCXIduOVZbT2OP36M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=gtp1R1JbB+FXd8PE34yLgqaPBhgJbJx6yIWMN8YugiG230go5Nyqmu8WjBAmyv4qa a3es6kq3yZY4lH6cNr88Nb0C23x0iMfUpgMPj8jyEIimRcGbA9CnLpIuS1GFHxZg92 mU7b8Z2lMAwm1fkMPK9IbjdiAIAOLpWOLr8St5y5KLtX2ZpKS9S3JxU3JES2LYj8Kr ki0S39i+ysaD1I/Rvea4QfFXVGFa9fOxt04Yne/Z25V7Llh2aYemavoAHJtUt39Mpe +RRYqISdIUCxIZgpyMXe8+PEMKA1gYSVXhGH6D9YsjlhbJTXtWF2zCiyR/DLa/uKAI p9dl12K6/bwjQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X9jg33KBVz6v05; Sat, 21 Sep 2024 10:51:59 +0200 (CEST) From: Ihor Radchenko To: Jack Kamm Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix ox-icalendar export of diary timestamps In-Reply-To: <87y13tqvpd.fsf@gmail.com> References: <87y13tqvpd.fsf@gmail.com> Date: Sat, 21 Sep 2024 08:53:32 +0000 Message-ID: <875xqppeur.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.75 X-Migadu-Queue-Id: DD21381C20 X-Spam-Score: -9.75 X-TUID: VaRdDanxYFpx Jack Kamm writes: > ox-icalendar skips the following event with a diary timestamp during > export: > > * First Sunday of the month > <%%(diary-float t 0 1)> > > ox-icalendar actually has longstanding code to handle diary timestamps > [1], but that code path is not reached, in part because > `org-export--skip-p' always skips timestamps with type `diary'. > > The attached patch fixes this by including diary timestamps when the > export option `:with-timestamps' is `active'. I think it's reasonable > to consider diary timestamps as a type of active timestamp during > export, since they are included in the agenda, and have angle > brackets. I agree that it makes sense. However, it is technically a breaking change. May you please add a news entry as well? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at