emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH worg] .dir-locals.el: Disable byte-compilation.
@ 2024-12-03 21:43 Suhail Singh
  2024-12-05 15:50 ` Max Nikulin
  2024-12-10 19:47 ` Ihor Radchenko
  0 siblings, 2 replies; 4+ messages in thread
From: Suhail Singh @ 2024-12-03 21:43 UTC (permalink / raw)
  To: emacs-orgmode

---
 .dir-locals.el | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.dir-locals.el b/.dir-locals.el
index 962c17f2..9f7310ed 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,3 +1,6 @@
+;;; Directory Local Variables            -*- no-byte-compile: t -*-
+;;; For more information see (info "(emacs) Directory Variables")
+
 ((nil
   (indent-tabs-mode . t)
   (tab-width . 8)


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.
  2024-12-03 21:43 [PATCH worg] .dir-locals.el: Disable byte-compilation Suhail Singh
@ 2024-12-05 15:50 ` Max Nikulin
  2024-12-10 14:50   ` Suhail Singh
  2024-12-10 19:47 ` Ihor Radchenko
  1 sibling, 1 reply; 4+ messages in thread
From: Max Nikulin @ 2024-12-05 15:50 UTC (permalink / raw)
  To: emacs-orgmode

On 04/12/2024 04:43, Suhail Singh wrote:
> +++ b/.dir-locals.el
> @@ -1,3 +1,6 @@
> +;;; Directory Local Variables            -*- no-byte-compile: t -*-

Sorry, I do not follow Emacs development close enough. Does it mean that 
it becomes more aggressive and tries to compile files that do not really 
affect performance?

I recall intentions to implement some exceptions for `lexical-bindning', 
so I would expect that .dir-locals.el files are not compiled by default. 
I mean the following thread:

<https://yhetil.org/emacs-devel/50E29988-D354-4D10-990F-31828DBE6411@gmail.com/>
emacs-devel. missing lexical-binding cookie warning when loading .el 
files. Fri, 3 May 2024 19:28:02 +0200



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.
  2024-12-05 15:50 ` Max Nikulin
@ 2024-12-10 14:50   ` Suhail Singh
  0 siblings, 0 replies; 4+ messages in thread
From: Suhail Singh @ 2024-12-10 14:50 UTC (permalink / raw)
  To: Max Nikulin; +Cc: emacs-orgmode

Hello Max,

Please note that I am not subscribed to the mailing list.  As such,
please ensure that you include my email in the addresses if you'd like a
timely response (or, in some cases, a response at all).

Max Nikulin <manikulin@gmail.com> writes:

> On 04/12/2024 04:43, Suhail Singh wrote:
>> +++ b/.dir-locals.el
>> @@ -1,3 +1,6 @@
>> +;;; Directory Local Variables            -*- no-byte-compile: t -*-
>
> Sorry, I do not follow Emacs development close enough. Does it mean that it
> becomes more aggressive and tries to compile files that do not really affect
> performance?

Since 2022-10-05, when adding directory-local-variables, the
no-byte-compile cookie gets set.  I believe this change was introduced
in response to bug #58486.

-- 
Suhail


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH worg] .dir-locals.el: Disable byte-compilation.
  2024-12-03 21:43 [PATCH worg] .dir-locals.el: Disable byte-compilation Suhail Singh
  2024-12-05 15:50 ` Max Nikulin
@ 2024-12-10 19:47 ` Ihor Radchenko
  1 sibling, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-12-10 19:47 UTC (permalink / raw)
  To: Suhail Singh; +Cc: emacs-orgmode

"Suhail Singh" <suhailsingh247@gmail.com> writes:

> ---
>  .dir-locals.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.dir-locals.el b/.dir-locals.el
> index 962c17f2..9f7310ed 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,3 +1,6 @@
> +;;; Directory Local Variables            -*- no-byte-compile: t -*-
> +;;; For more information see (info "(emacs) Directory Variables")

Thanks!
Applied.
https://git.sr.ht/~bzg/worg/commit/650cce9a

I modified the commit message removing "." after the commit title and
adding the explanation you gave to Max.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-12-10 19:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03 21:43 [PATCH worg] .dir-locals.el: Disable byte-compilation Suhail Singh
2024-12-05 15:50 ` Max Nikulin
2024-12-10 14:50   ` Suhail Singh
2024-12-10 19:47 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).