From: Ihor Radchenko <yantar92@posteo.net>
To: Max Nikulin <manikulin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] etc/ORG-NEWS: Clarify org-protocol bookmarklet issue
Date: Sat, 28 Dec 2024 16:58:21 +0000 [thread overview]
Message-ID: <875xn39236.fsf@localhost> (raw)
In-Reply-To: <vkp6p5$16ck$1@ciao.gmane.io>
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
Max Nikulin <manikulin@gmail.com> writes:
>> I also added an entry to ORG-NEWS:
>> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0af98b8411
>
> I do not like "spawn empty page". See the attachment for another variant
> of wording.
You modified more than just "spawn empty page".
What about the attached?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-etc-ORG-NEWS-Improve-wording.patch --]
[-- Type: text/x-patch, Size: 1287 bytes --]
From 9425bf11ca4d56d55dbc1a37eeeb76ba90dc680d Mon Sep 17 00:00:00 2001
Message-ID: <9425bf11ca4d56d55dbc1a37eeeb76ba90dc680d.1735405057.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Sat, 28 Dec 2024 17:56:48 +0100
Subject: [PATCH] etc/ORG-NEWS: Improve wording
* etc/ORG-NEWS (You may need to update =org-protocol= bookmarklets for browsers):
Clairfy what exactly happens when old bookmarklets are used.
---
etc/ORG-NEWS | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/etc/ORG-NEWS b/etc/ORG-NEWS
index a56e105481..81b2d401e4 100644
--- a/etc/ORG-NEWS
+++ b/etc/ORG-NEWS
@@ -20,9 +20,10 @@ Please send Org bug reports to mailto:emacs-orgmode@gnu.org.
*** You may need to update =org-protocol= bookmarklets for browsers
-In Firefox-133, Firefox-128.5 ESR, and later, javascript bookmarklets
-may spawn empty page. We have updated the manual with new
-bookmarklets that do not have such problem.
+In Firefox-133, and Firefox-128.5 ESR the previously suggested
+javascript bookmarklets replace current page with bookmarklet URL
+text. We have updated the manual with new bookmarklets that do not
+have such problem.
TL;DR: ~void(0);~ needs to be added to the bookmarklets, so that they
do not return anything.
--
2.47.1
[-- Attachment #3: Type: text/plain, Size: 223 bytes --]
--
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-12-28 16:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 8:12 [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen
2024-12-12 10:34 ` Max Nikulin
2024-12-12 14:14 ` Max Nikulin
2024-12-12 18:47 ` Rehan Deen
2024-12-13 11:09 ` Max Nikulin
2024-12-16 16:01 ` [PATCH] org-protocol: Add void() to bookmarklets Max Nikulin
2024-12-16 16:40 ` Max Nikulin
2024-12-22 12:43 ` Ihor Radchenko
2024-12-22 12:42 ` Ihor Radchenko
2024-12-24 14:14 ` Max Nikulin
2024-12-24 14:23 ` Ihor Radchenko
2024-12-27 16:48 ` [PATCH v2] " Max Nikulin
2024-12-27 18:13 ` Ihor Radchenko
2024-12-28 15:50 ` [PATCH] etc/ORG-NEWS: Clarify org-protocol bookmarklet issue Max Nikulin
2024-12-28 16:58 ` Ihor Radchenko [this message]
2024-12-29 11:45 ` Max Nikulin
[not found] ` <875xnp6qin.fsf@gmail.com>
2024-12-12 17:15 ` [BUG] Org-protocol bookmarklets in Firefox behaving badly after recent upgrade [9.6.15 (release_9.6.15 @ /usr/share/emacs/29.4/lisp/org/)] Rehan Deen
2024-12-26 16:49 ` Max Nikulin
2024-12-28 13:55 ` Rehan Deen
2024-12-28 16:05 ` Max Nikulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xn39236.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).