From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Sojka Subject: Re: [Accepted] icalendar: Make alarm duration RFC5545 compliant Date: Wed, 24 Aug 2011 09:53:21 +0200 Message-ID: <874o175jpq.fsf@steelpick.2x.cz> References: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de> <20110513124201.9070A44BC0F@u016822.science.uva.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([140.186.70.92]:47112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw8HC-0005IL-Uf for emacs-orgmode@gnu.org; Wed, 24 Aug 2011 03:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qw8H8-00064x-4n for emacs-orgmode@gnu.org; Wed, 24 Aug 2011 03:53:30 -0400 Received: from max.feld.cvut.cz ([147.32.192.36]:57864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qw8H7-00062S-VO for emacs-orgmode@gnu.org; Wed, 24 Aug 2011 03:53:26 -0400 In-Reply-To: <20110513124201.9070A44BC0F@u016822.science.uva.nl> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik , emacs-orgmode@gnu.org Hi, it seems that the following patch still didn't appear in the official repo. Shall I resend it with the commit message according to http://orgmode.org/worg/org-contribute.html#sec-5, especially with TINYCHANGE? Thanks, Michal On Fri, 13 May 2011, Carsten Dominik wrote: > Patch 803 (http://patchwork.newartisans.com/patch/803/) is now "Accepted". > > Maintainer comment: none > > This relates to the following submission: > > http://mid.gmane.org/%3C1305189019-23615-1-git-send-email-sojka%40os.inf.tu-dresden.de%3E > > Here is the original message containing the patch: > > > Content-Type: text/plain; charset="utf-8" > > MIME-Version: 1.0 > > Content-Transfer-Encoding: 7bit > > Subject: [O] icalendar: Make alarm duration RFC5545 compliant > > Date: Thu, 12 May 2011 13:30:19 -0000 > > From: Michal Sojka > > X-Patchwork-Id: 803 > > Message-Id: <1305189019-23615-1-git-send-email-sojka@os.inf.tu-dresden.de> > > To: Eric S Fraga , > > emacs-orgmode@gnu.org > > Cc: Michal Sojka > > > > The format of alarm trigger was incorrect because "T" letter from > > dur-time element was missing (see > > http://tools.ietf.org/html/rfc5545#section-3.3.6). This caused some > > software (such as KOrganizer) to not interpret the alarms correctly. > > > > --- > > lisp/org-icalendar.el | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/lisp/org-icalendar.el b/lisp/org-icalendar.el > > index c4b1f89..3632b5e 100644 > > --- a/lisp/org-icalendar.el > > +++ b/lisp/org-icalendar.el > > @@ -419,7 +419,7 @@ When COMBINE is non nil, add the category to each line." > > (let ((t1 (ignore-errors (org-parse-time-string ts 'nodefault)))) > > (if (and (> org-icalendar-alarm-time 0) > > (car t1) (nth 1 t1) (nth 2 t1)) > > - (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0D0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time)) > > + (setq alarm (format "\nBEGIN:VALARM\nACTION:DISPLAY\nDESCRIPTION:%s\nTRIGGER:-P0DT0H%dM0S\nEND:VALARM" summary org-icalendar-alarm-time)) > > (setq alarm "")) > > ) > > (if (string-match org-bracket-link-regexp summary) > >