From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Tangling is broken in git master Date: Mon, 13 Aug 2012 21:00:04 +0200 Message-ID: <874no6wrbf.fsf@gnu.org> References: <87628oncqa.fsf@norang.ca> <871ujc33gd.fsf@gnu.org> <87lihj7dyw.fsf@norang.ca> <87sjbrs5wh.fsf@gnu.org> <877gt2sy83.fsf@gmx.com> <87r4rayjxu.fsf@gnu.org> <87obmeg9il.fsf@gmx.com> <10731.1344869187@alphaville> <87pq6ux2pk.fsf@gnu.org> <11277.1344872323@alphaville> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34251) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zrZ-0007Fd-NX for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 14:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0zrX-0005Og-9U for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 14:59:41 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:38409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0zrX-0005OV-1n for emacs-orgmode@gnu.org; Mon, 13 Aug 2012 14:59:39 -0400 Received: by wgbez12 with SMTP id ez12so2971228wgb.30 for ; Mon, 13 Aug 2012 11:59:38 -0700 (PDT) In-Reply-To: <11277.1344872323@alphaville> (Nick Dokos's message of "Mon, 13 Aug 2012 11:38:43 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: nicholas.dokos@hp.com Cc: Bernt Hansen , emacs-orgmode@gnu.org, Eric Schulte Hi Nick, Nick Dokos writes: > I'd suggest that that can be a source of bugs that would be > avoided with a compatibility macro. `org-labels' is an alias for `cl-labels' (when available) or `labels'. There is no need for a compatibility macro here, as the current code is compatible with both Emacs 23 and Emacs 24 -- and hopefully later versions of Emacs. The question is rather whether we want to be very strict and replace as much cl-* constructs as possible. Nicolas shown a way to let-bind functions recursively (which is simple and neat, by the way), so yes, I'd favor replacing org-labels in this case. Especially because the cl-labels and labels macros do not work exactly the same way. See labels' docstring: ... Like `cl-labels' except that the lexical scoping is handled via `lexical-let' rather than relying on `lexical-binding'. > But maybe the compatibility macro would be a bigger problem - I don't > know for sure. In particular, the file would need a periodic cleanup to > get rid of old cruft, but if it's a once-a-year-or-two occurrence, that > might not be too bad. Always good to know there are many people we can rely on to clean the old cruft :) -- Bastien