From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [PATCH 07/10] Simplify org-babel-execute-src-block Date: Wed, 03 Apr 2013 19:05:33 +0200 Message-ID: <874nfnczoi.fsf@Rainer.invalid> References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> <1364794944-13826-8-git-send-email-aaronecay@gmail.com> <878v50u3dl.fsf@Rainer.invalid> <87vc83y79x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:40334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNR8G-0001W0-JF for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 13:05:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNR89-0006AG-M3 for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 13:05:56 -0400 Received: from plane.gmane.org ([80.91.229.3]:50805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNR89-0006A1-As for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 13:05:49 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UNR8V-0005Aq-JY for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 19:06:11 +0200 Received: from pd9eb502f.dip.t-dialin.net ([217.235.80.47]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Apr 2013 19:06:11 +0200 Received: from Stromeko by pd9eb502f.dip.t-dialin.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 03 Apr 2013 19:06:11 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Eric Schulte writes: > Can you check if this change causes any of the existing tests to fail? I don't think there is a test for that, at least I don't remember anything in that direction. However when implementing my earlier change w.r.t. confirmation I noticed that merging the parameters early has potential for triggering execution of source blocks that would otherwise lay dormant until the execution of the current block was already confirmed. As I said, I have no idea if this behaviour is intended, but that was reason enough for me not to try to "optimize" this away. The behaviour Aaron tries to implement is maybe more sane, but it does alter some corner cases and I can't tell how practically relevant this is. But if we want to change it then I agree that the time is now. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Waldorf Blofeld: http://Synth.Stromeko.net/Downloads.html#BlofeldUserWavetables