[PATCH] Re: function for cleaning org-attach directories

[Eric Abrahamsen <eric@ericabrahamsen.net>]

[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> On 2015-07-18 05:11, Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Alan Schmitt <alan.schmitt@polytechnique.org> writes:
>>
>>> I gave this a try and it seems that `org-attach-directory' needs to be
>>> defined for it to work. I'm surprised because I never configured this
>>> and with gnorb I have had files attached using org-attach. Does gnorb
>>> use a default value for this?
>>
>> Gnorb has calls to (require 'org-attach) in certain places -- unless
>> you've loaded and used gnorb in your current session, you'll probably
>> want to require that yourself.
>
> Ah, yes, of course. It seems to be working, but it’s awfully silent. It
> would be great if it gave some feedback (I don’t know if it actually
> deleted anything, as there was nothing in the *Messages* buffer).

Whoops, forgot about this! Feedback is a very good idea. I'm sending
another version, this time as a patch in case this is something that
would be welcome in Org proper.

Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-attach.el-New-function-to-delete-unused-dirs.patch --]
[-- Type: text/x-diff, Size: 1835 bytes --]

From 03a8ddacf004d49a51eb7b0b48660fc31da955ac Mon Sep 17 00:00:00 2001
From: Eric Abrahamsen <eric@ericabrahamsen.net>
Date: Sat, 1 Aug 2015 17:19:49 +0800
Subject: [PATCH] org-attach.el: New function to delete unused dirs

* lisp/org-attach.el (org-attach-clean-dirs): New function.
---
 lisp/org-attach.el | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/lisp/org-attach.el b/lisp/org-attach.el
index 7f61910..84dc5a0 100644
--- a/lisp/org-attach.el
+++ b/lisp/org-attach.el
@@ -498,6 +498,39 @@ This function is called by `org-archive-hook'.  The option
 
 (add-hook 'org-archive-hook 'org-attach-archive-delete-maybe)
 
+(defun org-attach-clean-dirs (&optional attach-dir clean-archived)
+  "Delete attach directories (and their contents) for headings
+which no longer exist."
+  (interactive)
+  (let ((attach-dir
+	 (if attach-dir
+	     (file-name-as-directory attach-dir)
+	   (concat (file-name-as-directory org-directory)
+		   org-attach-directory)))
+	(valid-dir-re "\\`[0-9a-z-]+\\'")
+	(org-id-search-archives (if clean-archived nil org-id-search-archives))
+	dead-dirs)
+    (dolist (d (directory-files attach-dir nil valid-dir-re))
+      (dolist (d+ (directory-files
+		   (concat attach-dir d) nil valid-dir-re))
+	(let ((id (format "%s%s" d d+))
+	      (full-path (concat
+			  attach-dir
+			  (file-name-as-directory d)
+			  d+)))
+	  (unless (org-id-find id)
+	    (push full-path dead-dirs)))))
+    (if dead-dirs
+	(progn
+	  (message "Deleting %d dead attach directories..." (length dead-dirs))
+	  (mapcar
+	   (lambda (d)
+	     (with-demoted-errors
+		 (delete-directory d t)))
+	   dead-dirs)
+	  (message "Deleting %d dead attach directories... done"))
+      (message "No dead directories to delete."))))
+
 (provide 'org-attach)
 
 ;; Local variables:
-- 
2.5.0