From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: [PATCH] org-id-goto doesn't work if buffer is narrowed. Date: Fri, 23 Oct 2015 17:27:03 +0200 Message-ID: <874mhh1u7s.fsf@gmx.us> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpeFX-0002xB-3B for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 11:27:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpeFT-0008KY-QW for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 11:27:23 -0400 Received: from plane.gmane.org ([80.91.229.3]:39836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpeFT-0008KM-LC for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 11:27:19 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ZpeFK-0007FS-5U for emacs-orgmode@gnu.org; Fri, 23 Oct 2015 17:27:10 +0200 Received: from 62.80.108.11 ([62.80.108.11]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Oct 2015 17:27:10 +0200 Received: from rasmus by 62.80.108.11 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 23 Oct 2015 17:27:10 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi Puneeth, Thanks for your patch. Puneeth Chaganti writes: > I've attached a one-line patch to fix `org-id-goto' if the target > buffer is narrowed. Let me know if this fix sounds reasonable or if > you have other suggestions! It's not obvious that org should change a—potentially—carefully selected narrowed region. Perhaps you could mimic the way org-edit-special works for this case. Thanks, Rasmus -- And when I’m finished thinking, I have to die a lot