From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] expose nrepl's timeout setting in ob-clojure.el
Date: Tue, 12 Apr 2016 22:18:27 +0200
Message-ID: <874mb6y418.fsf@nicolasgoaziou.fr>
References: <56FABD8E.2000705@fgiasson.com> <87twjfcbt6.fsf@nicolasgoaziou.fr>
	<570521D3.4030009@fgiasson.com> <87vb3pnad5.fsf@nicolasgoaziou.fr>
	<0b7090aa-5c49-9364-e18c-28627ae3911f@fgiasson.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38527)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aq4jV-0008Ps-3M
	for emacs-orgmode@gnu.org; Tue, 12 Apr 2016 16:16:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aq4jQ-0008DX-4b
	for emacs-orgmode@gnu.org; Tue, 12 Apr 2016 16:16:21 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:59757)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aq4jP-0008DT-UX
	for emacs-orgmode@gnu.org; Tue, 12 Apr 2016 16:16:16 -0400
In-Reply-To: <0b7090aa-5c49-9364-e18c-28627ae3911f@fgiasson.com> (Frederick
	Giasson's message of "Mon, 11 Apr 2016 10:03:08 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Frederick Giasson <fred@fgiasson.com>
Cc: emacs-orgmode@gnu.org

Hello,

Frederick Giasson <fred@fgiasson.com> writes:

>>>   	 (setq result
>>>   	       (nrepl-dict-get
>>> -		(nrepl-sync-request:eval
>>> -		 expanded (cider-current-connection) (cider-current-session))
>>> +		(let ((nrepl-sync-request-timeout org-babel-clojure-sync-nrepl-timeout))
>>> +		  (nrepl-sync-request:eval
>>> +		   expanded (cider-current-connection) (cider-current-session)))
>> You forgot to
>>
>> (defvar nrepl-sync-request-timeout)
>
> This one is defined in the nREPL package. Maybe there is something
> that I don't understand, but do I have to re-defined it here?

The byte-compiler complains if a variable is let-bound but yet not used
in the body. You don't need to define it again but tell the
byte-compiler it is dynamically scoped (using `defvar' without a value).

Regards,

-- 
Nicolas Goaziou