From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 6PfWG3zwPGMIpQAAbAwnHQ (envelope-from ) for ; Wed, 05 Oct 2022 04:48:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id MI3RG3zwPGNLYQAAauVa8A (envelope-from ) for ; Wed, 05 Oct 2022 04:48:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2E24C1D922 for ; Wed, 5 Oct 2022 04:48:27 +0200 (CEST) Received: from localhost ([::1]:56224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofuSP-0002Ke-AZ for larch@yhetil.org; Tue, 04 Oct 2022 22:48:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofuRL-0002KV-KL for emacs-orgmode@gnu.org; Tue, 04 Oct 2022 22:47:19 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:55165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofuRJ-0004Pg-Pe; Tue, 04 Oct 2022 22:47:19 -0400 Received: by mail-pj1-x102f.google.com with SMTP id 70so14462158pjo.4; Tue, 04 Oct 2022 19:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=bDQ41MmBvNfgYMubpu23QEGudaRwx0EiAG7l6MpMON0=; b=bR/iWMlCn7fOiNnlUewIKU/ddqspP3vH53HGLjd7qrOMBz0vpMKowUT19cR594n7Nb KulUTL3BW9O7uv4vq3keVc9PLy93ktSYwlXF9fZZcEWDOZFJNrHQWBRKjGEbeOKHxUFC l9l7rol/bhx9B/c3xmcq9akColMfbKbLek54fvNnwVEr8YTxWzOHGoB9HlPk1NG7DlHP 5QBZ5Wr0gtTwQb9Mo1aauRurpn+zF+0ROPZU4tbsj8Yx51PUiO2OAujXYLY7elSHf2vb IKyHMMv47ISoU24JWo4dEsDTm7Vu0G7czGTl6KO1qg3ot8NRRfQbXIA4WAJC3W+C7EAK OeXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=bDQ41MmBvNfgYMubpu23QEGudaRwx0EiAG7l6MpMON0=; b=sR1258zuiM1Qw2N4c0OydQi87dXTnx8Syt5jQqsHvTQTHAh4P4s6ErcJXkmCe3YccQ Ri5PDB+gt8OwQsNPhhrKRnBTFOgG2osaC2GDSJWux3i6RQ+F/WfmwPo9J11Q2TfpPzLi TLMs3NpiDNu9NHr0oBiC4hlZJ4NPJ3+aTTnG6Q7XBLYh1CqZPbVFMpbnx/1P1uKubNd8 WQngZZG8VrBalG5DWqqH888mkCOp8xVkwAhRWAoTxouq+uEeQSemOSiDkR92jetT3319 OkZGET7I+LisJzdYeUBAPKanZ5oidbdWdcuuW/6Y8rN84A9n9Gofjb9mWGg4iOakH2JL 3xNg== X-Gm-Message-State: ACrzQf0u3abKlQSvf470oP+jrbG9o4k0ZOF0ztTJtrZDmMHghoaG8sPT 2lpXUNr6z1atCyuy4t1e9YY= X-Google-Smtp-Source: AMsMyM4SDgQUVrU+fkIkQkiKD66MEFyrvKy4Y95YBOaCdEbttwOh+SDWIhaO4IiESP6MtYpBwnqFrg== X-Received: by 2002:a17:90b:2705:b0:20a:b4fa:f624 with SMTP id px5-20020a17090b270500b0020ab4faf624mr2770804pjb.124.1664938035851; Tue, 04 Oct 2022 19:47:15 -0700 (PDT) Received: from localhost ([2409:8970:af2:32f:8ec6:81ff:fe70:339d]) by smtp.gmail.com with ESMTPSA id n7-20020a1709026a8700b0017bb38e4591sm9596661plk.41.2022.10.04.19.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 19:47:15 -0700 (PDT) From: Ihor Radchenko To: Liu Hui , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky agenda In-Reply-To: <87edvochb7.fsf@gmail.com> References: <87edvochb7.fsf@gmail.com> Date: Wed, 05 Oct 2022 10:48:00 +0800 Message-ID: <874jwjasv3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=yantar92@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1664938107; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=bDQ41MmBvNfgYMubpu23QEGudaRwx0EiAG7l6MpMON0=; b=L7WzoA7DW7bs6G6oi20cvfjO5m2inBL2VOdwUgvcPVPFmMYIHbkFNw07RsLMkspa7Xi1kT pXkgqGCbYUUypBojeJooCjonbmDCuwvDkwyAjh9pBcfQqvNtgc2bHUC0jZBlRZE377LkHy dOr+3jZ/642pBfJswWgbGw40KU+VMiIdvGMWle3mYy8QaoY8IEZLWScLg9cocycOAACng5 QJpFxGmLuOkgjh3qeXFJCyMm21zPXZCdKx61/lSri+zE3HZ4o//PiZ8lW3tWFGIUdSNUd3 o/zv2XOAC4kHrSTJ8rQg/rjWWmPMwh9yI65heAJ3hEL7rwORe0m/eHDUoPf+1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1664938107; a=rsa-sha256; cv=none; b=ujo2LS0WJn/nEs8aw2NjTqMbSkg9MiL5mM07X8gza6A/OFaHJMPbXvkQumngyaaqkw7vdU 1R1FFlDwy6zciIrZ/jF3vz4BU4y8aU2VTCSxf7VhnNqwez8tBQaJB5+we3YP3JTeDvkKKK 4Re5BEOsnnDVwQH53o2nXZjC2Hj4VUidzbQ08gF6RNq0E+izxx1pMwgP2I77xfOa9WvUEe wJmHa/IyQAbBiVkAxfdxYNdmT//6ycdqMyD/JTbAVbcEzyIx2XK+9bb3MlrTxdeC2oxOM3 SPzZalEuhZqZYN05nU2fC6PKdwmqro4jHwJI3U6K5va6xgJBDsc2o46CHjRs3Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="bR/iWMlC"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.66 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="bR/iWMlC"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2E24C1D922 X-Spam-Score: -3.66 X-Migadu-Scanner: scn0.migadu.com X-TUID: B9NPL27kb+Au Liu Hui writes: > I have signed the FSF > copyright assignment paper. Bastien, could you please confirm the FSF records? > This patch fixes the bug originally reported in > https://list.orgmode.org/59e02fb6.1462370a.fffe8.51c4@mx.google.com/ > with the following reproducing recipe. The bug still exists in latest > org-mode. > ... > > Because the filter presets are stored as symbol properties, they > cannot be used with multiple sticky agenda buffers. The patch fixes > the problem by adding a new variable `org-agenda-filters-preset' for > getting and setting per-buffer filter presets. I have signed the FSF > copyright assignment paper. Thanks a lot for the contribution! > Subject: [PATCH] lisp/org-agenda.el: Fix filter preset problem for sticky > agenda The patch is generally good. I just have one minor comment and one suggestion. > +(defvar org-agenda-filters-preset nil > + "Preset of filters, which becomes buffer-local in org-agenda buffers.") Can you detail the value format in the docstring? It would also be useful to mention `org-agenda-local-vars'. Otherwise, the reader might be confused how `defvar' is buffer-local. Also, may you create a test for the reported bug in testing/lisp/test-org-agenda.el? -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92