From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CBZDNfppEGSyVwEASxT56A (envelope-from ) for ; Tue, 14 Mar 2023 13:35:06 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KGUuNfppEGQCJQAA9RJhRA (envelope-from ) for ; Tue, 14 Mar 2023 13:35:06 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9599515173 for ; Tue, 14 Mar 2023 13:35:06 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oMbpEhRJ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678797306; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OvcFnYv+kHe9ArD7BnQE65ApwxxMEm+S5LDHO08EyAA=; b=Q9sGMZcPveCPAHEKOsekMi6a/Zlqig8GJzTxv/ReXRf+XDgKePByIJoHcYHcwIrsy8Z03j /H5QLnatebPdqnJ5TgL9o25uDoVBFDD7/t0LAEfama+qK6yTGi2CNcJz3aOouxXb5GSPhK 7fCZ3IDi4/0lyr9mRLGpf9Hg9m3y+5cjFWLIV17h5CZsc+T5XFMS9Iq0L+cBQRv1FRAX1Q ugCxsKPZGlrmTuQx6NDeeQZt+ji+vPqa/SbH684yW8ozKb/RgpTfIiusTBxkUxUv4ObWn4 WcEVul8loczsKA5Uky0cGnJtsvmHwtq+YqDPn/XIchIMVtAHICqBgWr3h+/7nQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=oMbpEhRJ; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678797306; a=rsa-sha256; cv=none; b=VcbtsoZrjrL2GuJnEVGM6nUi5QhFDkGPfaZXmr8cCGnMY51nTQK3LzupM6n92Mn2gHIhXr ZwykZg/41R8wiJntIYo0WtxYuBS49xyrj8seHMHzyPYp5D26dwF8EpqLbh8CrT6jHSGQ2g uiOtvtHkQvrUQ0Kv+XjxORi7flM6E6sokSTc2rw+2iybDxsHW4pVAAimPjegzbr8BlBM8m LiFFLVfOILTSXxdhK9dmSfmr7Z5D+vSw9P46v4YpYd93uZti6He20+cI0Dbc5Gfi/4DfQ6 R4xR14kHlZbC7YlD3qxDKIjsd6F2mdX75YXsZ4Dm+CJaBOK0VNUvNHh8AkMZqQ== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pc3rG-000587-Km; Tue, 14 Mar 2023 08:34:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc3rE-00057f-Q3 for emacs-orgmode@gnu.org; Tue, 14 Mar 2023 08:34:24 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pc3rC-00064v-I9 for emacs-orgmode@gnu.org; Tue, 14 Mar 2023 08:34:24 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5DB9A240444 for ; Tue, 14 Mar 2023 13:34:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678797260; bh=Yb1NKGLYqJ9517d4B8uPsGwlmrST7pXo1f7jGRD43Kc=; h=From:To:Cc:Subject:Date:From; b=oMbpEhRJBISpvhBtMK/Sg8bMH4JgeUEWdOJrv3QA3CHUevqq3R8bu059h28zuEkqf pE/nwkvCJ+fKssKVUoaxKeYkhriqZF7DWi/u4GfTRDj8iCZYHGZ0etLebm6MEGtxuW D9sQSPdUSaem/KvaVw73dDBDKP5siapsJ4BhWM+CxGfzxy2foJfauyyxZMNFTslUKO oRkfclfNiA+Sjb+kloPXfexAqX1vSbsiJUfR/VOj3owvK8XdOdNvStHLDRa+WLpWZI BMKe34LrddxKV8qqavp0aZOiVjdRSaW9H/UxBFmTH0+I6RWJQl58AfPPFAa+FXesSN hiFJlopsUVNUw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PbXyY5jZWz9rxN; Tue, 14 Mar 2023 13:34:13 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: emacs-orgmode@gnu.org Subject: Re: [patch] ob-clojure: Fix results output In-Reply-To: <877cvkhh9d.fsf@kraus.my> References: <87mt4m53qj.fsf@kraus.my> <87pm9gyebl.fsf@localhost> <877cvkhh9d.fsf@kraus.my> Date: Tue, 14 Mar 2023 12:35:39 +0000 Message-ID: <874jqno6hw.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 9599515173 X-Spam-Score: -11.53 X-Migadu-Spam-Score: -11.53 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: 2r9fUPE1wH6g Daniel Kraus writes: >> Also, make sure that >> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html >> is up-to-date. > > Good reminder. I send a PR for this when this patch is installed?! Or together. Either way is fine. >> Note: I do not see :target header arg being documented in >> https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html > > This was apparently a kludge that ob-clojure used to evaluate ClojureScript > in the normal clojure:execute function. > I simply used the same kludge where I need to check for cljs, but after > reviewing it's not really necessary and I removed the :target parameter > completely. As this was undocumented I guess it's ok to remove?! Yes, it is OK to remove what is undocumented. We may still announce the change though. >>> -(defun ob-clojure-eval-with-babashka (bb expanded) >>> - "Evaluate EXPANDED code block using BB (babashka or nbb)." >>> - (let ((script-file (org-babel-temp-file "clojure-bb-script-" ".clj"))) >> >> This will remove a non-private function. May you leave a fallback >> obsolete alias to not break third-party code that calls the old function >> name? > > I created an obsolete-function-alias. It should better go to org-compat.el. > Attached is the new patch with the changes. Thanks! A few more comments below. > +*** New ~org-babel-clojurescript-backend~ option to choose ClojureScript backend > + > +Before, a ClojureScript source block used the same backend as Clojure, > +configured in ~org-babel-clojure-backend~ and relied on an undocumented > +~:target~ paramter. > + > +Now, there's ~org-babel-clojurescript-backend~ to determine the > +backend used for evaluation of ClojureScript. What about the new customization `ob-clojure-cli-command'? > -(defcustom ob-clojure-nbb-command (executable-find "nbb") > +(defcustom ob-clojure-nbb-command (or (executable-find "nbb") > + (when-let (npx (executable-find "npx")) > + (concat npx " nbb"))) > "Path to the nbb executable." This is not a path anymore, when the value is "npx nbb". Can just use "Command to invoke nbb executable". -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at