From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id COAAA9iEn2ZbjwAA62LTzQ:P1 (envelope-from ) for ; Tue, 23 Jul 2024 10:24:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id COAAA9iEn2ZbjwAA62LTzQ (envelope-from ) for ; Tue, 23 Jul 2024 12:24:24 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=TFbMIj98; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721730263; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MMgfe/NnzI89zJtE9U6XxGOcTCC3xQgFP8E1ge4V/zE=; b=VLXKQKr7vUn66W5p3mHamzfpBkacIZdSQIJ7AduIIJAmVNa7sKpxsBQxJTq3z9vGN/Qp7x lQK9gzzYQcVrYv7s4IuXzJMubMkx6UqGZgklaTW3sm9IQUlN3sq8LGOjh3cto3pak+y+yf uIULV/493JQ5EI3SdeE4956jAw9PSsdatzXJ8+DaJ642s6hVGNUe+RMJzF2PCJKs+1jY3t P/pZYWSMcGyPPNfqcZAodDUIK1Bv0JoRZQzg5MYgOJc6NX9KEJNgmA6Z7i9E9CcbP+7CRE dd23wv6xqiS1jm0qx1dh1BoouAnyS1EyU+V/R7G7/fUPDoSPSpNOTLvoj1HTbQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721730263; a=rsa-sha256; cv=none; b=G3y57pL0RbN2479CIJ/MrSQ29SqibXY9ViMGvVfHx7oHs9GzPEczbTRvaHTs8cu08ivZ3u FGm7FFJQ34NTHM0zNrE2h3YOkzE09oVGtV/8qLMr2yWfL0/zVaVXsu/iXGyTGRBiEjIIwy BdeMCUpSHUeQP6sAQ2d8SNhCmBIPL9gkENXz+GAddD9JvheHWAoGsunCANTFJCxItB+oV0 IFu3XIL3d37Ff76M6PhDRLJH3SMh5+Q7PVl69a2bZKiQzJn3H2QiqGrHVAq3DT9yKkAzPr mm93jHOL5rpxYwBP3b4lAabgnls875P7uiW3OmE+Oz+UgaGLgsZ84bedTnGeMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=TFbMIj98; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D357132C74 for ; Tue, 23 Jul 2024 12:24:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWCg9-0006OD-RF; Tue, 23 Jul 2024 06:23:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWCg7-0006Nv-9K for emacs-orgmode@gnu.org; Tue, 23 Jul 2024 06:23:31 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWCg5-0002QZ-9i for emacs-orgmode@gnu.org; Tue, 23 Jul 2024 06:23:31 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D197A240028 for ; Tue, 23 Jul 2024 12:23:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1721730207; bh=YTvIqVPngl3q6DmaTHn8QL2lCIkXhLFiYB5R4WlaUJI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=TFbMIj9898RuwxOQ8k6D5ltm2WVKdc321XL7k1ZF3eiWKqeUYUVc3fbESdGaE9BF7 GdajAc4cCS2qbB9KWf26mQuCC2um5ABAFH/JH3wOnxX7v/U/9ULGgRIhH3D1nW2HxP 2329juoACYigSJiQFvtBtKBFyWx/VllpN2eruLlCGtgjFQmG6Y6qIXWIPou/+N1dyv AE8bCovi8GyF2/LuU5/Rh2VQbaIHhdxDZkYxfMo/zR/DICLy7YlVTvwZCchRqKG8q0 ZsAv2GqYaQ31E75UDx6+rqcplKFq8JSYteHqFWHta9uGwczOQEQyKjxexv1/UvppYO h5DxM6RrhDDPA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WStXH1rCjz9rxF; Tue, 23 Jul 2024 12:23:27 +0200 (CEST) From: Ihor Radchenko To: Orm Finnendahl Cc: emacs-orgmode@gnu.org Subject: Re: multipage html output In-Reply-To: References: <87y16bzzxl.fsf@localhost> <87o777zxkv.fsf@localhost> <87r0c2781h.fsf@localhost> <87r0c05com.fsf@localhost> <87wmlp38gr.fsf@localhost> Date: Tue, 23 Jul 2024 10:24:54 +0000 Message-ID: <874j8gz9qh.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: D357132C74 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -8.14 X-Spam-Score: -8.14 X-TUID: MWR+x1dK0WAE Orm Finnendahl writes: > I managed to get the proposal for the multipage output done. Please > review it and let me know what you think/would prefer to change. I'm > pretty open about it. > > You can find it here: > > https://github.com/ormf/ox-html-multipage > > The code is intended to replace ox.el and ox-html.el. The repository > contains a pretty exhaustive CHANGELOG.txt to show what I did. Thanks! I will first focus on reviewing changes to ox.el. > ox.el > > - added `org-export-collect-tree-info', and And it is not used anywhere... What is the purpose? > org-export-transcode-headline, extracted from `org-export-as' How does it have anything to do with "headline"? Maybe `org-export-transcode-page'? > - added :multipage case to `org-export-as', calling :process-multipage > callback submitted in info. In the multipage case, org-export-as > returns nil relying on :process-multipage to do the exporting, while > in the single page case it returns the transcoded string to the > caller from the backend. Does it mean that you do not want page splitting to be controlled globally, in ox.el, as we discussed? > - changed `org-export-collect-footnote-definitions' to get its > numbering using `org-export-get-footnote-number' rather than always > counting from 1 as before. This should always work for single-page > and multipage export. This looks reasonable. Maybe even as a separate patch we can merge earlier. > - changed that `org-export-numbered-headline-p' always returns t for > headlines in the multipage case to ensure headline numbering is > collected. > NOTE: The single-page case will be handled like before, but it might > be a better idea to change the behaviour and do it the same way as > in the multipage case: Always collect the headline-numbering and > only decide at the transcoding stage whether the headline should be > numbered in the output. Why? What if one wants headlines to be not numbered? > If the code gets reviewed and accepted I have some questions regarding > final submittal: > > 1. How do I provide the code? Is there a mechanism like issuing a > merge-request or how is it normally done? https://orgmode.org/worg/org-contribute.html#orge044121 You need to clone Org mode repository and modify it on a public branch. Then, just share it. Also, please make sure that you track the latest main branch. Your version of ox.el already diverged from the latest main. > 2. How do I add documentation to the org manual? Edit doc/org-manual.org in the Org repository. > 3. Should there be test functions for the code added and are there > recommendations how to do that? Yes, ideally. See testing/README, testing/lisp/test-ox.el, and testing/lisp/text-ox-html.el files in the Org repo. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at