emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Lin Jian <me@linj.tech>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org,  Morgan Willcock <morgan@ice9.digital>
Subject: Re: [BUG] What about excluding .dir-locals.el from GNU ELPA tarball?
Date: Mon, 16 Sep 2024 08:58:11 +0800	[thread overview]
Message-ID: <874j6gwh24.fsf@linj.tech> (raw)
In-Reply-To: <87bk0p72bi.fsf@localhost> (Ihor Radchenko's message of "Sun, 15 Sep 2024 08:23:29 +0000")

Ihor Radchenko <yantar92@posteo.net> writes:

> Having dir locals file in the tarball can be useful for the users who
> wish to edit Org mode's source code. We set a number of editing defaults
> there that are employed across Org codebase. These defaults make our
> life easier when users create patches by directly modifying Org mode code
> they got via ELPA.

I thought including .dir-locals.el may be a mistake because there are
only 4 packages (auctex, el-get, helm and org) among all packages in
GNU(-devel) ELPA and MELPA generating native compilation error about
.dir-locals.el in NixOS.

Now I know that including .dir-locals.el in org is not a mistake.
Instead, it is intended.  I will change our code in NixOS to not compile
.dir-locals.el.

The no-byte-compile cookie Morgan mentions is very interesting.  There
may be more packages including a .dir-locals.el file in their release
tarballs but not generating error in NixOS because their .dir-locals.el
has this cookie set.  add-dir-local-variable adds this cookie only since
Emacs 29[1] so older .dir-locals.el does not have this cookie.  I think
adding it to .dir-locals.el of org is a good idea.

[1]: 6539eb05889c783d782f114d9c072208d3080561


      parent reply	other threads:[~2024-09-16  0:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12 23:07 [BUG] What about excluding .dir-locals.el from GNU ELPA tarball? Lin Jian
2024-09-15  8:23 ` Ihor Radchenko
2024-09-15 16:58   ` Morgan Willcock
2024-09-16 19:22     ` Ihor Radchenko
2024-09-17 18:13       ` Morgan Willcock
2024-09-22  8:14         ` Ihor Radchenko
2024-09-16  0:58   ` Lin Jian [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874j6gwh24.fsf@linj.tech \
    --to=me@linj.tech \
    --cc=emacs-orgmode@gnu.org \
    --cc=morgan@ice9.digital \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).