[BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[Michael Heerdegen]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Hi,

especially after displaying the agenda when it didn't exist before, when
I display it (`org-agenda'), switch to it and then move point to the end
of the agenda buffer, and hit f (`org-agenda-later'), I see an purely
void window.  I don't think I messed with agenda displaying, so others
may be able to reproduce this issue.

Hitting C-g suddenly shows everything as expected - do I just need a
redisplay?  Yip, this fixes the issue for me:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-org-org-agenda.el-org-agenda-later-redisplay.patch --]
[-- Type: text/x-diff, Size: 923 bytes --]

From 3e706fef270cdac18d543e8814f76cfedac34916 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Sun, 5 Jan 2025 01:21:43 +0100
Subject: [PATCH] * lisp/org/org-agenda.el (org-agenda-later): redisplay

Without redisplay sometimes only a void looking window is displayed.
---
 lisp/org/org-agenda.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el
index 87eda4700b7..14201d2f592 100644
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -8774,7 +8774,8 @@ org-agenda-later
 	   (list (car args) sd span)))
       (org-agenda-redo)
       (org-agenda-find-same-or-today-or-agenda cnt))
-    (set-window-start nil wstart)))
+    (set-window-start nil wstart)
+    (redisplay)))

 (defun org-agenda-earlier (arg)
   "Go backward in time by the current span in the agenda buffer.
--
2.39.5


[-- Attachment #3: Type: text/plain, Size: 451 bytes --]


Hope it's the right thing to do.  Haven't looked whether the same might
be appropriate somewhere else.

TIA,

Michael.



Emacs  : GNU Emacs 31.0.50 (build 22, x86_64-pc-linux-gnu, cairo version 1.16.0)
 of 2025-01-04
Package: Org mode version 9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)

current state:
==============

Sorry, I removed this stuff, it contained too many private information.
Ask me if you want anything.  Thx.

Re: [BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[Ihor Radchenko]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> especially after displaying the agenda when it didn't exist before, when
> I display it (`org-agenda'), switch to it and then move point to the end
> of the agenda buffer, and hit f (`org-agenda-later'), I see an purely
> void window.  I don't think I messed with agenda displaying, so others
> may be able to reproduce this issue.

I am unable to reproduce.
May you please post detailed steps to recreate the issue starting from
emacs -Q? See https://orgmode.org/manual/Feedback.html#Feedback

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[Michael Heerdegen]

Ihor Radchenko <yantar92@posteo.net> writes:

> I am unable to reproduce.
> May you please post detailed steps to recreate the issue starting from
> emacs -Q? See https://orgmode.org/manual/Feedback.html#Feedback

I really just hit C-c a a M-> f as I said.  C-c a is `org-agenda',
the following "a" means "current week or day" as usual.

I have a guess what the problem is.  When you look at the implementation
of `org-agenda-later': at the end we are setting window-start to the
former value of (window-start), which we remembered.

In my case the current day (aka "today") contains much more entries than
any other day.  When I hit f with point at point-max of the current wekk
agenda, the next, shorter week agenda view will be displayed with
window-start forced to position larger than the new `point-max'.

Are you maybe able to provoke a similar situation?


Thx,

Michael.

Re: [BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[Ihor Radchenko]

Michael Heerdegen <michael_heerdegen@web.de> writes:

>> May you please post detailed steps to recreate the issue starting from
>> emacs -Q? See https://orgmode.org/manual/Feedback.html#Feedback
>
> I really just hit C-c a a M-> f as I said.  C-c a is `org-agenda',
> the following "a" means "current week or day" as usual.

That's what I tried myself.
I do not see any problem.
Please, do try to follow
https://orgmode.org/manual/Feedback.html#Feedback and provide detailed
steps showing how to reproduce the problem you are seeing without your
personal config.

> I have a guess what the problem is. ...

First, we need to establish whether the problem is with Org mode itself
or it is a combination of your config and Org mode.

For now, I simply do not know what is that problem you are
experiencing. Because I cannot see it locally on my side.

-- 
Ihor Radchenko // yantar92,
Org mode maintainer,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: [BUG] org-agenda-later sometimes creates a void display [9.7.11 (release_9.7.11 @ /usr/local/share/emacs/31.0.50/lisp/org/)]

[Michael Heerdegen]

Ihor Radchenko <yantar92@posteo.net> writes:

> That's what I tried myself.
> I do not see any problem.
> Please, do try to follow
> https://orgmode.org/manual/Feedback.html#Feedback and provide detailed
> steps showing how to reproduce the problem you are seeing without your
> personal config.

This will be a lot of work.  I really hope we can avoid it.

> > I have a guess what the problem is. ...
>
> First, we need to establish whether the problem is with Org mode
> itself or it is a combination of your config and Org mode.
>
> For now, I simply do not know what is that problem you are
> experiencing. Because I cannot see it locally on my side.

What I am seeing is what one sees for any window showing a sufficiently
large buffer after evaluating something like

  (setf (window-start) (+ 10 (point-max)))

and I have clearly shown that exactly that is what the code potentially
does.  I really don't want to spend half an hour to create a recipe
until you at least think about what I said.  I'm a big fan of recipes,
really, but in this case I would have to prepare a complete fake org
file with dozens of fake entries corresponding to suitable finely
composed dates ... this will take unnecessarily long, can't you please
just think about what I said?  Five minutes?  Please.

Does restoring the result of (window-start) from the old agenda view, as
a plain number(!), always give good results in your case?  What happens
for you in the scenario I described, when (window-start) of the previous
view is larger than (point-max) of the new view?  Emacs can't do
anything but to show nothing when the end of the buffer lies "before"
window-start.  No?


Michael.