(require 'htmlize) in org-exp should have NOERROR set

(require 'htmlize) in org-exp should have NOERROR set

[Daniel Clemente]

  With org-mode 6.12a from Emacs 23 of 15-11-2008, I get the error
(file-error "Cannot open load file" "htmlize")
  when exporting to HTML this file:

----
#+BEGIN_SRC emacs-lisp
; beeeeep
(beep)
#+END_SRC
----

  The problem seems to be in org-export-format-source-code (org-exp.el):

      ;; We are exporting to HTML
      (condition-case nil (require 'htmlize) (nil t))

  That should be just (require 'htmlize nil t)
  I have also seen the idiom (condition-case nil (require 'htmlize) (error t)), but I think (require 'htmlize nil t) is cleaner because it doesn't throw errors.



-- Daniel

Re: (require 'htmlize) in org-exp should have NOERROR set

[Carsten Dominik]

Fixed, thanks.

- Carsten

On Nov 17, 2008, at 1:25 AM, Daniel Clemente wrote:

>
>  With org-mode 6.12a from Emacs 23 of 15-11-2008, I get the error
> (file-error "Cannot open load file" "htmlize")
>  when exporting to HTML this file:
>
> ----
> #+BEGIN_SRC emacs-lisp
> ; beeeeep
> (beep)
> #+END_SRC
> ----
>
>  The problem seems to be in org-export-format-source-code (org- 
> exp.el):
>
>      ;; We are exporting to HTML
>      (condition-case nil (require 'htmlize) (nil t))
>
>  That should be just (require 'htmlize nil t)
>  I have also seen the idiom (condition-case nil (require 'htmlize)  
> (error t)), but I think (require 'htmlize nil t) is cleaner because  
> it doesn't throw errors.
>
>
>
> -- Daniel
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: (require 'htmlize) in org-exp should have NOERROR set

[Paul R]

Hi,

Carsten> Fixed, thanks. - Carsten

So you have a working version of htmlize for emacs 23 ? The one on
emacswiki is broken with emacs 23 AFAICT.

regards,

-- 
  Paul

Re: (require 'htmlize) in org-exp should have NOERROR set

[Carsten Dominik]

On Nov 17, 2008, at 9:46 AM, Paul R wrote:

> Hi,
>
> Carsten> Fixed, thanks. - Carsten
>
> So you have a working version of htmlize for emacs 23 ? The one on
> emacswiki is broken with emacs 23 AFAICT.

This works for me:

--- htmlize.el.orig     2008-10-20 18:59:21.000000000 +0200
+++ htmlize.el  2008-10-20 18:59:50.000000000 +0200
@@ -867,7 +867,7 @@
    (let ((size-list
          (loop
           for f = face then (face-attribute f :inherit)
-         until (eq f 'unspecified)
+         until (or (not f) (eq f 'unspecified))
           for h = (face-attribute f :height)
           collect (if (eq h 'unspecified) nil h))))
      (reduce 'htmlize-merge-size (cons nil size-list))))

Re: (require 'htmlize) in org-exp should have NOERROR set

[Paul R]

Carsten> This works for me:

Fine so I'm dropping it on emacswiki. Thanks

-- 
  Paul