Re: [babel] [PATCH]

["Eric Schulte" <schulte.eric@gmail.com>]

Martyn Jago <martyn.jago@btinternet.com> writes:

> "Eric Schulte" <schulte.eric@gmail.com> writes:
>
> Hi Eric
>
>> Hi Martyn,
>>
>> Thanks for this patch and for the very nice test file, I've just applied
>> it along with a related patch in org-exp-blocks.el.
>>
>> Even with the patch applied I am still seeing undesirable behavior when
>> exporting the test file.  I believe this is due to upstream processing
>> of the blocks by the rest of org-mode, as the buffer *after* org-mode
>> processing looks like this [1]
>>
>> Thanks -- Eric
>>
>
> Thanks. That works great. One thing - I'm not seeing any undesirable
> behaviour that you mentioned - am I missing something?
>

I don't have time to test this out again right now, but if you see no
smoke, I'm happy to call no fire. :)

>
>>   git format-patch -o ~/Desktop/ HEAD~1
>
> Thanks for the tip - also, apologies for the 'too short' title (hope I
> didn't start anything ;) - I'm still getting used to gnus!
>
> One other thing, I've just been trying to get the tests running, and
> most of them are, but the noweb test is failing and I don't understand
> why. Has the noweb argument changed in any way...
>
> This doesn't expand on export to html and therefore fails the tests...
>

I don't believe that there have been any recent changes to the noweb
syntax, and the example below should indeed expand---and does for me
when interactively evaluated.  I'm not sure what needs to be changed for
the test to pass...

Also, I'm really pleased that you are looking into the test suite.  I do
believe that a well maintained test suite would be a huge boon, both for
Babel and for Org-mode at large, however, recently I have only had
enough time to respond to issues raised on the mailing list, and haven't
had the time needed to maintain the test suite---I know, I should be
responding to mailing list issues by writing tests for all of the new
development, but it hasn't yet integrated into my work flow.

Best -- Eric

>
>
> #+source: noweb-example
> #+begin_src emacs-lisp
>   (message "expanded")
> #+end_src
>
> #+begin_src emacs-lisp :noweb yes
>   ;; noweb-yes-start
>   <<noweb-example>>
>   ;; noweb-yes-end
> #+end_src
>
>
> Regards
>
> Martyn
>
>>
>> will output a patch file to your desktop holding your last committed
>> change.  This would allow me to more easily apply your patches, and will
>> ensure that you get authorship credit in the git logs.
>>
>> Martyn Jago <martyn.jago@btinternet.com> writes:
>>
>>> Hi Babel
>
> [...]
>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Please use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>> Footnotes: 
>> [1]  buffer *after* org-mode processing
>> ,----
>> | ** new block regexp tests
>> | *** Block 1 (Exports OK)
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | Block 1
>> | #+END_SRC
>> | 
>> | *** Block 2 (Exports OK - double blank line no white-space in Block)
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | 
>> | 
>> | #+END_SRC
>> | 
>> | *** Block 3 (Fails - single blank line no white-space in Block)
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | 
>> | #+END_SRC
>> | 
>> | *** Block 4 (Gets consumed by previous Block)
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | Block 4
>> | #+END_SRC
>> | 
>> | *** Block 5 (Fails - no lines in Block)
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | #+END_SRC
>> | 
>> | *** Block 6 (Gets consumed by previous Block
>> | 
>> | #+BEGIN_SRC sh :tangle test-out
>> | Block 6
>> | #+END_SRC
>> `----
>
>
>
> ---
> Org-mode version 7.4 (release_7.4.529.gb23d)
> GNU Emacs 24.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.0)
>  of 2011-02-25