From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Eckl Subject: Encoding Problem in export? Date: Wed, 24 Jul 2013 01:17:09 +0200 Message-ID: <87bo5s27ey.fsf@sachwertpartner.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1lpU-0000AD-Dl for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:17:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1lpT-0002u4-1Q for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:17:16 -0400 Received: from web22.dogado.de ([93.90.176.110]:50654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1lpS-0002tZ-BE for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:17:14 -0400 Received: from relinux (mnch-5d86717b.pool.mediaWays.net [93.134.113.123]) by web22.dogado.de (Postfix) with ESMTP id 962065620F03 for ; Wed, 24 Jul 2013 01:13:36 +0200 (CEST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org At least since release_8.0.6-478-g9ee8e2 (encoding utf-8) If i'm using a link which contains the character "=" the character in the target is replaced with "%3D", at least for export to html and latex. [[http://example.de/?idprop=222][http://example.de/picture.jpg]] -> ---------------------------------- #+BEGIN_LaTeX \begin{window}[0,r,\href{http://example.de/?idprop=222}{\includegraphics{picture}},{}] #+END_LaTeX -> \begin{window}[0,r,\href{http://example.de/?idprop%3D222}{\includegraphics{picture}},{}] With an very old version of orgmode 7.93 this was for a while standard for the latex exporter, not for html. Cu, Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 01:35:18 +0200 Message-ID: <877ggg7suh.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1m6n-0002J3-Bb for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:35:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1m6k-0000Nq-2R for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:35:09 -0400 Received: from mail-we0-x233.google.com ([2a00:1450:400c:c03::233]:38462) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1m6j-0000MK-Sw for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 19:35:05 -0400 Received: by mail-we0-f179.google.com with SMTP id t57so2922857wes.24 for ; Tue, 23 Jul 2013 16:35:04 -0700 (PDT) In-Reply-To: <87bo5s27ey.fsf@sachwertpartner.de> (Robert Eckl's message of "Wed, 24 Jul 2013 01:17:09 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Robert Eckl Cc: emacs-orgmode@gnu.org Hello, Robert Eckl writes: > At least since release_8.0.6-478-g9ee8e2 This release number is suspicious. Latest is release_8.0.6-353-g2b5670. You're 125 commits ahead of us. > (encoding utf-8) > > If i'm using a link which contains the character "=" the character in the > target is replaced with "%3D", at least for export to html and latex. I cannot reproduce it. Could you upgrade and test again? Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Eckl Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 03:50:44 +0200 Message-ID: <51EF32F4.9030309@gmx.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> Reply-To: eckl.r@gmx.de Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1oE7-0001Wp-Uz for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 21:50:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1oE7-0001R3-6S for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 21:50:51 -0400 Received: from mout.gmx.net ([212.227.15.15]:65074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1oE6-0001Qz-U5 for emacs-orgmode@gnu.org; Tue, 23 Jul 2013 21:50:51 -0400 Received: from [192.168.178.32] ([93.134.100.182]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MfEsY-1Uluxn2l2o-00On9j for ; Wed, 24 Jul 2013 03:50:49 +0200 In-Reply-To: <877ggg7suh.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Hello, Am 24.07.2013 01:35, schrieb Nicolas Goaziou: > Hello, > > Robert Eckl writes: > >> At least since release_8.0.6-478-g9ee8e2 > This release number is suspicious. Latest is release_8.0.6-353-g2b5670. > You're 125 commits ahead of us. > >> (encoding utf-8) >> >> If i'm using a link which contains the character "=" the character in the >> target is replaced with "%3D", at least for export to html and latex. > I cannot reproduce it. Could you upgrade and test again? I did upgrade to release_8.0.6-353-g2b5670 and the issue continues. The issue seems to be introduced with Org-mode version 8.0.6 (release_8.0.6-4-g21dd83 org-element: Do not url-decode parsed links The description sounds like the issue, no? Org-mode version 8.0.6 (release_8.0.6-3-g40b44e works fine. I played a bit with the Elpa version Org-mode version 8.0.6 (8.0.6-5-gb4a8ec-elpa @ /home/re/.emacs.d/elpa/org-20130722/) but with this i wasn't able to run the exporter Wrong type argument: arrayp, odt Systems are Linux Mint Debian and MAC OS X 10.6.8 (Snow Leopard) Regards, Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 09:34:53 +0200 Message-ID: <87txjk5s2q.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1tas-0003p3-3g for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 03:34:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1tar-0008H4-3d for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 03:34:42 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:50822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1taq-0008Ft-UV for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 03:34:41 -0400 Received: by mail-wi0-f176.google.com with SMTP id ey16so3909974wid.9 for ; Wed, 24 Jul 2013 00:34:40 -0700 (PDT) In-Reply-To: <51EF32F4.9030309@gmx.de> (Robert Eckl's message of "Wed, 24 Jul 2013 03:50:44 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: eckl.r@gmx.de Cc: emacs-orgmode@gnu.org Hello, Robert Eckl writes: > The issue seems to be introduced with > Org-mode version 8.0.6 (release_8.0.6-4-g21dd83 > org-element: Do not url-decode parsed links > The description sounds like the issue, no? IIUC, this is different from your issue. You write a URL that is not encoded, and, somehow, it gets encoded in the export output. This patch is about not decoding something already encoded. My guess is that your URL is encoded in the original buffer already. Try to use M-x visible-mode to see what is the real URL. If you see "http://example.de/?idprop%3D222", it probably means that `org-link-escape' is a bit too zealous (BTW why don't this function rely on `url-encode-url'?) Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Eckl Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 10:46:50 +0200 Message-ID: <51EF947A.2080301@gmx.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> Reply-To: eckl.r@gmx.de Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1uim-0000H9-35 for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 04:46:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1uik-0001oF-O1 for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 04:46:56 -0400 Received: from mout.gmx.net ([212.227.15.18]:60856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1uik-0001mL-Ei for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 04:46:54 -0400 Received: from [192.168.178.32] ([93.134.100.182]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MAgvb-1Uq8TG1KSR-00BrSQ for ; Wed, 24 Jul 2013 10:46:53 +0200 In-Reply-To: <87txjk5s2q.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Am 24.07.2013 09:34, schrieb Nicolas Goaziou: > Hello, > > Robert Eckl writes: > >> The issue seems to be introduced with >> Org-mode version 8.0.6 (release_8.0.6-4-g21dd83 >> org-element: Do not url-decode parsed links >> The description sounds like the issue, no? > IIUC, this is different from your issue. You write a URL that is not > encoded, and, somehow, it gets encoded in the export output. This patch > is about not decoding something already encoded. You are right. > > My guess is that your URL is encoded in the original buffer already. Try > to use M-x visible-mode to see what is the real URL. If you see > "http://example.de/?idprop%3D222", it probably means that > `org-link-escape' is a bit too zealous (BTW why don't this function rely > on `url-encode-url'?) Ok, using visible-mode i see the link with %3D, i can replace it, then all works fine. If iinsert a new link from clipboard, i get %3D. Regards, Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 11:16:46 +0200 Message-ID: <87ehao5ncx.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <51EF947A.2080301@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1vBT-0000QL-El for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:16:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1vBS-0003qD-8g for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:16:35 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:42290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1vBS-0003q0-2w for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:16:34 -0400 Received: by mail-wi0-f171.google.com with SMTP id hj3so4008679wib.10 for ; Wed, 24 Jul 2013 02:16:33 -0700 (PDT) In-Reply-To: <51EF947A.2080301@gmx.de> (Robert Eckl's message of "Wed, 24 Jul 2013 10:46:50 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: eckl.r@gmx.de Cc: emacs-orgmode@gnu.org Robert Eckl writes: > Ok, using visible-mode i see the link with %3D, i can replace it, > then all works fine. If iinsert a new link from clipboard, i get %3D. Then, as I said, `org-link-escape' (called from `org-insert-link', aka C-c C-l) is buggy. I think we should replace every occurence of `org-link-escape' with `url-encode-url' and `org-link-unescape' with `url-unhex-string'. I can't see a reason to reinvent the wheel here. AFAICT, only org-mobile.el uses optional arguments from `org-link-escape'. It just begs for a new internal function in org-mobile.el. WDYT? Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 05:39:55 -0400 Message-ID: <87a9lcfg9g.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1vYQ-000492-Hj for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:40:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1vYP-0003vn-0O for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:40:18 -0400 Received: from plane.gmane.org ([80.91.229.3]:53366) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1vYO-0003vi-QU for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 05:40:16 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1V1vYK-0001WG-LF for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 11:40:12 +0200 Received: from pool-108-7-96-134.bstnma.fios.verizon.net ([108.7.96.134]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Jul 2013 11:40:12 +0200 Received: from ndokos by pool-108-7-96-134.bstnma.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 24 Jul 2013 11:40:12 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > My guess is that your URL is encoded in the original buffer already. Try > to use M-x visible-mode to see what is the real URL. If you see > "http://example.de/?idprop%3D222", it probably means that > `org-link-escape' is a bit too zealous (BTW why don't this function rely > on `url-encode-url'?) FWIW, I think this is correct: using org-insert-link runs org-link-escape with the default org-link-escape-chars which includes '='. I don't know why '=' is included, so I looked to see whether deleting it from org-link-escape-chars would cause problems. Looking at the call sites, org-link-escape is called from: o org-mobile.el but with its own set of escape chars, so that's no problem. o ob-tangle.el from org-babel-tangle-comment-links, which in turn is called (twice) from org-babel-expand-noweb-references. The default org-link-escape-chars is used, so any '=' would get escaped, but whether leaving it out would cause any problems, I don't know. o org-docview.el from org-docview-export with the default escape chars. Again, I don't know if leaving '=' out would cause any problems. o org.el from org-make-link-string (thrice) with the default escape chars and another three times from org-open-at-point, once for a "mailto" link and another two times to open an http/https/ftp/news/doi url but with a smaller set of escape chars that does not include '='. o org-make-link-string is itself called from a bunch of places: org-capture.el, org-clock.el, org.el, org-protocol.el, org-w3m.el. I didn't chase it down through these. I tried a ``git blame'' to see whether the '=' was added for some reason, but it looks as if it's been there ab initio. Maybe the thing to do is to delete '=' from org-link-escape-chars and see what problems arise. But I did find that '%' was originally in org-link-escape-chars and David Maus hardcoded it (commit 139cc1d4), so that it is *always* escaped. I assume there is a good reason for that, but if so, url-encode-url might not be enough - afaict, it leaves '%' signs alone: ,---- | (setq url "http://www.google.org/foo=bar 30%=2") | "http://www.google.org/foo=bar 30%=2" | | (org-link-escape url) | "http://www.google.org/foo%3Dbar%2030%25%3D2" | | (url-encode-url url) | "http://www.google.org/foo=bar%2030%=2" `---- -- Nick From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Eckl Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 12:27:44 +0200 Message-ID: <51EFAC20.8040101@gmx.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <51EF947A.2080301@gmx.de> <87ehao5ncx.fsf@gmail.com> Reply-To: eckl.r@gmx.de Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:44630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wIT-0006L7-58 for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 06:27:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1wIS-0003K1-5v for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 06:27:53 -0400 Received: from mout.gmx.net ([212.227.15.18]:62320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wIR-0003Jw-Sx for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 06:27:52 -0400 Received: from [192.168.178.32] ([93.134.100.182]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0M1Wcz-1U8amy0Dpx-00tTJA for ; Wed, 24 Jul 2013 12:27:51 +0200 In-Reply-To: <87ehao5ncx.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: emacs-orgmode@gnu.org Am 24.07.2013 11:16, schrieb Nicolas Goaziou: > Robert Eckl writes: > >> Ok, using visible-mode i see the link with %3D, i can replace it, >> then all works fine. If iinsert a new link from clipboard, i get %3D. > Then, as I said, `org-link-escape' (called from `org-insert-link', aka > C-c C-l) is buggy. > > I think we should replace every occurence of `org-link-escape' with > `url-encode-url' and `org-link-unescape' with `url-unhex-string'. > I can't see a reason to reinvent the wheel here. > > AFAICT, only org-mobile.el uses optional arguments from > `org-link-escape'. It just begs for a new internal function in > org-mobile.el. > > WDYT? It's fine for me - IME you really know what you do. Thank you very much, Robert From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Wed, 24 Jul 2013 13:09:05 +0200 Message-ID: <877ggg5i5q.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1wwA-0006Tl-AX for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 07:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V1ww9-0000Co-Eq for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 07:08:54 -0400 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:48456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V1ww9-0000Cc-8X for emacs-orgmode@gnu.org; Wed, 24 Jul 2013 07:08:53 -0400 Received: by mail-wg0-f52.google.com with SMTP id b13so265540wgh.7 for ; Wed, 24 Jul 2013 04:08:52 -0700 (PDT) In-Reply-To: <87a9lcfg9g.fsf@gmail.com> (Nick Dokos's message of "Wed, 24 Jul 2013 05:39:55 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nick Dokos Cc: David Maus , emacs-orgmode@gnu.org Hello, Nick Dokos writes: > Maybe the thing to do is to delete '=' from org-link-escape-chars and > see what problems arise. AFAICT, `url-encode-url' is subtler than that. It encodes characters whenever they are really forbidden, which is not the case of `org-link-escape'. Hence my initial question: do we need to reinvent the wheel? > But I did find that '%' was originally in org-link-escape-chars and > David Maus hardcoded it (commit 139cc1d4), so that it is *always* > escaped. I Cc David Maus in case he has time to enlighten us about his choice. > I assume there is a good reason for that, but if so, url-encode-url > might not be enough - afaict, it leaves '%' signs alone: Yes, there is a comment in url-util.el: (defconst url-host-allowed-chars ;; Allow % to avoid re-encoding %-encoded sequences. (url--allowed-chars (append '(?% ?! ?$ ?& ?' ?\( ?\) ?* ?+ ?, ?\; ?=) url-unreserved-chars)) "Allowed-character byte mask for the host segment of a URI. These characters are specified in RFC 3986, Appendix A.") Not sure how it could affect URI correctness. I trust "url-util.el" authors, though. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Encoding Problem in export? Date: Thu, 25 Jul 2013 06:05:24 +0200 Message-ID: <87y58vp9mj.wl%dmaus@ictsoc.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2Cnx-0003HV-6g for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 00:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2Cnv-0002Uo-UM for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 00:05:29 -0400 Received: from mail.xlhost.de ([213.202.242.118]:45988 helo=app1b.xlhost.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2Cnv-0002US-KK for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 00:05:27 -0400 In-Reply-To: <877ggg5i5q.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Nick Dokos , emacs-orgmode@gnu.org, David Maus Hi Nicolas, Hi Nick, At Wed, 24 Jul 2013 13:09:05 +0200, Nicolas Goaziou wrote: > > Hello, > > Nick Dokos writes: > > > Maybe the thing to do is to delete '=' from org-link-escape-chars and > > see what problems arise. > > AFAICT, `url-encode-url' is subtler than that. It encodes characters > whenever they are really forbidden, which is not the case of > `org-link-escape'. Hence my initial question: do we need to reinvent the > wheel? > > > But I did find that '%' was originally in org-link-escape-chars and > > David Maus hardcoded it (commit 139cc1d4), so that it is *always* > > escaped. > > I Cc David Maus in case he has time to enlighten us about his choice. > IIRC org-link-escape is not used to create URLs but to escape characters in a link that would otherwise conflict with Orgmode syntax (e.g. square brackets). Org applies percent escaping to a link before it is stored in the buffer and applies unescaping when it reads a link back. The percent sign is hardcoded because if org-link-escape/unescape is used in this way we must make sure that the identity of a link is preserved. If we would *not* escape the percent sign, then an original link with percent encoded characters would be read back wrongly, i.e. with the percent escaped characters unescaped. This broke links. E.g. consider a redirector link to the target url `http://target.example.org?id=33&format=html"': ,---- | http://redirect.example.org?url=http%3A%2F%2Ftarget.example.org%3Fid%3D33%26format%3Dhtml `---- If we don't escape the percent sign but apply unescaping when, say, the user opens the link we would get: ,---- | http://redirect.example.org?url=http://target.example.org?id=33&format=html `---- And voila: The `format' parameter is turned into a query parameter of redirect.example.org, not target.example.org. The specs (RFC3986) have to say the following about escaping: ,---- | Because the percent ("%") character serves as the indicator for | percent-encoded octets, it must be percent-encoded as "%25" for that | octet to be used as data within a URI. Implementations must not | percent-encode or decode the same string more than once, as decoding | an already decoded string might lead to misinterpreting a percent | data octet as the beginning of a percent-encoding, or vice versa in | the case of percent-encoding an already percent-encoded string. `---- There is, of course, the nasty thing that we don't know if the link in a buffer went through org-link-escape or not. E.g. if you paste ,---- | [[http://redirect.example.org?url=http%3A%2F%2Ftarget.example.org%3Fid%3D33%26format%3Dhtml]] `---- into the buffer you'll get a broken link because org-link-open assumes the link to be escaped by org. The bottom-line: Org creates link programmatically (org-store-link) and needs a mechanism to protected conflicting characters. It chose percent-escaping and in order to preserve the identity of a link Org has to escape the escape-character. Hope that helps! Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Thu, 25 Jul 2013 23:46:34 +0200 Message-ID: <87li4u48jp.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2TMf-0000UW-1P for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 17:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2TMd-00021J-Rk for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 17:46:24 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:50487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2TMd-00020B-Lp for emacs-orgmode@gnu.org; Thu, 25 Jul 2013 17:46:23 -0400 Received: by mail-we0-f176.google.com with SMTP id q56so1177237wes.35 for ; Thu, 25 Jul 2013 14:46:22 -0700 (PDT) In-Reply-To: <87y58vp9mj.wl%dmaus@ictsoc.de> (David Maus's message of "Thu, 25 Jul 2013 06:05:24 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: Nick Dokos , emacs-orgmode@gnu.org Hello, David Maus writes: > IIRC org-link-escape is not used to create URLs but to escape > characters in a link that would otherwise conflict with Orgmode syntax > (e.g. square brackets). > Org applies percent escaping to a link before > it is stored in the buffer and applies unescaping when it reads a link > back. > > The percent sign is hardcoded because if org-link-escape/unescape is > used in this way we must make sure that the identity of a link is > preserved. If we would *not* escape the percent sign, then an original > link with percent encoded characters would be read back wrongly, > i.e. with the percent escaped characters unescaped. [...] > There is, of course, the nasty thing that we don't know if the link in > a buffer went through org-link-escape or not. E.g. if you paste > > ,---- > | [[http://redirect.example.org?url=http%3A%2F%2Ftarget.example.org%3Fid%3D33%26format%3Dhtml]] > `---- > > into the buffer you'll get a broken link because org-link-open assumes > the link to be escaped by org. > > The bottom-line: Org creates link programmatically (org-store-link) > and needs a mechanism to protected conflicting characters. It chose > percent-escaping and in order to preserve the identity of a link Org > has to escape the escape-character. > > Hope that helps! It does. I think we are hunting two hares and that's why we are failing so far. There are two URI transformations involved. One is mandatory (escape square brackets in URI), and the other one is optional (normalize URI for external processes consumption). The former must be bi-directional, as escaping brackets must be transparent to the user (e.g., when editing a link with `org-insert-link'). The latter needn't and can happen on the fly, just before the URI is sent to whatever needs it (e.g., a browser). Therefore, I suggest to use three functions: - `org-link-escape will first %-escape "%" characters, and then "[" and "]" characters. `org-link-unescape' will reverse the operation. These function cannot break a link, encoded or not. They are applied when a link is created programmatically and read back for user editing. - `org-link-encode'[1] will %-escape every forbidden character in the URI. It doesn't need any "reverse" function. It will be called when opening a link, or parsing it. I think it shouldn't escape "%" characters, though, so that it can be applied on both encoded and plain strings. Since it isn't perfect (it doesn't parse URI), it should also be very conservative (i.e. allow more characters such as "=" or "&") and not get in the way. WDYT? Regards, [1] `url-encode-url' was introduced in Emacs 24.3. It is too young to be used mainstream, even though it does a better job than `org-link-escape'. We will benefit from it when Emacs 25 is out (i.e. when Emacs 23 support is dropped). -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Encoding Problem in export? Date: Fri, 26 Jul 2013 06:03:41 +0200 Message-ID: <87r4emdl2a.wl%dmaus@ictsoc.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2ZFp-0001OG-T2 for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 00:03:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2ZFo-0002RL-LU for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 00:03:45 -0400 Received: from mail.xlhost.de ([213.202.242.118]:37259 helo=app1b.xlhost.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2ZFo-0002RH-CL for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 00:03:44 -0400 In-Reply-To: <87li4u48jp.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos At Thu, 25 Jul 2013 23:46:34 +0200, Nicolas Goaziou wrote: > > Hello, > > David Maus writes: > > > > > The bottom-line: Org creates link programmatically (org-store-link) > > and needs a mechanism to protected conflicting characters. It chose > > percent-escaping and in order to preserve the identity of a link Org > > has to escape the escape-character. > > > > Hope that helps! > > It does. > > I think we are hunting two hares and that's why we are failing so far. > > > There are two URI transformations involved. One is mandatory (escape > square brackets in URI), and the other one is optional (normalize URI > for external processes consumption). The former must be bi-directional, > as escaping brackets must be transparent to the user (e.g., when editing > a link with `org-insert-link'). The latter needn't and can happen on the > fly, just before the URI is sent to whatever needs it (e.g., a browser). > > Therefore, I suggest to use three functions: > > - `org-link-escape will first %-escape "%" characters, and then "[" > and "]" characters. `org-link-unescape' will reverse the operation. > > These function cannot break a link, encoded or not. They are applied > when a link is created programmatically and read back for user > editing. It's not just square brackets, but also non-ascii characters. Consider a link that contains UTF-8 encoded characters and is inserted into a Org buffer encoded in ISO-8859-1. Oh, and: ASCII controll characters. A link description with newlines. Obviously changing the algorithm of org-link-escape/unescape also creates a BC-issue. > > - `org-link-encode'[1] will %-escape every forbidden character in the > URI. It doesn't need any "reverse" function. It will be called when > opening a link, or parsing it. > > I think it shouldn't escape "%" characters, though, so that it can > be applied on both encoded and plain strings. Since it isn't perfect > (it doesn't parse URI), it should also be very conservative (i.e. > allow more characters such as "=" or "&") and not get in the way. You would have to select the list of forbidden characters based on the link protocol. The assumption underlying the current implementation is to delegate dealing with forbidden characters to the consuming application. Thus I would limit this to known URI protocols, i.e. http: and https:. Best, -- David > > WDYT? > > > Regards, > > [1] `url-encode-url' was introduced in Emacs 24.3. It is too young to be > used mainstream, even though it does a better job than > `org-link-escape'. We will benefit from it when Emacs 25 is out (i.e. > when Emacs 23 support is dropped). > > -- > Nicolas Goaziou -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Fri, 26 Jul 2013 12:20:37 +0200 Message-ID: <87d2q54o7e.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2f8M-0006VS-LK for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 06:20:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2f8L-000504-0T for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 06:20:26 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:62356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2f8K-0004zz-Pr for emacs-orgmode@gnu.org; Fri, 26 Jul 2013 06:20:24 -0400 Received: by mail-wg0-f48.google.com with SMTP id f12so2028196wgh.15 for ; Fri, 26 Jul 2013 03:20:24 -0700 (PDT) In-Reply-To: <87r4emdl2a.wl%dmaus@ictsoc.de> (David Maus's message of "Fri, 26 Jul 2013 06:03:41 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: Nick Dokos , emacs-orgmode@gnu.org David Maus writes: Thanks for your answer. It seems I got confused with the current state of URI-encoding. Please scratch my previous suggestion and let's start over. > The assumption underlying the current implementation is > to delegate dealing with forbidden characters to the consuming > application. I agree with this assumption, even though I think some URI-fixing (=C3=A0 la `url-encode-url') would be nice too. But that's not the topic here. Also, the current implementation doesn't totally follow this assumption (e.g. `org-link-escape-chars-browser'). Alas, there is a serious flaw in the current implementation. As you said: > There is, of course, the nasty thing that we don't know if the link in > a buffer went through org-link-escape or not. E.g. if you paste > > ,---- > | [[http://redirect.example.org?url=3Dhttp%3A%2F%2Ftarget.example.org%3Fi= d%3D33%26format%3Dhtml]] > `---- > > into the buffer you'll get a broken link because org-link-open assumes > the link to be escaped by org. There is, indeed, no easy way to know if a link went through `org-link-escape', so we cannot unescape it properly in every situation. We could use text properties on escaped links, but that seems awkward. I think there is a simpler solution: we never "unescape" links, which means that escaping must be at its minimum. For example, we could only replace "[" and "]" with, respectively, "%5B" and "%5D" and newlines with spaces. It doesn't cripple link's readability very muc=C4=A5, and is safe as "[", "]" and "\n" are always forbidden in URI anyway. Replacing non-ascii characters would make the link unreadable to a human. Also, we don't prevent encoding mismatch (e.g., from UTF-8 to ISO-8859-1) when yanking regular text in an Org buffer, so there's no particular reason to do it for links. This operation is clearly idempotent. When sending the URL to the consuming, there will be problems, according to the assumption at the beginning of this message. But that is to be expected. Regards, --=20 Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Encoding Problem in export? Date: Sat, 27 Jul 2013 09:23:20 +0200 Message-ID: <87k3kc1n6f.wl%dmaus@ictsoc.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2yqa-00060G-KN for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 03:23:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2yqZ-0002jo-BM for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 03:23:24 -0400 Received: from mail.xlhost.de ([213.202.242.118]:38127 helo=app1b.xlhost.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2yqZ-0002jV-1Y for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 03:23:23 -0400 In-Reply-To: <87d2q54o7e.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos At Fri, 26 Jul 2013 12:20:37 +0200, Nicolas Goaziou wrote: >=20 > David Maus writes: >=20 > Thanks for your answer. It seems I got confused with the current state > of URI-encoding. Please scratch my previous suggestion and let's start > over. The more I think about it the more I grow certain that it is NOT about URI encoding but protecting a string. Unless we parse the URI and know the protocol we cannot tell if square brackets are allowed or not. >=20 > Alas, there is a serious flaw in the current implementation. As you > said: >=20 > > There is, of course, the nasty thing that we don't know if the link in > > a buffer went through org-link-escape or not. E.g. if you paste > > > > ,---- > > | [[http://redirect.example.org?url=3Dhttp%3A%2F%2Ftarget.example.org%3= Fid%3D33%26format%3Dhtml]] > > `---- > > > > into the buffer you'll get a broken link because org-link-open assumes > > the link to be escaped by org. >=20 > There is, indeed, no easy way to know if a link went through > `org-link-escape', so we cannot unescape it properly in every situation. > We could use text properties on escaped links, but that seems awkward. >=20 > I think there is a simpler solution: we never "unescape" links, > which means that escaping must be at its minimum. For example, we > could only replace "[" and "]" with, respectively, "%5B" and "%5D" > and newlines with spaces. It doesn't cripple link's readability very > muc=C4=A5, and is safe as "[", "]" and "\n" are always forbidden in URI > anyway. `[' and `]' are not forbidden per se, they belong to the set of reserved characters (see RFC 3986, 2.2.). "characters in the reserved set are protected from normalization and are therefore safe to be used by scheme-specific and producer-specific algorithms for delimiting data subcomponents within a URI." (RFC 3986, p. 12) Moreover they are explicitly required in the host part to denote a IPv6 address literal (RFC 3986, 3.2.2). If I am not mistaken then this is a valid http-URI with a XPointer fragment pointing to the third `p' element in a locally hosted file: http://[::1]/foo.xml#xpointer(//p[3]) ,----[ http://www.w3.org/TR/xptr-framework/#escaping | IRI references can be converted to URI references for consumption by | URI resolvers. The disallowed characters in URI references include all | non-ASCII characters, plus the excluded characters listed in Section | 2.4 of [RFC 2396], except for the number sign (#) and percent sign (%) | and the square bracket characters re-allowed in [RFC 2732].=20 `---- > When sending the URL to the consuming, there will be problems, according > to the assumption at the beginning of this message. But that is to be > expected. If we escape but don't unescape there are *other* problems: Depending on the protocol an escaped square bracket and a unescaped square bracket can have different meaning. The assumption I mentioned referes to unescaped characters. A consuming application knows the protocol and can infer the characters that need to be escaped. > Replacing non-ascii characters would make the link unreadable to a > human. Also, we don't prevent encoding mismatch (e.g., from UTF-8 to > ISO-8859-1) when yanking regular text in an Org buffer, so there's > no particular reason to do it for links. ACK. It's not about creating URIs but protecting strings, thus the rules for percent escaping don't have to be applied. Best, -- David --=20 OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Sat, 27 Jul 2013 13:09:28 +0200 Message-ID: <87iozwmf87.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32a0-0006nz-67 for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 07:22:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V32NB-0008Im-UT for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 07:09:20 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:54070) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V32NB-0008IR-Oc for emacs-orgmode@gnu.org; Sat, 27 Jul 2013 07:09:17 -0400 Received: by mail-we0-f172.google.com with SMTP id t61so2636999wes.17 for ; Sat, 27 Jul 2013 04:09:16 -0700 (PDT) In-Reply-To: <87k3kc1n6f.wl%dmaus@ictsoc.de> (David Maus's message of "Sat, 27 Jul 2013 09:23:20 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: Nick Dokos , emacs-orgmode@gnu.org David Maus writes: > The more I think about it the more I grow certain that it is NOT about > URI encoding but protecting a string. This is what I mean. > `[' and `]' are not forbidden per se, they belong to the set of > reserved characters (see RFC 3986, 2.2.). > > "characters in the reserved set are protected from normalization and > are therefore safe to be used by scheme-specific and producer-specific > algorithms for delimiting data subcomponents within a URI." > (RFC 3986, p. 12) > > Moreover they are explicitly required in the host part to denote a > IPv6 address literal (RFC 3986, 3.2.2). > > If I am not mistaken then this is a valid http-URI with a XPointer > fragment pointing to the third `p' element in a locally hosted file: > > http://[::1]/foo.xml#xpointer(//p[3]) Thanks for the info. I didn't read RFC 3986 thoroughly. > If we escape but don't unescape there are *other* problems: Depending > on the protocol an escaped square bracket and a unescaped square > bracket can have different meaning. The assumption I mentioned referes > to unescaped characters. A consuming application knows the protocol > and can infer the characters that need to be escaped. We cannot unescape if we use %-encoding, as stated before. > ACK. It's not about creating URIs but protecting strings, thus the > rules for percent escaping don't have to be applied. Indeed. Ideally, we need to encode "[" and "]" with strings that cannot ever be found in a URI. Then, it will be possible to decode them safely. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Encoding Problem in export? Date: Sun, 28 Jul 2013 13:16:35 +0200 Message-ID: <8761vv2auk.wl%dmaus@ictsoc.de> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> <87iozwmf87.fsf@gmail.com> <87bo5n84ih.fsf@gmail.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Oxu-0004tf-Um for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:16:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3Oxp-0000Go-RJ for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:16:42 -0400 Received: from mail.xlhost.de ([213.202.242.118]:39095 helo=app1b.xlhost.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3Oxp-0000Gg-LZ for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:16:37 -0400 In-Reply-To: <87bo5n84ih.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: David Maus , emacs-orgmode@gnu.org, Nicolas Goaziou , Nick Dokos At Sun, 28 Jul 2013 14:06:54 +0530, Jambunathan K wrote: > > > If Org links are escaped by Org will the URLs be functional outside of > Org? > > i.e., If I am on some machine, that has no Emacs or Org or if I am using > a version of Org that uses "new unescape" algorithm but the original > link was encoded with the "old escape" algorithm, will Copy-pasting the > link to a browser still work. I think this is a good point or rather two good points: One is BC. If we change the escaping algorithm we still have to deal with possibly tons of old-style-links in user files. The other one is that leaving the edge cases aside it is possible to just copy a link and paste it into the target application -- a percent sign signifies percent encoding and the target application knows what to do. > If Org is a MUST to unescape the link then it would be a good decision > to re-look at the link syntax so that the questions of escape and > un-escape is dealt with squarely and have no reasons to arise in future. > I'm not sure if it is worth the effort but, in theory, we could do define our own URI schema `org' that disallows square brackets. If a link is created programmatically (org-store-link et al.) we do not store the URI as-is but as an "Orgmode-Link": Escape the square brackets and prefix the link with `org:'. If we open a link we check for the `org:'-prefix, reverse the escaping and handle the link to the registered module. If the prefix is absent we skip the unescaping step. Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Sun, 28 Jul 2013 13:22:45 +0200 Message-ID: <87ehaj0vzu.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> <87iozwmf87.fsf@gmail.com> <87bo5n84ih.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3P3q-0007pj-F5 for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3P3b-0001sM-8w for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:22:50 -0400 Received: from mail-wg0-x229.google.com ([2a00:1450:400c:c00::229]:45621) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3P3b-0001sB-2F for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 07:22:35 -0400 Received: by mail-wg0-f41.google.com with SMTP id n11so1993581wgh.0 for ; Sun, 28 Jul 2013 04:22:33 -0700 (PDT) In-Reply-To: <87bo5n84ih.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 28 Jul 2013 14:06:54 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jambunathan K Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos Hello, Jambunathan K writes: > If Org links are escaped by Org will the URLs be functional outside of > Org? If there is an "unencoding" part, and if that part cannot happen for some reason, links will be unusable outside Org. That's already the case with the current encoding, which will break, for example, links already hexified if it cannot unencode them properly. > If Org is a MUST to unescape the link then it would be a good decision > to re-look at the link syntax so that the questions of escape and > un-escape is dealt with squarely and have no reasons to arise in > future. We can also avoid any encoding, and extend link syntax so it allows balanced square brackets (with a maximum depth, otherwise we cannot use a regexp for bracket links anymore). Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Re: Encoding Problem in export? Date: Sun, 28 Jul 2013 14:06:54 +0530 Message-ID: <87bo5n84ih.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> <87iozwmf87.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:32881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MRs-0006Pk-EL for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:35:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3MRj-0003Hm-PQ for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:35:28 -0400 Received: from mail-pa0-x22f.google.com ([2607:f8b0:400e:c03::22f]:60311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MRj-0003Hi-Jc for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:35:19 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so4723512pab.20 for ; Sun, 28 Jul 2013 01:35:18 -0700 (PDT) In-Reply-To: <87iozwmf87.fsf@gmail.com> (Nicolas Goaziou's message of "Sat, 27 Jul 2013 13:09:28 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos If Org links are escaped by Org will the URLs be functional outside of Org? i.e., If I am on some machine, that has no Emacs or Org or if I am using a version of Org that uses "new unescape" algorithm but the original link was encoded with the "old escape" algorithm, will Copy-pasting the link to a browser still work. If Org is a MUST to unescape the link then it would be a good decision to re-look at the link syntax so that the questions of escape and un-escape is dealt with squarely and have no reasons to arise in future. [1] IIRC, escaping doesn't happen if URL is copy-pasted but only if it is "inserted". i.e., escaping much depends on the workflow of the user and the workflow of a user could much depend on his whims and fancies and day of the week and seasons of the year. Just a cent from a Org user. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Re: Encoding Problem in export? Date: Sun, 28 Jul 2013 14:24:04 +0530 Message-ID: <877ggb83pv.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> <87iozwmf87.fsf@gmail.com> <87bo5n84ih.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MiR-0002BY-4B for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:52:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3MiI-0007yC-8m for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:52:35 -0400 Received: from mail-pd0-x22d.google.com ([2607:f8b0:400e:c02::22d]:65397) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3MiI-0007xy-2V for emacs-orgmode@gnu.org; Sun, 28 Jul 2013 04:52:26 -0400 Received: by mail-pd0-f173.google.com with SMTP id p11so246385pdj.18 for ; Sun, 28 Jul 2013 01:52:25 -0700 (PDT) In-Reply-To: <87bo5n84ih.fsf@gmail.com> (Jambunathan K.'s message of "Sun, 28 Jul 2013 14:06:54 +0530") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos I sense a design flaw. Fix it rather than "escape" it. Jambunathan K writes: > If Org links are escaped by Org will the URLs be functional outside of > Org? > > i.e., If I am on some machine, that has no Emacs or Org or if I am using > a version of Org that uses "new unescape" algorithm but the original > link was encoded with the "old escape" algorithm, will Copy-pasting the > link to a browser still work. > > If Org is a MUST to unescape the link then it would be a good decision > to re-look at the link syntax so that the questions of escape and > un-escape is dealt with squarely and have no reasons to arise in future. > > [1] IIRC, escaping doesn't happen if URL is copy-pasted but only if it > is "inserted". i.e., escaping much depends on the workflow of the user > and the workflow of a user could much depend on his whims and fancies > and day of the week and seasons of the year. > > Just a cent from a Org user. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jambunathan K Subject: Re: Encoding Problem in export? Date: Mon, 29 Jul 2013 12:29:29 +0530 Message-ID: <8738qxhmwe.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87a9lcfg9g.fsf@gmail.com> <877ggg5i5q.fsf@gmail.com> <87y58vp9mj.wl%dmaus@ictsoc.de> <87li4u48jp.fsf@gmail.com> <87r4emdl2a.wl%dmaus@ictsoc.de> <87d2q54o7e.fsf@gmail.com> <87k3kc1n6f.wl%dmaus@ictsoc.de> <87iozwmf87.fsf@gmail.com> <87bo5n84ih.fsf@gmail.com> <87ehaj0vzu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hOy-0000NO-GJ for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 02:58:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3hOp-000232-Sb for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 02:57:52 -0400 Received: from mail-pd0-x230.google.com ([2607:f8b0:400e:c02::230]:42572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hOp-00022n-LO for emacs-orgmode@gnu.org; Mon, 29 Jul 2013 02:57:43 -0400 Received: by mail-pd0-f176.google.com with SMTP id q10so1936596pdj.35 for ; Sun, 28 Jul 2013 23:57:42 -0700 (PDT) In-Reply-To: <87ehaj0vzu.fsf@gmail.com> (Nicolas Goaziou's message of "Sun, 28 Jul 2013 13:22:45 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: David Maus , emacs-orgmode@gnu.org, Nick Dokos Nicolas, David I just interjected. Nicolas Goaziou writes: > ...if that part cannot happen for some reason, links will be unusable > outside Org. Correctness should overrule compatibility. In practice, we may have to strike a balance, with more weight thrown in favor of correctness. I am stating the obvious here, but in a way that is practically useless to the discussion at hand. I trust that any solution that you come up with will be a good one. Also the timing is right. We can always say Org-8.0 makes a clear departure from earlier versions for reasons of robustness and correctness. ---------------------------------------------------------------- Speaking from gut (aka making things up) Link (un)escaping has also something to do with org-protocol and how the URL in browser's address bar is "captured", "encoded"(?) and "transferred" to the Emacs proper via the bookmarklet. So the browser (don't forget the clipboard) acts as *active* intermediaries as the URL makes it's way from the browser to the Org file either via hand or through emacsclient. To complicate the issue, browser being user facing may be expected to be very lenient with a URL or how it is "presented" to the user. ps-1: org-protocol to work on Windows is quite flaky. ps-2: There are frequent posts to Emacs mailing lists where copying from browser to a Emacs buffer will show up un-readable boxes. ---------------------------------------------------------------- Don't read further, if you are allergic to meta musings. As far as Org is concerned, backward compatibility is not a issue. The community is always being replaced *every* academic year. New scholars come and the old scholars leave. The only steady lot of the population is the college dons. They will not rely on Org *solely* for serious publishing work. They do revise their course support material - like beamer presentations etc - every term. In summary, shelf-life of an Org source file that is actually exported is unlikely to be beyond 4-5 years. The contents of such source file has less of stable parts and more of moving parts. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Encoding Problem in export? Date: Sat, 16 Nov 2013 16:16:04 +0100 Message-ID: References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=047d7b3a83d419ff8804eb4ccb09 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhhbU-0005UC-7d for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 10:16:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhhbS-0003YB-Lr for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 10:16:08 -0500 Received: from mail-lb0-x22b.google.com ([2a00:1450:4010:c04::22b]:54268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhhbS-0003Y7-7t for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 10:16:06 -0500 Received: by mail-lb0-f171.google.com with SMTP id q8so2416344lbi.16 for ; Sat, 16 Nov 2013 07:16:04 -0800 (PST) In-Reply-To: <87txjk5s2q.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org Mode --047d7b3a83d419ff8804eb4ccb09 Content-Type: text/plain; charset=ISO-8859-1 Hi Nicolas I would like to ask you to review the attached patch so I can change it when necessary before I git push it. > it probably means that `org-link-escape' is a bit too zealous (BTW > why don't this function rely on `url-encode-url'?) url-encode-url is a very good hint to solve a different issue that I try to deal with: (from http://lists.gnu.org/archive/html/emacs-orgmode/2013-10/msg00204.html) On Sat, Oct 5, 2013 at 3:04 PM, Michael Brand wrote: > [...] related change that I will suggest with an ERT in a later > patch: Just add "+" to org-link-escape-chars-browser. "+" has not been added to org-link-escape-chars-browser yet and in the meantime I realized that it should not be added in order to not break existing Org links like: [[http://lists.gnu.org/archive/cgi-bin/namazu.cgi?idxname=emacs-orgmode&query="Release+8.2"]] that work the same as [[http://lists.gnu.org/archive/cgi-bin/namazu.cgi?idxname=emacs-orgmode&query="Release 8.2"]] Better is to change the function org-link-escape-browser to use url-encode-url when available (since Emacs 24.3). With this I can write my use case to open a browser with +subject:"Release 8.2" in the query field now as an Org link written manually with %2B for the "+" at the beginning and %25 for its "%" like this [[http://lists.gnu.org/archive/cgi-bin/namazu.cgi?idxname=emacs-orgmode&query=%252Bsubject:"Release+8.2"]] or [[http://lists.gnu.org/archive/cgi-bin/namazu.cgi?idxname=emacs-orgmode&query=%252Bsubject:"Release 8.2"]] Link escaping in org-store-link and link unescaping in the first part of org-open-at-point are not changed, this is important to keep backward compatibility with old Org links. I have used this patch for several weeks on Emacs 24.3.2 without any problem. Michael --047d7b3a83d419ff8804eb4ccb09 Content-Type: text/plain; charset=US-ASCII; name="review.patch.txt" Content-Disposition: attachment; filename="review.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ho2zzkbe0 Y29tbWl0IDY4NmJkNzg4MjQzZWYzODk1MWMzYzUyOWQ0YzY3YzNhZDc2NmY0MTcKQXV0aG9yOiBN aWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWlsLmNvbT4KRGF0ZTogICBTYXQgTm92 IDE2IDE2OjEzOjU3IDIwMTMgKzAxMDAKCiAgICBIeXBlcmxpbms6IFVzZSB1cmwtZW5jb2RlLXVy bCBmb3IgYnJvd3NlLXVybAogICAgCiAgICAqIGxpc3Avb3JnLmVsIChvcmctb3Blbi1hdC1wb2lu dCk6IFdoZW4gYXZhaWxhYmxlIChFbWFjcyAyNC4zKSB1c2UKICAgIGB1cmwtZW5jb2RlLXVybCcg aW5zdGVhZCBvZiBgb3JnLWxpbmstZXNjYXBlLWJyb3dzZXInLgogICAgCiAgICAqIHRlc3Rpbmcv bGlzcC90ZXN0LW9yZy5lbAogICAgKHRlc3Qtb3JnL29yZy1saW5rLWVzY2FwZS11cmwtd2l0aC1l c2NhcGVkLWNoYXIpOiBTdWJzdGl0dXRlIHJlcGVhdGVkCiAgICBsaXRlcmFsIHN0cmluZyB3aXRo IGNvbnN0YW50LgogICAgKHRlc3Qtb3JnL29yZy1saW5rLWVzY2FwZS1jaGFycy1icm93c2VyKTog RXh0ZW5kIHRlc3QgY292ZXJhZ2Ugd2l0aAogICAgYHVybC1lbmNvZGUtdXJsJyBhbmQgd2l0aCAi cXVlcnk9Ii1zcGFjZSBhcyBwbHVzIHNpZ24gb3Igc3BhY2UuCgpkaWZmIC0tZ2l0IGEvbGlzcC9v cmcuZWwgYi9saXNwL29yZy5lbAppbmRleCBhM2MxOTU4Li5hYTkxZmZjIDEwMDY0NAotLS0gYS9s aXNwL29yZy5lbAorKysgYi9saXNwL29yZy5lbApAQCAtMTA0NjgsMTEgKzEwNDY4LDIwIEBAIGFw cGxpY2F0aW9uIHRoZSBzeXN0ZW0gdXNlcyBmb3IgdGhpcyBmaWxlIHR5cGUuIgogCSAgICAgIChh cHBseSBjbWQgKG5yZXZlcnNlIGFyZ3MxKSkpKQogCiAJICAgKChtZW1iZXIgdHlwZSAnKCJodHRw IiAiaHR0cHMiICJmdHAiICJuZXdzIikpCi0JICAgIChicm93c2UtdXJsIChjb25jYXQgdHlwZSAi OiIgKG9yZy1saW5rLWVzY2FwZS1icm93c2VyIHBhdGgpKSkpCisJICAgIDs7IHNlZSBgZXJ0LWRl ZnRlc3QnCisJICAgIDs7IGB0ZXN0LW9yZy9vcmctbGluay1lc2NhcGUtY2hhcnMtYnJvd3NlcicK KwkgICAgKGJyb3dzZS11cmwKKwkgICAgIChpZiAoZmJvdW5kcCAndXJsLWVuY29kZS11cmwpCisJ CSAodXJsLWVuY29kZS11cmwgKGNvbmNhdCB0eXBlICI6IiBwYXRoKSkKKwkgICAgICAgKG9yZy1s aW5rLWVzY2FwZS1icm93c2VyIChjb25jYXQgdHlwZSAiOiIgcGF0aCkpKSkpCiAKIAkgICAoKHN0 cmluZz0gdHlwZSAiZG9pIikKLQkgICAgKGJyb3dzZS11cmwgKGNvbmNhdCBvcmctZG9pLXNlcnZl ci11cmwKLQkJCQkob3JnLWxpbmstZXNjYXBlLWJyb3dzZXIgcGF0aCkpKSkKKwkgICAgOzsgc2Vl IGBlcnQtZGVmdGVzdCcKKwkgICAgOzsgYHRlc3Qtb3JnL29yZy1saW5rLWVzY2FwZS1jaGFycy1i cm93c2VyJworCSAgICAoYnJvd3NlLXVybAorCSAgICAgKGlmIChmYm91bmRwICd1cmwtZW5jb2Rl LXVybCkKKwkJICh1cmwtZW5jb2RlLXVybCAoY29uY2F0IG9yZy1kb2ktc2VydmVyLXVybCBwYXRo KSkKKwkgICAgICAgKG9yZy1saW5rLWVzY2FwZS1icm93c2VyIChjb25jYXQgb3JnLWRvaS1zZXJ2 ZXItdXJsIHBhdGgpKSkpKQogCiAJICAgKChtZW1iZXIgdHlwZSAnKCJtZXNzYWdlIikpCiAJICAg IChicm93c2UtdXJsIChjb25jYXQgdHlwZSAiOiIgcGF0aCkpKQpkaWZmIC0tZ2l0IGEvdGVzdGlu Zy9saXNwL3Rlc3Qtb3JnLmVsIGIvdGVzdGluZy9saXNwL3Rlc3Qtb3JnLmVsCmluZGV4IGY0Njcy ZWIuLjA4NGU5NWQgMTAwNjQ0Ci0tLSBhL3Rlc3RpbmcvbGlzcC90ZXN0LW9yZy5lbAorKysgYi90 ZXN0aW5nL2xpc3AvdGVzdC1vcmcuZWwKQEAgLTU1MiwyMSArNTUyLDUzIEBACiAoZXJ0LWRlZnRl c3QgdGVzdC1vcmcvb3JnLWxpbmstZXNjYXBlLXVybC13aXRoLWVzY2FwZWQtY2hhciAoKQogICAi RXNjYXBlIGFuZCB1bmVzY2FwZSBhIFVSTCB0aGF0IGluY2x1ZGVzIGFuIGVzY2FwZWQgY2hhci4K IGh0dHA6Ly9hcnRpY2xlLmdtYW5lLm9yZy9nbWFuZS5lbWFjcy5vcmdtb2RlLzIxNDU5LyIKLSAg KHNob3VsZAotICAgKHN0cmluZz0KLSAgICAiaHR0cDovL3NvbWUuaG9zdC5jb20vZm9ybT8maWQ9 YmxhaCUyQmJsYWgyNSIKLSAgICAob3JnLWxpbmstdW5lc2NhcGUKLSAgICAgKG9yZy1saW5rLWVz Y2FwZSAiaHR0cDovL3NvbWUuaG9zdC5jb20vZm9ybT8maWQ9YmxhaCUyQmJsYWgyNSIpKSkpKQor ICAobGV0ICgoYSAiaHR0cDovL3NvbWUuaG9zdC5jb20vZm9ybT8maWQ9YmxhaCUyQmJsYWgyNSIp KQorICAgIChzaG91bGQgKHN0cmluZz0gYSAob3JnLWxpbmstdW5lc2NhcGUgKG9yZy1saW5rLWVz Y2FwZSBhKSkpKSkpCiAKIChlcnQtZGVmdGVzdCB0ZXN0LW9yZy9vcmctbGluay1lc2NhcGUtY2hh cnMtYnJvd3NlciAoKQotICAiRXNjYXBlIGEgVVJMIHRvIHBhc3MgdG8gYGJyb3dzZS11cmwnLiIK LSAgKHNob3VsZAotICAgKHN0cmluZz0KLSAgICAoY29uY2F0ICJodHRwOi8vbGlzdHMuZ251Lm9y Zy9hcmNoaXZlL2NnaS1iaW4vbmFtYXp1LmNnaT9xdWVyeT0iCi0JICAgICIlMjJSZWxlYXNlJTIw OC4yJTIyJmlkeG5hbWU9ZW1hY3Mtb3JnbW9kZSIpCi0gICAgKG9yZy1saW5rLWVzY2FwZS1icm93 c2VyCi0gICAgIChjb25jYXQgImh0dHA6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUvY2dpLWJpbi9u YW1henUuY2dpP3F1ZXJ5PSIKLQkgICAgICJcIlJlbGVhc2UgOC4yXCImaWR4bmFtZT1lbWFjcy1v cmdtb2RlIikpKSkpCisgICJFc2NhcGUgYSBVUkwgYmVmb3JlIHBhc3NpbmcgaXQgdG8gYGJyb3dz ZS11cmwnLgorCitUaGlzIHRlc3QgaXMgdG8gZW5zdXJlIHRoYXQgYG9yZy1vcGVuLWF0LXBvaW50 JyBvbiB0aGUgT3JnIGxpbmtzCisKKyAgICBbW2h0dHA6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUv Y2dpLWJpbi9uYW1henUuY2dpP2lkeG5hbWU9ZW1hY3Mtb3JnbW9kZSZxdWVyeT0lMjUyQnN1Ympl Y3Q6XCJSZWxlYXNlKzguMlwiXV0KKyAgICBbW2h0dHA6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUv Y2dpLWJpbi9uYW1henUuY2dpP2lkeG5hbWU9ZW1hY3Mtb3JnbW9kZSZxdWVyeT0lMjUyQnN1Ympl Y3Q6XCJSZWxlYXNlIDguMlwiXV0KKword2lsbCBvcGVuIGEgYnJvd3NlciB3aXRoICtzdWJqZWN0 OlwiUmVsZWFzZSA4LjJcIiBpbiB0aGUgcXVlcnkKK2ZpZWxkLiIKKworICA7OyBFYWNoIHN0cmlu ZyBhcmd1bWVudCBwYXNzZWQgdG8gYHVybC1lbmNvZGUtdXJsJyBvcgorICA7OyBgb3JnLWxpbmst ZXNjYXBlLWJyb3dzZXInIGluIHRoZSB0ZXN0cyBiZWxvdyAob3Igd2hlbgorICA7OyBgb3JnLW9w ZW4tYXQtcG9pbnQnIGlzIHVzZWQgaW4gYW4gT3JnIGJ1ZmZlcikgbG9va3MgbGlrZSBhZnRlcgor ICA7OyB0aGUgT3JnIGxpbmsgZnJvbSB0aGUgZG9jc3RyaW5nIGhhcyBiZWVuIHVuZXNjYXBlZCBi eQorICA7OyBgb3JnLWxpbmstdW5lc2NhcGUnIGluIGBvcmctb3Blbi1hdC1wb2ludCcKKyAgKGxl dCAoKHF1ZXJ5IChjb25jYXQgImh0dHA6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUvY2dpLWJpbi9u YW1henUuY2dpPyIKKwkJICAgICAgICJpZHhuYW1lPWVtYWNzLW9yZ21vZGUmcXVlcnk9IikpCisJ KHBsdXMgICIlMkJzdWJqZWN0OlwiUmVsZWFzZSs4LjJcIiIpICAgOyAicXVlcnk9Ii1zcGFjZSBh cyBwbHVzIHNpZ24KKwkoc3BhY2UgIiUyQnN1YmplY3Q6XCJSZWxlYXNlIDguMlwiIikpICA7ICJx dWVyeT0iLXNwYWNlIGFzIHNwYWNlCisKKyAgICA7OyBUaGlzIGlzIHRoZSBiZWhhdmlvciBvZiBg b3JnLW9wZW4tYXQtcG9pbnQnIHdoZW4gdXNlZCB0b2dldGhlcgorICAgIDs7IHdpdGggYW4gRW1h Y3MgMjQuMyBvciBsYXRlciB3aGVyZSBgdXJsLWVuY29kZS11cmwnIGlzIGF2YWlsYWJsZQorICAg ICh3aGVuIChmYm91bmRwICd1cmwtZW5jb2RlLXVybCkKKyAgICAgIDs7ICJxdWVyeT0iLXNwYWNl IGFzIHBsdXMgc2lnbgorICAgICAgKHNob3VsZCAoc3RyaW5nPSAoY29uY2F0IHF1ZXJ5ICIlMkJz dWJqZWN0OiUyMlJlbGVhc2UrOC4yJTIyIikKKwkJICAgICAgICh1cmwtZW5jb2RlLXVybCAoY29u Y2F0IHF1ZXJ5IHBsdXMpKSkpCisgICAgICA7OyAicXVlcnk9Ii1zcGFjZSBhcyBzcGFjZQorICAg ICAgKHNob3VsZCAoc3RyaW5nPSAoY29uY2F0IHF1ZXJ5ICIlMkJzdWJqZWN0OiUyMlJlbGVhc2Ul MjA4LjIlMjIiKQorCQkgICAgICAgKHVybC1lbmNvZGUtdXJsIChjb25jYXQgcXVlcnkgc3BhY2Up KSkpKQorCisgICAgOzsgVGhlICUyNTJCIGJlbG93IHJldHVybmVkIGZyb20gYG9yZy1saW5rLWVz Y2FwZS1icm93c2VyJyBpcyBub3QKKyAgICA7OyBkZXNpcmVkIGFuZCBub3Qgd29ya2luZyB3aXRo IHNvbWUgYnJvd3Nlci9PUyBidXQgdGVzdGVkIGhlcmUgdG8KKyAgICA7OyBkb2N1bWVudCB3aGF0 IGhhcHBlbnMgd2hlbiB0aGUgZmFsbGJhY2sgdG8KKyAgICA7OyBgb3JnLWxpbmstZXNjYXBlLWJy b3dzZXInIGluIGBvcmctb3Blbi1hdC1wb2ludCcgaXMgaW4gdXNlLAorICAgIDs7IHdoaWNoIGlz IHRoZSBsZWdhY3kgYmVoYXZpb3Igb2YgYG9yZy1vcGVuLWF0LXBvaW50JyB3aGVuIHVzZWQKKyAg ICA7OyB0b2dldGhlciB3aXRoIGFuIEVtYWNzIGJlZm9yZSB2ZXJzaW9uIDI0LjMKKyAgICA7Owor ICAgIDs7ICJxdWVyeT0iLXNwYWNlIGFzIHBsdXMgc2lnbgorICAgIChzaG91bGQgKHN0cmluZz0g KGNvbmNhdCBxdWVyeSAiJTI1MkJzdWJqZWN0OiUyMlJlbGVhc2UrOC4yJTIyIikKKwkJICAgICAo b3JnLWxpbmstZXNjYXBlLWJyb3dzZXIgKGNvbmNhdCBxdWVyeSBwbHVzKSkpKQorICAgIDs7ICJx dWVyeT0iLXNwYWNlIGFzIHNwYWNlCisgICAgKHNob3VsZCAoc3RyaW5nPSAoY29uY2F0IHF1ZXJ5 ICIlMjUyQnN1YmplY3Q6JTIyUmVsZWFzZSUyMDguMiUyMiIpCisJCSAgICAgKG9yZy1saW5rLWVz Y2FwZS1icm93c2VyIChjb25jYXQgcXVlcnkgc3BhY2UpKSkpKSkKIAogCiAMCg== --047d7b3a83d419ff8804eb4ccb09-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Sat, 16 Nov 2013 21:43:02 +0100 Message-ID: <87y54ohycp.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhmhe-0005Td-BH for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 15:42:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhmhZ-0001Ju-0m for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 15:42:50 -0500 Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:47815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhmhY-0001Jo-Or for emacs-orgmode@gnu.org; Sat, 16 Nov 2013 15:42:44 -0500 Received: by mail-ea0-f178.google.com with SMTP id d10so1403463eaj.23 for ; Sat, 16 Nov 2013 12:42:43 -0800 (PST) In-Reply-To: (Michael Brand's message of "Sat, 16 Nov 2013 16:16:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Brand Cc: Org Mode Hello, Michael Brand writes: > I would like to ask you to review the attached patch so I can change > it when necessary before I git push it. Sure. > - (browse-url (concat type ":" (org-link-escape-browser path)))) > + ;; see `ert-deftest' > + ;; `test-org/org-link-escape-chars-browser' > + (browse-url > + (if (fboundp 'url-encode-url) > + (url-encode-url (concat type ":" path)) > + (org-link-escape-browser (concat type ":" path))))) IMO, the following is nicer: (funcall (if (fboundp 'url-encode-url) #'url-encode-url #'org-link-escape-browser) (concat type ":" path)) Also, it's better to document this in the source code rather than in the test suite. Also, you could add, as a reminder, that we can remove `org-link-escape-browser' altogether once we drop support for Emacs 23. > - (browse-url (concat org-doi-server-url > - (org-link-escape-browser path)))) > + ;; see `ert-deftest' > + ;; `test-org/org-link-escape-chars-browser' > + (browse-url > + (if (fboundp 'url-encode-url) > + (url-encode-url (concat org-doi-server-url path)) > + (org-link-escape-browser (concat org-doi-server-url path))))) Ditto. > - (should > - (string= > - "http://some.host.com/form?&id=blah%2Bblah25" > - (org-link-unescape > - (org-link-escape "http://some.host.com/form?&id=blah%2Bblah25"))))) > + (let ((a "http://some.host.com/form?&id=blah%2Bblah25")) > + (should (string= a (org-link-unescape (org-link-escape a)))))) No need to change this. Moreover, I tend to prefer `should' outside the sexp because it is easier to debug, when needed (`should' is quite opaque when stepping through the function). > + ;; This is the behavior of `org-open-at-point' when used together > + ;; with an Emacs 24.3 or later where `url-encode-url' is available > + (when (fboundp 'url-encode-url) > + ;; "query="-space as plus sign > + (should (string= (concat query "%2Bsubject:%22Release+8.2%22") > + (url-encode-url (concat query plus)))) > + ;; "query="-space as space > + (should (string= (concat query "%2Bsubject:%22Release%208.2%22") > + (url-encode-url (concat query space))))) You are testing `url-encode-url' here, not an Org function. Is it really required? Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Encoding Problem in export? Date: Sun, 17 Nov 2013 12:06:28 +0100 Message-ID: References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87y54ohycp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=089e0158b5d454aeca04eb5d6cce Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0BT-0008Np-5M for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:06:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi0BS-0003uw-4t for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:06:31 -0500 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:56637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0BR-0003uo-T2 for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:06:30 -0500 Received: by mail-lb0-f170.google.com with SMTP id w7so241118lbi.1 for ; Sun, 17 Nov 2013 03:06:28 -0800 (PST) In-Reply-To: <87y54ohycp.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org Mode --089e0158b5d454aeca04eb5d6cce Content-Type: text/plain; charset=ISO-8859-1 Hi Nicolas Thank you for reviewing. On Sat, Nov 16, 2013 at 9:43 PM, Nicolas Goaziou wrote: > You are testing `url-encode-url' here, not an Org function. Is it really > required? No, the point about documentation is now covered in org-open-at-point like all other previous changes to the ERT. Please see the attached changed local commit. Michael --089e0158b5d454aeca04eb5d6cce Content-Type: text/plain; charset=US-ASCII; name="review2.patch.txt" Content-Disposition: attachment; filename="review2.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ho46i9xw0 Y29tbWl0IDk3MWEzYTRlNDg1Yzg5N2I4YjZjMmMxYzI0NGQwMmNiOGQ5NDMxNjcKQXV0aG9yOiBN aWNoYWVsIEJyYW5kIDxtaWNoYWVsLmNoLmJyYW5kQGdtYWlsLmNvbT4KRGF0ZTogICBTdW4gTm92 IDE3IDEyOjAwOjE4IDIwMTMgKzAxMDAKCiAgICBIeXBlcmxpbms6IFVzZSB1cmwtZW5jb2RlLXVy bCBmb3IgYnJvd3NlLXVybAogICAgCiAgICAqIGxpc3Avb3JnLmVsIChvcmctb3Blbi1hdC1wb2lu dCk6IFdoZW4gYXZhaWxhYmxlIChFbWFjcyAyNC4zLjEpIHVzZQogICAgYHVybC1lbmNvZGUtdXJs JyBpbnN0ZWFkIG9mIGBvcmctbGluay1lc2NhcGUtYnJvd3NlcicuCgpkaWZmIC0tZ2l0IGEvbGlz cC9vcmcuZWwgYi9saXNwL29yZy5lbAppbmRleCBlZDM5MjhmLi41Y2ZhYTJjIDEwMDY0NAotLS0g YS9saXNwL29yZy5lbAorKysgYi9saXNwL29yZy5lbApAQCAtMTA1MjAsMTEgKzEwNTIwLDI5IEBA IGFwcGxpY2F0aW9uIHRoZSBzeXN0ZW0gdXNlcyBmb3IgdGhpcyBmaWxlIHR5cGUuIgogCSAgICAg IChhcHBseSBjbWQgKG5yZXZlcnNlIGFyZ3MxKSkpKQogCiAJICAgKChtZW1iZXIgdHlwZSAnKCJo dHRwIiAiaHR0cHMiICJmdHAiICJuZXdzIikpCi0JICAgIChicm93c2UtdXJsIChjb25jYXQgdHlw ZSAiOiIgKG9yZy1saW5rLWVzY2FwZS1icm93c2VyIHBhdGgpKSkpCisJICAgIDs7IEluIHRoZSBl eGFtcGxlIG9mIHRoZSBodHRwIE9yZyBsaW5rCisJICAgIDs7IFtbaHR0cDovL2xpc3RzLmdudS5v cmcvYXJjaGl2ZS9jZ2ktYmluL25hbWF6dS5jZ2k/aWR4bmFtZT1lbWFjcy1vcmdtb2RlJnF1ZXJ5 PSUyNTJCc3ViamVjdDoiUmVsZWFzZSs4LjIiXV0KKwkgICAgOzsgdG8gb3BlbiBhIGJyb3dzZXIg d2l0aCArc3ViamVjdDoiUmVsZWFzZSA4LjIiIGluIHRoZQorCSAgICA7OyBxdWVyeSBmaWVsZCB0 aGUgdmFyaWFibGUgYHBhdGgnIGNvbnRhaW5zCisJICAgIDs7IFsuLi5dPSUyQnN1YmplY3Q6IlJl bGVhc2UrOC4yIiwgYHVybC1lbmNvZGUtdXJsJworCSAgICA7OyBjb252ZXJ0cyBjb3JyZWN0IHRv IFsuLi5dPSUyQnN1YmplY3Q6JTIyUmVsZWFzZSs4LjIlMjIKKwkgICAgOzsgYW5kIGBvcmctbGlu ay1lc2NhcGUtYnJvd3NlcicgY29udmVydHMgd3JvbmcgdG8KKwkgICAgOzsgWy4uLl09JTI1MkJz dWJqZWN0OiUyMlJlbGVhc2UrOC4yJTIyLgorCSAgICA7OworCSAgICA7OyBgdXJsLWVuY29kZS11 cmwnIGlzIGF2YWlsYWJsZSBzaW5jZSBFbWFjcyAyNC4zLjEgYW5kCisJICAgIDs7IGBvcmctbGlu ay1lc2NhcGUtYnJvd3NlcicgY2FuIGJlIHJlbW92ZWQgYWx0b2dldGhlcgorCSAgICA7OyBvbmNl IE9yZyBkcm9wcyBzdXBwb3J0IGZvciBFbWFjcyAyNC4xIGFuZCAyNC4yLgorCSAgICAoYnJvd3Nl LXVybCAoZnVuY2FsbCAoaWYgKGZib3VuZHAgJ3VybC1lbmNvZGUtdXJsKQorCQkJCSAgICAgIyd1 cmwtZW5jb2RlLXVybAorCQkJCSAgICMnb3JnLWxpbmstZXNjYXBlLWJyb3dzZXIpCisJCQkJIChj b25jYXQgdHlwZSAiOiIgcGF0aCkpKSkKIAogCSAgICgoc3RyaW5nPSB0eXBlICJkb2kiKQotCSAg ICAoYnJvd3NlLXVybCAoY29uY2F0IG9yZy1kb2ktc2VydmVyLXVybAotCQkJCShvcmctbGluay1l c2NhcGUtYnJvd3NlciBwYXRoKSkpKQorCSAgICA7OyBTZWUgY29tbWVudHMgZm9yIHR5cGUgaHR0 cCBhYm92ZQorCSAgICAoYnJvd3NlLXVybCAoZnVuY2FsbCAoaWYgKGZib3VuZHAgJ3VybC1lbmNv ZGUtdXJsKQorCQkJCSAgICAgIyd1cmwtZW5jb2RlLXVybAorCQkJCSAgICMnb3JnLWxpbmstZXNj YXBlLWJyb3dzZXIpCisJCQkJIChjb25jYXQgb3JnLWRvaS1zZXJ2ZXItdXJsIHBhdGgpKSkpCiAK IAkgICAoKG1lbWJlciB0eXBlICcoIm1lc3NhZ2UiKSkKIAkgICAgKGJyb3dzZS11cmwgKGNvbmNh dCB0eXBlICI6IiBwYXRoKSkpCg== --089e0158b5d454aeca04eb5d6cce-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Encoding Problem in export? Date: Sun, 17 Nov 2013 12:46:22 +0100 Message-ID: <87vbzr6yk1.fsf@gmail.com> References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87y54ohycp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0ns-00074W-W4 for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:46:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi0nk-0006Vp-FL for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:46:12 -0500 Received: from mail-ea0-x22d.google.com ([2a00:1450:4013:c01::22d]:63387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0nk-0006Vi-7v for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:46:04 -0500 Received: by mail-ea0-f173.google.com with SMTP id g15so1076406eak.32 for ; Sun, 17 Nov 2013 03:46:03 -0800 (PST) In-Reply-To: (Michael Brand's message of "Sun, 17 Nov 2013 12:06:28 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Michael Brand Cc: Org Mode Hello, Michael Brand writes: > No, the point about documentation is now covered in org-open-at-point > like all other previous changes to the ERT. Please see the attached > changed local commit. It looks good to me. Thank you for the patch. Regards, -- Nicolas Goaziou From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Brand Subject: Re: Encoding Problem in export? Date: Sun, 17 Nov 2013 12:51:45 +0100 Message-ID: References: <87bo5s27ey.fsf@sachwertpartner.de> <877ggg7suh.fsf@gmail.com> <51EF32F4.9030309@gmx.de> <87txjk5s2q.fsf@gmail.com> <87y54ohycp.fsf@gmail.com> <87vbzr6yk1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0tH-0000AD-FC for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vi0tG-0008Ch-M3 for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:51:47 -0500 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]:45739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vi0tG-0008CW-DC for emacs-orgmode@gnu.org; Sun, 17 Nov 2013 06:51:46 -0500 Received: by mail-lb0-f175.google.com with SMTP id p9so3965721lbv.20 for ; Sun, 17 Nov 2013 03:51:45 -0800 (PST) In-Reply-To: <87vbzr6yk1.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Goaziou Cc: Org Mode Hi Nicolas On Sun, Nov 17, 2013 at 12:46 PM, Nicolas Goaziou wrote: > It looks good to me. Thank you, I just pushed. Michael