Bug: org-catch-invisible-edits [8.2.5h (8.2.5h-30-gdd810b-elpa @ ~/.emacs.d/elpa/org/)]

Bug: org-catch-invisible-edits [8.2.5h (8.2.5h-30-gdd810b-elpa @ ~/.emacs.d/elpa/org/)]

[Paul Stansell]

Hi,

Today I came across org-catch-invisible-edits, but I'm struggling to
get it to work.  Since I've never had it working it's possible that
I'm misunderstanding it or doing something wrong, or maybe it's
broken.

In my .emacs file I put

  (setq org-catch-invisible-edits 'show)

but both 'M-x query-replace' and 'M-x replace-string' still replace
hidden strings in folded sections of an org file.

Thanks,

Paul

current state:
==============
(setq
 org-tab-first-hook '(org-hide-block-toggle-maybe
              org-src-native-tab-command-maybe
              org-babel-hide-result-toggle-maybe
              org-babel-header-arg-expand)
 org-speed-command-hook '(org-speed-command-default-hook
              org-babel-speed-command-hook)
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-confirm-shell-link-function 'yes-or-no-p
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer
             org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook org-show-block-all
            append local]
           5]
         #[nil "\300\301\302\303\304$\207"
           [org-add-hook change-major-mode-hook
            org-babel-show-result-all append local]
           5]
         org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point
              org-babel-execute-safely-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers
          org-cycle-hide-inline-tasks org-cycle-show-empty-lines
          org-optimize-window-after-visibility-change)
 org-catch-invisible-edits 'show
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 )

Re: Bug: org-catch-invisible-edits [8.2.5h (8.2.5h-30-gdd810b-elpa @ ~/.emacs.d/elpa/org/)]

[Bastien]

Hi Paul,

Paul Stansell <paulstansell@gmail.com> writes:

> Today I came across org-catch-invisible-edits, but I'm struggling to
> get it to work.  Since I've never had it working it's possible that
> I'm misunderstanding it or doing something wrong, or maybe it's
> broken.
>
> In my .emacs file I put
>
>   (setq org-catch-invisible-edits 'show)
>
> but both 'M-x query-replace' and 'M-x replace-string' still replace
> hidden strings in folded sections of an org file.

The name of the option is a bit misleading: your setup will catch
*insertions* not editions.  To put it simply, it's only active when
inserting a character, not when using general-purpose editing commands
like replace-string.

I'm not sure it's worth using another name, though.

-- 
 Bastien

Re: Bug: org-catch-invisible-edits [8.2.5h (8.2.5h-30-gdd810b-elpa @ ~/.emacs.d/elpa/org/)]

[Paul Stansell]

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

Hi Bastien,

Thanks for that info on org-catch-invisible-edits.  It wasn't clear to me
as the documentation implies that it helps when you "inadvertently edit an
invisible part of the buffer", but it seems that the edits have to be
results of key presses (not yanks or replaces, etc).

I'm not sure how useful I would find the function.  I'd like a way to stop
any edits (including yanks etc.) on invisible parts of a buffer.

I experimented with org-catch-invisible-edits by typing and deleting
characters in folded sections of a simple org file.  It seem to work well
if the insertions or deletions occur at one hidden level down.  In this
case it opens the folded section and shows the edit after a short delay.
But if I edit or delete two hidden sections down it doesn't seem to work
properly as it only open the first hidden section and so the edit, which is
another level down, is not shown.

For example, for the org file below, editing the line "level 2" when both
"Section 1" and "Section 2" are folded (hidden) causes only "Section 1" to
be unfolded with "Section 2" still folded inside it.  Thus, the edits are
not visible.

* section 1
  level 1
** section 2
   level 2

Kind regards,

Paul



On 13 March 2014 14:24, Bastien <bzg@gnu.org> wrote:

> Hi Paul,
>
> Paul Stansell <paulstansell@gmail.com> writes:
>
> > Today I came across org-catch-invisible-edits, but I'm struggling to
> > get it to work.  Since I've never had it working it's possible that
> > I'm misunderstanding it or doing something wrong, or maybe it's
> > broken.
> >
> > In my .emacs file I put
> >
> >   (setq org-catch-invisible-edits 'show)
> >
> > but both 'M-x query-replace' and 'M-x replace-string' still replace
> > hidden strings in folded sections of an org file.
>
> The name of the option is a bit misleading: your setup will catch
> *insertions* not editions.  To put it simply, it's only active when
> inserting a character, not when using general-purpose editing commands
> like replace-string.
>
> I'm not sure it's worth using another name, though.
>
> --
>  Bastien
>

[-- Attachment #2: Type: text/html, Size: 2861 bytes --]

Re: Bug: org-catch-invisible-edits [8.2.5h (8.2.5h-30-gdd810b-elpa @ ~/.emacs.d/elpa/org/)]

[Bastien]

Hi Paul,

Paul Stansell <paulstansell@gmail.com> writes:

> For example, for the org file below, editing the line "level 2" when
> both "Section 1" and "Section 2" are folded (hidden) causes only
> "Section 1" to be unfolded with "Section 2" still folded inside it. 
> Thus, the edits are not visible.
>
> * section 1
>   level 1
> ** section 2
>    level 2

this is now fixed, thanks,

-- 
 Bastien