From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [bug] canonical context not work in 8.3
Date: Fri, 07 Aug 2015 10:45:59 +0200
Message-ID: <8737zvfpvc.fsf@nicolasgoaziou.fr>
References: <CAJcAo8tARs9wFqQaLGmNXYfmSgv6nQxeG45wzRWShjSwY1y6gw@mail.gmail.com>
	<87mvy4eywo.fsf@nicolasgoaziou.fr>
	<CAJcAo8uq89FveQsZ22CBV1QXpsNty+KWbHFgx-CYZLm1AWgR6g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZNdGM-0002cM-44
	for emacs-orgmode@gnu.org; Fri, 07 Aug 2015 04:44:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZNdGK-00044N-Vp
	for emacs-orgmode@gnu.org; Fri, 07 Aug 2015 04:44:26 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:50860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZNdGK-00043p-Ob
	for emacs-orgmode@gnu.org; Fri, 07 Aug 2015 04:44:24 -0400
In-Reply-To: <CAJcAo8uq89FveQsZ22CBV1QXpsNty+KWbHFgx-CYZLm1AWgR6g@mail.gmail.com>
	(Samuel Wales's message of "Thu, 6 Aug 2015 18:38:55 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Samuel Wales <samologist@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>

Samuel Wales <samologist@gmail.com> writes:

> thank you for fixing.
>
> canonical is always what i want, except for occur-tree.
>
> i did profiler-start then went to org file a few times to average out
> the results.  did i use the correct profiler?

You did.
>
>  command-execute                                               60148  99%
>  - call-interactively                                           60148  99%
>   - org-agenda-switch-to                                        59299  98%
>    - org-show-context                                           59299  98%
>     - org-show-set-visibility                                   59299  98%
>      - show-children                                            59170  97%
>       - outline-end-of-subtree                                  35938  59%
>          outline-next-heading                                    9399  15%
>          org-outline-level                                       4047   6%
>       - outline-map-region                                      23168  38%
>        + #<compiled 0xfc19ab>                                    9558  15%
>          outline-next-heading                                    7399  12%
>      + org-up-heading-safe                                        117   0%
>      + org-show-entry                                               4   0%
>      + org-flag-heading                                             4   0%

`show-children' is the culprit.

Could you evaluate the following function and time it again?

  (defun show-children (&optional level)
    (save-excursion
      (org-back-to-heading t)
      (let* ((current-level (funcall outline-level))
             (level (if level (+ (prefix-numeric-value level) current-level)
                      (save-excursion
                        (outline-next-heading)
                        (if (eobp) current-level (funcall outline-level))))))
        (org-map-region
         (lambda ()
           (when (<= (funcall outline-level) level)
             (outline-flag-region (if (bobp) (point) (1- (point)))
                                  (line-end-position)
                                  nil)))
         (point)
         (org-end-of-subtree t t)))))

Thank you.


Regards,