From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: Babel support for Stan
Date: Mon, 24 Aug 2015 12:40:10 -0400
Message-ID: <8737z8od1x.fsf@kyleam.com>
References: <87si794dkk.fsf@kyleam.com> <877fokbuz5.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZTunE-0005zX-76
	for emacs-orgmode@gnu.org; Mon, 24 Aug 2015 12:40:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZTunA-0001Sx-RS
	for emacs-orgmode@gnu.org; Mon, 24 Aug 2015 12:40:20 -0400
Received: from mail-qg0-f50.google.com ([209.85.192.50]:36246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZTunA-0001SZ-Oa
	for emacs-orgmode@gnu.org; Mon, 24 Aug 2015 12:40:16 -0400
Received: by qgeb6 with SMTP id b6so89978513qge.3
	for <emacs-orgmode@gnu.org>; Mon, 24 Aug 2015 09:40:16 -0700 (PDT)
Received: from localhost (nat-130-132-173-5.central.yale.edu. [130.132.173.5])
	by smtp.gmail.com with ESMTPSA id
	42sm11586952qgf.42.2015.08.24.09.40.15 for <emacs-orgmode@gnu.org>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Mon, 24 Aug 2015 09:40:15 -0700 (PDT)
In-Reply-To: <877fokbuz5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of
	"Mon, 24 Aug 2015 16:51:26 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Org-mode <emacs-orgmode@gnu.org>

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> I think core is fine for new languages, but you need to update file
> headers accordingly.

Will do.

> A few comments follow.

Thanks for your comments.  Updated.

> You don't use `org-babel-stan-cmdstan-directory' to store FILE, i.e.,
> FILE is saved in current directory, or any directory provided in its
> path, which doesn't necessarily match
> `org-babel-stan-cmdstan-directory'. Yet, make is called on
> `org-babel-stan-cmdstan-directory'.
>
> Is it intentional?

Yes.  The Makefile in the CmdStan directory can be used to compile any
*.stan file (regardless of whether it is in the CmdStan source
directory) into a model executable that's in the same directory as the
original *.stan file.

I'll wait a bit to see if any more comments come in and then install the
updated version in master, if that is OK with you.

Thanks.

--
Kyle