Bug: org-shitmeta(up/down) does not seem to handle subtrees and items properly [8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)]

Bug: org-shitmeta(up/down) does not seem to handle subtrees and items properly [8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)]

[Fernando Varesi]

Hi. First of all I apologize if this report does not comply in any way to the standards, since it's my first report.

Steps to reproduce:
1. Create an outline with 2 headlines, each of them having their own drawers.
2. Move the pointer to the headline.
3. Hit M-S-down.

Expected Behavior:
M-S-up/down should move the subtree/item up/down when pointer is in a headline/item.

Current Behavior:
Only the headline is moved, even inside a drawer if it's present.

Debugging:
I checked the functions org-shiftmetaup and org-shiftmetadown, and the cond does not check for org-at-heading-p nor org-at-item-bullet.

Fix:
You'll notice in my configuration I added hooks for org-shiftmetaup-hook and org-shiftmetadown-hook. This produces the expected behavior, but I think these conds should be added to the function itself. I'm not sure org-at-item-bullet is the right predicate, but it worked for me.

Thanks,

Fernando.




Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------



Emacs  : GNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.16.4)
 of 2015-06-28 on trouble, modified by Debian
Package: Org-mode version 8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)

current state:
==============
(setq
 org-src-lang-modes '(("http" . "ob-http") ("ocaml" . tuareg) ("elisp" . emacs-lisp) ("ditaa" . artist) ("asymptote" . asy)
		      ("dot" . fundamental) ("sqlite" . sql) ("calc" . fundamental) ("C" . c) ("cpp" . c++) ("C++" . c++)
		      ("screen" . shell-script) ("shell" . sh) ("bash" . sh))
 org-tab-first-hook '(org-hide-block-toggle-maybe org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-shiftmetadown-hook '((lambda nil
			   (cond ((org-at-heading-p) (org-move-subtree-down)) ((org-at-item-bullet-p) (org-move-item-down))))
			  )
 org-speed-command-hook '(org-speed-command-default-hook org-babel-speed-command-hook)
 org-notmuch-search-open-function 'org-notmuch-search-follow-link
 org-occur-hook '(org-first-headline-recenter)
 org-metaup-hook '(org-babel-load-in-session-maybe)
 org-clock-mode-line-total 'today
 org-confirm-shell-link-function 'yes-or-no-p
 org-default-notes-file "~/org/notes.org"
 org-agenda-include-diary t
 org-after-todo-state-change-hook '(org-clock-out-if-current)
 org-from-is-user-regexp "\\<Fernando Varesi\\>"
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-babel-pre-tangle-hook '(save-buffer)
 org-mode-hook '(#[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-show-block-all append local] 5]
		 #[nil "\300\301\302\303\304$\207" [org-add-hook change-major-mode-hook org-babel-show-result-all append local] 5]
		 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-shiftmetaup-hook '((lambda nil (cond ((org-at-heading-p) (org-move-subtree-up)) ((org-at-item-bullet-p) (org-move-item-up)))))
 org-ctrl-c-ctrl-c-hook '(org-babel-hash-at-point org-babel-execute-safely-maybe)
 org-enforce-todo-dependencies t
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
		  org-optimize-window-after-visibility-change)
 org-notmuch-open-function 'org-notmuch-follow-link
 org-enforce-todo-checkbox-dependencies t
 org-todo-keywords '((sequence "TODO(t)" "IN_PROGRESS(p)" "|" "DONE(d)"))
 org-confirm-elisp-link-function 'yes-or-no-p
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-log-into-drawer t
 org-blocker-hook '(org-block-todo-from-checkboxes org-block-todo-from-children-or-siblings-or-parent)
 org-babel-load-languages '((emacs-lisp . t) (http . t))
 org-agenda-files '("~/org/notes.org")
 org-clock-out-hook '(org-clock-remove-empty-clock-drawer)
 org-clock-out-remove-zero-time-clocks t
 )
-- 
Ing. Fernando Varesi

Re: Bug: org-shitmeta(up/down) does not seem to handle subtrees and items properly [8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)]

[Nicolas Goaziou]

Hello,

Fernando Varesi <fvaresi@gmail.com> writes:

> Steps to reproduce:
> 1. Create an outline with 2 headlines, each of them having their own drawers.
> 2. Move the pointer to the headline.
> 3. Hit M-S-down.
>
> Expected Behavior:
> M-S-up/down should move the subtree/item up/down when pointer is in a headline/item.
>
> Current Behavior:
> Only the headline is moved, even inside a drawer if it's present.

M-S-down mostly ignores structure. It moves current line down, whatever
it is. Check its docstring, in particular first and last sentences:

  Drag the line at point down.
  In a table, insert an empty row at the current line.
  On a clock timestamp, update the value of the timestamp like `S-<down>'
  but also adjust the previous clocked item in the clock history.
  Everywhere else, drag the line at point down.


Regards,

-- 
Nicolas Goaziou

Re: Bug: org-shitmeta(up/down) does not seem to handle subtrees and items properly [8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)]

[Fernando Varesi]

[-- Attachment #1: Type: text/plain, Size: 1405 bytes --]

Hi, Nicolas. Thanks for replying

Given the documentation in
http://orgmode.org/manual/Structure-editing.html#Structure-editing, I would
expect it to still use org-move-subtree-down.

Anyway, my desired behavior can be easily achieved with hooks so I don't
mind it keeping it  as is, but I thought that somehow the functionality
described in the manual was lost unintentionally.

Regards,

Fernando Varesi.

On Fri, Sep 4, 2015 at 2:33 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:

> Hello,
>
> Fernando Varesi <fvaresi@gmail.com> writes:
>
> > Steps to reproduce:
> > 1. Create an outline with 2 headlines, each of them having their own
> drawers.
> > 2. Move the pointer to the headline.
> > 3. Hit M-S-down.
> >
> > Expected Behavior:
> > M-S-up/down should move the subtree/item up/down when pointer is in a
> headline/item.
> >
> > Current Behavior:
> > Only the headline is moved, even inside a drawer if it's present.
>
> M-S-down mostly ignores structure. It moves current line down, whatever
> it is. Check its docstring, in particular first and last sentences:
>
>   Drag the line at point down.
>   In a table, insert an empty row at the current line.
>   On a clock timestamp, update the value of the timestamp like `S-<down>'
>   but also adjust the previous clocked item in the clock history.
>   Everywhere else, drag the line at point down.
>
>
> Regards,
>
> --
> Nicolas Goaziou
>

[-- Attachment #2: Type: text/html, Size: 2006 bytes --]

Re: Bug: org-shitmeta(up/down) does not seem to handle subtrees and items properly [8.3.1 (8.3.1-95-g1dbb25-elpa @ /home/fvaresi/.emacs.d/elpa/org-20150831/)]

[Nicolas Goaziou]

Fernando Varesi <fvaresi@gmail.com> writes:

> Given the documentation in
> http://orgmode.org/manual/Structure-editing.html#Structure-editing, I would
> expect it to still use org-move-subtree-down.

This is bound to M-down, isn't it? It probably is a documentation bug.

Regards,