From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Malakhovski <oxij@oxij.org>
Subject: Re: [PATCH 6/9] factor out date-timestamp* calculations to
 org-store-link-props
Date: Wed, 04 Nov 2015 15:21:19 +0000
Message-ID: <8737wln634.fsf@yin.lan>
References: <1446581747-1960-1-git-send-email-oxij@oxij.org>
	<1446581747-1960-7-git-send-email-oxij@oxij.org>
	<87io5ivwci.fsf@gmail.com> <87io5im1hz.fsf@yin.lan>
	<871tc5x20q.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51783)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1ZtzsX-0000zL-BI
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1ZtzsS-0002pr-EY
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:21:37 -0500
Received: from tricoro.koumakan.jp ([195.154.188.176]:63940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1ZtzsS-0002pn-8f
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 10:21:32 -0500
In-Reply-To: <871tc5x20q.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Aaron Ecay <aaronecay@gmail.com>, emacs-orgmode@gnu.org

Aaron Ecay <aaronecay@gmail.com> writes:

> Checking the source, date-to-time can raise an error (invalid date).
> format-time-string is a C function, so it=E2=80=99s less easy for me to
> understand.  But it looks like if it raises any errors, these are bugs
> that we want to know about and not suppress.
>
> The ignore-error call was introduced to org-gnus in commit 0dfde2da.
> Based on the commit message, it looks like the problem being solved was
> invalid dates getting passed to date-to-time.
>
> So I think the ignore-error can just wrap the date-to-time call.

Thanks. Ok.