From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug? Setting #+OPTIONS: title:nil Seems to Be Ignored in HTML
 Export.
Date: Tue, 01 Aug 2017 10:15:28 +0200
Message-ID: <87379bu2jj.fsf@nicolasgoaziou.fr>
References: <71359491574f233bd37d0804042fb701@wilkesley.net>
	<CAFyQvY2z2zhw_bf3xMtd_jNt5PgHyvxiabHrnrqoiW+3J0fvXA@mail.gmail.com>
	<CAFyQvY2s+-SpBROrTCau3hsLuXQHSxg46To4nDz-5xpB+ZxcCQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcSKz-0005gi-NI
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 04:15:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dcSKy-00037D-TF
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 04:15:33 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:34098)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dcSKy-00033r-Mm
	for emacs-orgmode@gnu.org; Tue, 01 Aug 2017 04:15:32 -0400
In-Reply-To: <CAFyQvY2s+-SpBROrTCau3hsLuXQHSxg46To4nDz-5xpB+ZxcCQ@mail.gmail.com>
	(Kaushal Modi's message of "Mon, 31 Jul 2017 18:33:50 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-orgmode@gnu.org, lists@wilkesley.net

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> From e57e9e798dd1a54cae7a633fc67e2f825b967eea Mon Sep 17 00:00:00 2001
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Mon, 31 Jul 2017 14:30:40 -0400
> Subject: [PATCH] Respect :with-title in ox-html
>
> * lisp/ox-html.el (org-html--build-meta-info): Do not insert <title>
>   tag in HTML export if :with-title property is nil.  Example: by
>   setting #+OPTIONS: title:nil

[...]

> +     (when (plist-get info :with-title)
> +       (format "<title>%s</title>\n" title))

I would use `and' instead of `when' to stress the fact that we're
interested in the return value. Otherwise, LGTM.

Thank you.

-- 
Nicolas Goaziou