emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brad Knotwell <bknotwell@yahoo.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: resend of a patch for ob-lua.el
Date: Tue, 22 Jan 2019 09:05:07 +0100	[thread overview]
Message-ID: <8736plglsc.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1530980378.1568524.1548139325432@mail.yahoo.com> (Brad Knotwell's message of "Tue, 22 Jan 2019 06:42:05 +0000 (UTC)")

Hello,

Brad Knotwell <bknotwell@yahoo.com> writes:

> It looks like my original patch was never integrated.  The code below
> makes tangling multi-line variable work by using Lua's multi-line
> string syntax ([=[ ... ]=]) instead of the python-like but invalid
> """.
> Likewise, it doesn't change the single line behavior.
> Testing is pretty straightforward:  pass a multi-line variable in as
> a header argument, tangle the file and try to load it.  Before ==
> syntax error and after == code loads and runs.

Thank you!

 Would you mind sending it using git format-patch command, along with
a proper commit message?

Also, free to write a regression test about it :)

Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2019-01-22  8:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1530980378.1568524.1548139325432.ref@mail.yahoo.com>
2019-01-22  6:42 ` resend of a patch for ob-lua.el Brad Knotwell
2019-01-22  8:05   ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736plglsc.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bknotwell@yahoo.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).