From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OD6VJgZDlmMEUQAAbAwnHQ (envelope-from ) for ; Sun, 11 Dec 2022 21:52:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KOaxJgZDlmM7YgEA9RJhRA (envelope-from ) for ; Sun, 11 Dec 2022 21:52:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A41237C74 for ; Sun, 11 Dec 2022 21:52:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4TDR-0005Hg-AZ; Sun, 11 Dec 2022 15:46:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4TDN-0005HN-CF for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 15:46:25 -0500 Received: from out2.migadu.com ([188.165.223.204]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4TDL-0003TR-9Z for emacs-orgmode@gnu.org; Sun, 11 Dec 2022 15:46:25 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1670791580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xpWSE4y/JnqrYnzx1dnHofVrzj5fjCeRcie6ae5hL7Q=; b=xmKjbRCzJD8iGpxH54gqZqCxRcBVbmYimYMY9395Sh0TPNDlBrM/EyuQeFD0HSXlyufyxz Ghqv3MRAiQcKKNeOsNGNLr1/i/KI+m3IdvTkX75WdQQSQVf4VyMEuhJtLFoM5Y6jza4LSe 2WsQb8lEvh8caRs+bL9kVm7PnK6cGPo0vFB8cXeVRqlHDuryBrNxZXE2isP/u+xZDXuUWb v4Q4rg4c/81B1baIL1AqvxjwZcAglqN16ADs7cg6GdkZOu8FbFfnskTI38G0wx9Z9SlP7y fXdSSoBImSPOun/KkG2NWfOtxueYQeXQwRArKFvVhjTMozohbVivyaKsp/H9Gg== From: Kyle Meyer To: Tom Gillespie Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-core: add org-confirm-babel-evaluate-cell custom variable In-Reply-To: References: Date: Sun, 11 Dec 2022 15:46:17 -0500 Message-ID: <87359ld5ye.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=188.165.223.204; envelope-from=kyle@kyleam.com; helo=out2.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670791942; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xpWSE4y/JnqrYnzx1dnHofVrzj5fjCeRcie6ae5hL7Q=; b=kz3PZ2vB3yrd/eH/NCBk4ejSWVp6hHvivgJgUxztIEUMej9OmYVtr4gBNvlSm4kjtqHyjp uHW6Og3eu4+5wjFQfO56JF98rLhSUm2U6PkaCYFe3IZiMGqA3HbunM2S5Ob5El5Y1qMK18 vMAZlja4pK3gbb17M2fEt0N2dfxTpUDtFH7AWrIxEHLQxiyhpS5TZ0dySjMll+eIJKKfFN 1PqgvajQGbNI3/Jy0O62ILv18B+jY+my+SEMAPyO49BOekX43WOwQU+JimMeD2YjTxENbx YG6Z82YIvI42ExIXVeiPHNfZNWVXbqWnl10ZNo3w4Wn6L9HdTJwykDuHVCLY+Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=xmKjbRCz; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670791942; a=rsa-sha256; cv=none; b=I5b8Ld38kEHZR/JV05hS187obdX4ri209Hf8XxqcF9XzMaGbZwCCterpGo1aI31nasjfeS FnVomKxtLBKnkfdqh1rWjtfQwfrpRWPkqVLiSPv6dIYiAqeOidHwGQE4xSKXsG8K6v9B4r Nqc0dMKmcBfZXv7eEJTdW0uANidDnEZ84DSnKhdW9H6Ve6sQWvn/4AhAyHJKUDq2zdRa9T KUN7xInggvrQ7Cz4JGrXzwvAm0aw960r7/mPCFJDS3FH4aEQK5dlQYnFm0BAf02qQSxJO0 P5UVlxpyMEvDX+rfd0+cGlYn5Tvo+sSJU4Y/TMsxlptC3Le1EFhqxdB+hWI8uw== X-Migadu-Spam-Score: -10.19 X-Spam-Score: -10.19 X-Migadu-Queue-Id: 7A41237C74 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=xmKjbRCz; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=none X-TUID: Ky/tE1sDCdvg Tom Gillespie writes: [...] >> :package-version instead of :version? > > I think because org is part of emacs core we use the emacs version? Please use :package-version and let the mapping be handled by customize-package-emacs-version-alist. > I see "24.1" included with other org defcustoms. There has a been a good amount of clean up to remove :version and use :package-version, but, yes, there are still :version instances. Things look good for the last Org release, though: $ git grep '29\.1' lisp/org.el: ("9.6" . "29.1")))