From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp11.migadu.com ([2001:41d0:403:4789::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms9.migadu.com with LMTPS
	id wBBdBAsDtWTKkQAASxT56A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 17 Jul 2023 10:59:55 +0200
Received: from aspmx1.migadu.com ([2001:41d0:403:4789::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp11.migadu.com with LMTPS
	id eFWSBAsDtWQHxgAA9RJhRA
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 17 Jul 2023 10:59:55 +0200
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 9113749138
	for <larch@yhetil.org>; Mon, 17 Jul 2023 10:59:54 +0200 (CEST)
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=BXajjU+W;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1689584394; a=rsa-sha256; cv=none;
	b=uNtbd7OhyiZ+H/Rr3zjEXM880yxUZ3OfNS26Eh5EwQUPiT892qWB2YcV0/MhNhYTHES+qV
	UWIy+8hu5g0Niylh+rjMtBaXEIesLwJgrzDQOC/zmvo8Zgg2ZnkR994JTct91tcIL8XHlx
	4SI8YFUJXwSIx4ukPuwgAq4N+hUqnr7s0OvTrgUbXxCNSEhxAirqY599Dv4tA4LUXZ64hI
	Gc4OwXiaV8EsZj7k91J174DzfCQovF/oNKcc6cUDMW6hA0c+ROW+9CalEWkWADaGqHji0r
	Uagw7DubvOpnOa9Up47uNAeWg4jb964285ajnYVuR9Xk01qtz0+EryFT+U9zQw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=BXajjU+W;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1689584394;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=lnz+SHzMzIczMJCXVvoVlO8NRkzCMEDx+iFYycwnFuI=;
	b=fQwqFE6OrA3BY7Rdl41ZQNeu6TUabloaVLNBDvGSIX+orp0FG2uIbMU09WzwUVH0cPGXQY
	VZZoC5DCnbNaEaGEcw6shkEdAb3qC3gbifMYcSO8P9zcgfx005WXFVd2XzAoEbvSbTGx0I
	KV2dUBzwI/IvmGJf8HSl9ooBCVXj0vsJAkIgIwK8MMI5k0fM70qHeCH+fttkG4JTGFUyFT
	VsVJckGgGQoAcJReg+nY0ecTnCbSqgWPVSqCSnugYdzPEhdY3tnpT1Yvl6tdAWuH8Ndewo
	0U9heA/Uo9mZVWMTpfm7ML/yPGfhtn45E3OIzRNaVoNivxCY+V5H05U+LfnLVw==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1qLK4B-0007Hf-HG; Mon, 17 Jul 2023 04:58:51 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1qLK49-0007HR-AN
 for emacs-orgmode@gnu.org; Mon, 17 Jul 2023 04:58:49 -0400
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1qLK46-0005H2-M5
 for emacs-orgmode@gnu.org; Mon, 17 Jul 2023 04:58:48 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 4F157240029
 for <emacs-orgmode@gnu.org>; Mon, 17 Jul 2023 10:58:43 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1689584323; bh=CsaTsA8xprmsJ/QS9Qv1q5Wyc9A7rtdlKapS8a5SSOU=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From;
 b=BXajjU+WT1foJ56bAG9zeWf2b0srZasSQ5aCO/DfyJKnXdX2xI8u3oDFEY1j3zP3j
 He9JBUHHUyKb8i6EWQXN0SOky13gQQQSqqtLS/tQI8UdFqrrb387bcPxAJHT2sTO5I
 MVHdpmErlJf6u1h2w7lO7OV2mhyPX62saCShGyAJXs3hVNgHtOnlgHw9kn9mNI/IDp
 W+odukYaPM1auluAzWRPlIw8lGmeXih3tIBjJOdQiSif+RZp7JwuaLJ0WTGyVOoMKx
 Hhv1Mil8pN5AvtkFRTCwRRDlwb4EnDzJNwnq9TAYnLcaLXCH3ljweivQrmqCUZ/bUX
 XG/naafU/4dzg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4R4GGB4Qplz6tm4;
 Mon, 17 Jul 2023 10:58:42 +0200 (CEST)
From: Ihor Radchenko <yantar92@posteo.net>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: Axel Kielhorn <org-mode@axelkielhorn.de>, emacs-orgmode@gnu.org
Subject: Re: [DRAFT PATCH v5] Decouple LANG= and testing (was: Test failure
 due to LANG)
In-Reply-To: <87cz3rowx4.fsf@localhost>
References: <D140FA73-9995-4467-963E-00D5964485C0@axelkielhorn.de>
 <sdvzg70utif.fsf@netyu.xyz> <sdvv8housn7.fsf@netyu.xyz>
 <sdvmt30um3h.fsf@netyu.xyz> <sdvedocukz1.fsf@netyu.xyz>
 <32E3D56A-9DDF-4D70-BBA6-2DB71919EC98@axelkielhorn.de>
 <sdvy1mkt0vw.fsf@netyu.xyz> <sdvh6t7tlmw.fsf@netyu.xyz>
 <37BA8B13-A49D-41A4-B752-4ED9540D5799@axelkielhorn.de>
 <sdvo7nfrs7p.fsf@netyu.xyz> <871qkau9t6.fsf@localhost>
 <sdvbkjer8c3.fsf@netyu.xyz> <874jp64oxr.fsf@localhost>
 <sdvfs8os6es.fsf@netyu.xyz> <87cz3rowx4.fsf@localhost>
Date: Mon, 17 Jul 2023 08:58:54 +0000
Message-ID: <87351m29td.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net;
 helo=mout01.posteo.de
X-Spam_score_int: -53
X-Spam_score: -5.4
X-Spam_bar: -----
X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Country: US
X-Migadu-Flow: FLOW_IN
X-Migadu-Queue-Id: 9113749138
X-Migadu-Scanner: mx1.migadu.com
X-Migadu-Spam-Score: -9.21
X-Spam-Score: -9.21
X-TUID: SIReXFJ8v4Gx

Ihor Radchenko <yantar92@posteo.net> writes:

> Ruijie Yu <ruijie@netyu.xyz> writes:
>
>> Ihor Radchenko <yantar92@posteo.net> writes:
>>
>>> (let ((org-time-stamp-formats '("%Y-%m-%d" . "%Y-%m-%d %H:%M")))
>>>      (org-element-timestamp-interpreter timestamp nil))
>>
>> Thanks for the pointer.  I have made this into a macro and redid my
>> changes accordingly.  Please also let me know if more work should be
>> dedicated to avoid code duplication in tests (I see a lot of duplication
>> in the portions I touched in testing/lisp/test-org.el).
>
> Thanks!
> Some comments below.

I decided to go ahead and implemented my suggestions myself, after
applying your patches.
Applied, onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=ab9c9732e
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8739a9578
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9730f408c
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=26440689a

Note that I am going through this thread after a reminder to re-check
copyright status. I may still miss some of your other patches.
If you have something pending, you can let me know, so that we do not
wait until my previous scheduling triggers.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>