From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>
Received: from mp12.migadu.com ([2001:41d0:303:e224::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms8.migadu.com with LMTPS
	id oKqfOCxST2WFcgEAauVa8A:P1
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 11 Nov 2023 11:06:37 +0100
Received: from aspmx1.migadu.com ([2001:41d0:303:e224::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp12.migadu.com with LMTPS
	id oKqfOCxST2WFcgEAauVa8A
	(envelope-from <emacs-orgmode-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sat, 11 Nov 2023 11:06:36 +0100
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id 99F8F16A4A
	for <larch@yhetil.org>; Sat, 11 Nov 2023 11:06:36 +0100 (CET)
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=odd1P+XG;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1699697196; a=rsa-sha256; cv=none;
	b=g/QmAjyBAvg1WU9Who7/pPksGagiFy8RZPm07gTB7bu5oHttEV9ep3WgFtG9D9hr8As9aW
	fJYy/3+6/pd+4tgAmBasA50XLW9Nt14T6nRkwg6EtKmDXrECCd7QwH94INx+Kl3r/EcOJY
	KFffG1tnF5OfGAm2hKRwBvQNOyGRHXNIN3dLz/XfO2YWFFtidSroXWagOojNBUGOQ+anDO
	kEGe1KMcfe7pALhY+1GBV8x9mV3sQX0CsAQGP3cpcVP7y7Co+ySqWzWV0Zh03pPg+ey0Wb
	doTWo+yUAfNUiHseIhaF1cIBJTtviDDXi+Sh+yI6Sr5V8yd4IAz1eMJR9bXLEQ==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=posteo.net header.s=2017 header.b=odd1P+XG;
	dmarc=pass (policy=none) header.from=posteo.net;
	spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1699697196;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=ddYadc3fzaaC6e4FHMJTgjqdujMdypJ2hPJmCfvCEgQ=;
	b=KNYoChrNWdpo65DAldl1sUghqjQ8Ej7dmxP/7V2ClgB/iY+Rg6K1h+wSDc2/eLwU5QTQbp
	ep/iXXf7QgANiwFJKXDydWVFN105N3KY1BctNL3v+VI6v2mp4PP+NXCKoY+afb7MAdjkyC
	10J8+PjnCnImof2WfQNfJFH9A+L+ga9zyQYSHU/+O/f5/sEyqJIJbfJYpoe2Go/DrhmShJ
	q5a+hpOWtHi1x2GM3FMFDScdWw2u9ss0L6eV+Uz9Xk2rTn0sT1+IW9DkgJTGL0vr5Ykk1H
	Ag77YnDTT5cxEflqDb196czUd0VZd8Pzyt+ga45N3d0MCxfq6Y6c54LN1SqbYA==
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-orgmode-bounces@gnu.org>)
	id 1r1ksI-0008KX-SP; Sat, 11 Nov 2023 05:05:58 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1r1ksF-0008IX-4l
 for emacs-orgmode@gnu.org; Sat, 11 Nov 2023 05:05:56 -0500
Received: from mout02.posteo.de ([185.67.36.66])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <yantar92@posteo.net>)
 id 1r1ksC-0005qx-H1
 for emacs-orgmode@gnu.org; Sat, 11 Nov 2023 05:05:54 -0500
Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 78305240103
 for <emacs-orgmode@gnu.org>; Sat, 11 Nov 2023 11:05:49 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1699697149; bh=2+XTQrLwLm4XXsU22w3YZ7hpuxo3SR+JpAOFTbnB5X0=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From;
 b=odd1P+XGHgQDsq5nhY60j+LY5HTlHKCqsmZYkrckj5judO9/5nralm415MB7ajK5A
 Y1QO8nBz19BV9Dde92f6p9OKw2Qf9PfDtf/kRaESqQ0naBwbK9pBrcsMfYSO89nW8F
 LqE3LyFf0NAjASNEm0XS74xDMmW9ok6mbmuxS7qZqV7tq5LyoPOTGo9oNS9kog0Srd
 CdvBhsoeprXLET+ukAQUqIzb5/l3GKVxr5/PeYNsoJfjqdO0qmD/wy9pQTKnR6Hl76
 WmWAMDHXX5p9Q9xi11HMszBIRMbYKZCr6mc1sVXchf38rk56+y/9QE4koQQxUTwnOt
 HB/W9afR+QH/w==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4SSBCc5GHXz6tsj;
 Sat, 11 Nov 2023 11:05:48 +0100 (CET)
From: Ihor Radchenko <yantar92@posteo.net>
To: Leo Butler <Leo.Butler@umanitoba.ca>
Cc: Max Nikulin <manikulin@gmail.com>, "emacs-orgmode@gnu.org"
 <emacs-orgmode@gnu.org>
Subject: Re: [TASK] Allow customizeable ditaa executable in ob-ditaa.el
In-Reply-To: <874jhtocqz.fsf@t14.reltub.ca>
References: <ZTEML8zWrB6kQflk@toolbox> <87wmvhnr8b.fsf@t14.reltub.ca>
 <ZTLzpmF0rsy9cr52@toolbox> <871qdo5sdh.fsf@web.de>
 <87y1fwtkth.fsf@localhost> <87sf5f7h04.fsf@t14.reltub.ca>
 <uiiikh$j7f$1@ciao.gmane.io> <87zfzmnvl7.fsf@t14.reltub.ca>
 <uil16s$6no$1@ciao.gmane.io> <874jhtocqz.fsf@t14.reltub.ca>
Date: Sat, 11 Nov 2023 10:07:58 +0000
Message-ID: <8734xcwqkh.fsf@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net;
 helo=mout02.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_PASS=-0.001,
 T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: emacs-orgmode@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
 <mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Queue-Id: 99F8F16A4A
X-Migadu-Scanner: mx12.migadu.com
X-Migadu-Spam-Score: -6.93
X-Spam-Score: -6.93
X-TUID: mF8CPL/HOoJu

Leo Butler <Leo.Butler@umanitoba.ca> writes:

> I am glad we agree. Now let me tell you my dilemma: a while ago, I
> suggested a patch to implement similar functionality for ob-maxima. The
> patch used customization variables, much like ob-plantuml does. Ihor's
> feedback was that this was not a good approach (too much room for
> accidental breakage, etc.). Eventually, the patch was amended to acheive
> the same goals using new header arguments.
>
> So, now, in my opinion, consistency would dictate that we re-visit the
> changes made to ob-plantuml, re-fashion them and do something similar
> with ob-ditaa. Except, users have likely become accustomed to using
> ob-plantuml as it is...
>
> Thoughts?

Let me clarify.

For ob-maxima, my main concern was that we _need_ certain header
arguments to parse the output of Maxima. So, those _required_ header
arguments should be hard-coded and not customizeable. Other header
arguments may be customizeable (via header args or defcustom; header
args is more flexible).

This is not the case for ob-plantuml - the default -headless argument
may be safely removed; it just makes loading java faster.


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>