From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id MN+DA5hucWdTrwAAqHPOHw:P1 (envelope-from ) for ; Sun, 29 Dec 2024 15:45:28 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id MN+DA5hucWdTrwAAqHPOHw (envelope-from ) for ; Sun, 29 Dec 2024 16:45:28 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=thaodan.de header.s=mail header.b="nv25/FjX"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=thaodan.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1735487127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=5f22/jGUvL3KUNlis9BsJggEEggnHk0Sa8mYAMIFIV8=; b=blIlu7VHchhZgZEepTNlM0k3YjfnYChpPFIm+DDHOB0KWlrtCTE7wNi2eGw/2SPYKReSPV Y1RasDBosFCxG7rHdh8Y0Ab89CEuFH8yrpModCl7bNFLlIFiXKsSezNrR6WGeDbCsHFscm VkXse1irWFNKgsTy5cAOf/0e6eklfL7FYkHNJtBLGE0EWoYLXmcdN1J+yuHKNyI/+wtdg3 4AanzFo9WS47aia1fZRTC+61rlF9laY23VMRbt9bSBpgC84pvaELDQWYZox7Whn7M+uxWn 3kdbZiowqqntWtJe3kRWQyovxUsJpc6cMnC+6IWp1T9tLR908SJ+VDyMr9eZxw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=thaodan.de header.s=mail header.b="nv25/FjX"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=thaodan.de ARC-Seal: i=1; s=key1; d=yhetil.org; t=1735487127; a=rsa-sha256; cv=none; b=bgyJI4Oj0GHSeeN0MfzWF0WM2VJrefkDXCzZ8PkL29JetoSJfbFRUtrvp00HhQokUlZiRx KAEVWX2vO/85q5qsKYJEBKJFPKPi3XCVLegWStOGfGkellxWocfcjiO5K5BjJ1xxMtWOSP 6Xkryp1K7TTAh0yNxCDMciZe/W+1HdVl3Y81SFeOq+b3RRuWRCH5nYCtmJ1dnYUY7eDx6r CZWNUi6a8hwqVq9qWEDLz8hP/D0h+Ectspdgqsw3RG4EjMpBmEtaaa4bri/gl+lSXyPF2+ 94JbqKJzdSAKlVNJTXRYFGsKBh2cJ8EFJJqePCgJYz1j1aCm5LELr8XPDCQQ/A== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A864386607 for ; Sun, 29 Dec 2024 16:45:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRvT8-0007Ql-1l; Sun, 29 Dec 2024 10:44:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRvT2-0007QT-8M for emacs-orgmode@gnu.org; Sun, 29 Dec 2024 10:44:36 -0500 Received: from thaodan.de ([185.216.177.71]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRvT0-0003vB-9t for emacs-orgmode@gnu.org; Sun, 29 Dec 2024 10:44:36 -0500 Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 764CCD00081; Sun, 29 Dec 2024 17:44:32 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1735487072; bh=9MiQIN9GFtzGpz5dwmaRyvLHVRc3y2VlehTreM2H2So=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=nv25/FjXbXG6HAWRbR33JUKa71lmeQp01V1OwFp9Rrvgr0v0o8/YT5DwjH4NnLpye IogSFVkX1wzAIp9N4oQ+JsvPOIojABLUJXOEAEGOjM3W2+dRwPUG5iKbgtchctmtJ/ 7eiOAuvXNWYn0zITnMjlmYNmOpuzDM6kcFY3q6rT6jVWZTI6uhdJ8UzTEIYHtY38qt KBaYCjCrSrGMUTLhoUOBpXfgZ3mcnEcmI7DLOXuLrUnTfx45oV+Pe2BBc/4Tnwk6ex FJSL8oeVzzxu+KIy9rseemQRYvr8iOCgBVlEfYONz+Xpp6axhsaCQYBxJsPUxCtp+1 oT+n1Q/QVfKn+HQLlw8jEsOCqr4GuSOGb0LAhszCCZjIfQnq8lc4aGNEcjcWQx+4sC /lqhLH2XjBcr3t2JlXz/LeG+GHcsn+nUlB5BpvrlNE1kv9KrWgslDDAMN6eJyX+nd8 0sLvH7WF05Pq+H9sTcPK/adD+K1rIjUDIAuEbNXI2d31Gi0pekB3AfvJNnT8PnUhuP A2CKhnKk+qqeDjC/4GqQF3GRrtbZhpk9S00c4sI9EQb6+4SYtRzaACkqk1JTkXFg7a gOqNjpMd2F+Zjhhjqqx0oWfLm4FeYcDBle4t7F9IHar7vOuwXGyFVxR3vqHt4Yltjp Apqn1GCK3JzaZ2dW2zQUT4FM= From: =?utf-8?Q?Bj=C3=B6rn?= Bidar To: Karthik Chikmagalur Cc: Ihor Radchenko , emacs-orgmode@gnu.org Subject: Re: Link preview generation with new link preview property In-Reply-To: <87y102mgdx.fsf@gmail.com> (Karthik Chikmagalur's message of "Thu, 26 Dec 2024 10:46:34 -0800") References: <6755f138.0c0a0220.40388.51fbSMTPIN_ADDED_BROKEN@mx.google.com> <874j382kue.fsf@gmail.com> <87pllug2y4.fsf@localhost> <87ldwfnff4.fsf@gmail.com> <874j328aym.fsf@localhost> <6764aa79.050a0220.23273b.09a5SMTPIN_ADDED_BROKEN@mx.google.com> <87y102mgdx.fsf@gmail.com> Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1+ntAhsDBQsJCAcCAiICBhUKCQgL AgQWAgMBAh4HAheAAAoJEFwbdKFlHF9oBgwA/iQHwe0VL4Df4GGTYlNjMSHFlIkBmN4UfYGLYj3E TrOUAQC51M+M3cjsL8WHdpBz6VAo6df9d+rVwhQ9vQuFHqevArg4BGTX6T4SCisGAQQBl1UBBQEB B0Cbohc3JEfn005/cm0AOGjSsW1ZxAkgaoVNjbpqk4MgNAMBCAeIeAQYFgoAIBYhBFHxdut1RzAe pymoq1wbdKFlHF9oBQJk1+k+AhsMAAoJEFwbdKFlHF9ooHABAKGmrGBic/Vys3BBrOQiRB3Z7izO HwhqTRpAqFZtXS2nAQDZhp/5aYw1TZjTzkm1KVt9QiYnjd/MvxRE9iaY6x4mDbgzBGTX6T4WCSsG AQQB2kcPAQEHQAgRJq/tMcCCB2XyA5WZpu7GvpRx0m9IPRWazeqhOq7uiO8EGBYKACAWIQRR8Xbr dUcwHqcpqKtcG3ShZRxfaAUCZNf71AIbIgCBCRBcG3ShZRxfaHYgBBkWCgAdFiEEUfF263VHMB6n KairXBt0oWUcX2gFAmTX+9QACgkQXBt0oWUcX2jeSwD6AtWn0cuo8IF35YRo4o3cDRJnUfJnbvJy GxyCDThR+zYBAKG6/jdwmZkBQZKslnDAbMMd2WfiZZT5JW3IWC4EaKMO7HkBAKYPGZ3UbfkRvfFK S+pQ9CgtNfkSJQBtT1Ob7Y6nsacgAQCpyXN7yppmhW/oBgivITPy9Lkg+V4NK9WZYZCU9Q7LBA== Date: Sun, 29 Dec 2024 17:44:31 +0200 Message-ID: <8734i68peo.fsf@> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.216.177.71; envelope-from=bjorn.bidar@thaodan.de; helo=thaodan.de X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, INVALID_MSGID=0.568, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -6.83 X-Spam-Score: -6.83 X-Migadu-Queue-Id: A864386607 X-TUID: Br8gYPXAGuBh Karthik Chikmagalur writes: >>>> ... >>>> Considering this, it might be better to just split >>>> `org-link-preview-file' into two public functions, where the "inside" >>>> function accepts an image instead of a file. >>> >>> Agree. >>> Would you be interested to create a patch? >> >> Did you think of something like this? > > It looks like you are respecting the alignment specifications, set via > org-image-align or the :align property of #+attr_*, but not the :width > property. Is the idea that the preview implementation that provides the > image should independently use org-display-inline-image--width? The width is set before the inline image is created. I'm not sure how this should be handled. Is the with set when creating the inline image Ihor? If the width is set before the image is created how should it be handled in the preview image-data function? > At minimum this requires making org-display-inline-image--width a public > function. But it would be good for org-link-preview-image-data to > respect both properties. I agree with both but I'm not sure what should be done on this.