From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Andreas Leha <andreas.leha@med.uni-goettingen.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: problems with export and :cache
Date: Thu, 29 Oct 2015 15:22:21 +0100 [thread overview]
Message-ID: <871tcdpxeq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87vb9pyf0l.fsf@gmail.com> (Aaron Ecay's message of "Thu, 29 Oct 2015 13:34:50 +0000")
Hello,
Aaron Ecay <aaronecay@gmail.com> writes:
> The simple patch attached to this message fixes a bug that my testing
> indicated was responsible for erroneous re-evaluations at least some
> of the time.
Thank you. A minor comment follows.
> (cons :result-type (cond ((member "output" result-params) 'output)
> ((member "value" result-params) 'value)
> (t 'value))))
> - (org-babel-get-header params :var 'other))))
> + (loop for item in params
> + unless (memq (car item) '(:colname-names
> + :rowname-names
> + :result-params
> + :result-type
> + :var))
> + collect item))))
Using `loop' here is, IMO, over-doing it. You can use instead, e.g.,
(org-remove-if
(lambda (item)
(memq (car item)
'(:colname-names :rowname-names :result-params :result-type :var)))
params)
Another option is to extend `org-babel-get-header' to accept a list of
keys instead of a single key.
In any case, this patch, or a variant thereof, should be applied to
maint.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-10-29 14:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 21:37 problems with export and :cache Andreas Leha
2015-10-28 21:45 ` Andreas Leha
2015-10-29 13:34 ` Aaron Ecay
2015-10-29 14:22 ` Nicolas Goaziou [this message]
2015-10-29 15:14 ` Aaron Ecay
2015-10-29 16:42 ` Nicolas Goaziou
2015-10-29 17:05 ` Aaron Ecay
2015-10-29 17:16 ` Nicolas Goaziou
2015-10-29 19:11 ` Aaron Ecay
2015-10-30 23:40 ` Andreas Leha
2015-11-07 16:37 ` Achim Gratz
2015-11-07 20:33 ` Aaron Ecay
2015-11-07 22:43 ` Achim Gratz
2015-10-29 14:58 ` Andreas Leha
2015-10-29 15:17 ` Aaron Ecay
2015-10-29 16:51 ` Nicolas Goaziou
2015-10-29 19:05 ` Aaron Ecay
2015-10-29 20:32 ` Thomas S. Dye
2015-10-29 23:01 ` Andreas Leha
2015-11-01 22:56 ` Nicolas Goaziou
2015-11-04 12:01 ` Aaron Ecay
2015-11-04 22:41 ` Nicolas Goaziou
2015-11-05 14:51 ` Aaron Ecay
2015-11-05 14:55 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tcdpxeq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=andreas.leha@med.uni-goettingen.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).