From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Samuel Loury <konubinix@gmail.com>
Cc: OrgMode ML <emacs-orgmode@gnu.org>
Subject: Re: `org-make-tags-matcher' broken by lexical-binding
Date: Sun, 10 Jan 2016 22:05:32 +0100 [thread overview]
Message-ID: <871t9pdu1v.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87si294y93.fsf@gmail.com> (Samuel Loury's message of "Thu, 07 Jan 2016 08:58:16 +0100")
Hello,
Samuel Loury <konubinix@gmail.com> writes:
> I found out that `org-make-tags-matcher' relies heavily on the dynamic
> binding.
Unfortunately, this is not the only one.
> First of all, it assumes that the `todo-only' variable is scoped
> in. This is simple to fix by making todo-only a parameter of the
> function and fixing the calls.
>
> Then, it returns a form that relies on the fact that the variables todo
> and tags-list are scoped in. AFAICU, this sounds a bit trickier to fix
> because the usage of the returned "matcher" can be correctly used
> depending on the case.
>
> For instance, `org-clock-get-table-data' gives to `org-clock-sum' a
> lamdba function that evaluates the obtained matcher.
>
> The attempt to funcall-ing the lambda in `org-clock-sum' complains that
> tags-list does not exist.
>
> I probably won't have the time to create a patch for that, so I just
> warn about the problem.
>
> Hope that helps.
Indeed, I noticed that, too. This is fixed. Thank you.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2016-01-10 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 7:58 `org-make-tags-matcher' broken by lexical-binding Samuel Loury
2016-01-10 21:05 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871t9pdu1v.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=konubinix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).