From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: [BUG] error with org-refile and ido-completion-help Date: Wed, 01 Jun 2016 12:08:59 -0500 Message-ID: <871t4galas.fsf@fastmail.fm> References: <87eg8jb4wy.fsf@fastmail.fm> <87shwyko6o.fsf@saiph.selenimh> <87mvn5aohd.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b89dt-0008Az-S9 for emacs-orgmode@gnu.org; Wed, 01 Jun 2016 13:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b89do-0005kM-4X for emacs-orgmode@gnu.org; Wed, 01 Jun 2016 13:09:16 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b89dl-0005fu-LR for emacs-orgmode@gnu.org; Wed, 01 Jun 2016 13:09:12 -0400 Received: from archthink (c-50-172-132-15.hsd1.il.comcast.net [50.172.132.15]) by mail.messagingengine.com (Postfix) with ESMTPA id 0B3B0CCD2E for ; Wed, 1 Jun 2016 13:08:59 -0400 (EDT) In-Reply-To: <87mvn5aohd.fsf@fastmail.fm> (Matt Lundin's message of "Tue, 31 May 2016 16:49:38 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Org Mode --=-=-= Content-Type: text/plain Matt Lundin writes: > Nicolas Goaziou writes: > >>> A git bisect revealed that the change was introduced in 2015 with the >>> following commit: >>> >>> ,---- >>> | commit 50ba0a5ed609f3600f2590f3ba22b8ab3ff3331c >>> | Author: Nicolas Goaziou >>> | Date: Sun Jun 7 00:38:58 2015 +0200 >>> | >>> | Fix 1a7364177046b8a57ade0aeb9f52bacfc0b8b088 >>> | >>> | * lisp/org.el (org-icompleting-read): Let `completing-read' or >>> | equivalent sort out type of completion. >>> | (org-olpath-completing-read): Revert partially >>> | 1a7364177046b8a57ade0aeb9f52bacfc0b8b088. >>> `---- >>> >>> It looks like this commit removed some functionality from the now >>> obsolete org-icompleting-read that made sure that the items in the >>> completion list passed to the completing read function were strings. >> >> Actually, this is a bug in "ido.el", since `ido-completing-read' is not >> a drop-in replacement for `completing-read'. The latter accepts lists >> of strings, but also alist, obarrays and hash tables. The former accepts >> only list of strings. >> >> I suggest to report the bug to "ido.el" maintainers since they probably >> want to preserve compatibility between the completion functions. > > OK. Thanks. I see that a bug report has been on the emacs list since > 2013: > > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15430 > > For the time being, it's easy enough to write a custom wrapper around > ido-completing-read, so I think I'll do that. > > It's worth nothing that the author of patch that originally added the > completing-read-function variable did not anticipate that > ido-completing-read would be a simple drop-in for completing-read: > > http://thread.gmane.org/gmane.emacs.devel/134000 > > For a long time (since at least 2009), org-mode had built-in support for > ido-mode completion when refiling. So this does seem to be a deprecation > of longstanding org-mode functionality. > > I'll see if we can add something to the docstrings to alert of the need > to write a wrapper around ido-completing-read. I think the simplest thing is just to remove the obsolete info in the manual. Please see the attached patch. Best, Matt --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Remove-paragraph-about-obsolete-variables.patch >From d66e08b15ddb107135b5cbaa6582c9461347a3a4 Mon Sep 17 00:00:00 2001 From: Matt Lundin Date: Wed, 1 Jun 2016 12:04:14 -0500 Subject: [PATCH] Remove paragraph about obsolete variables * doc/org.texi: Remove paragraph documenting now obsolete variables org-completion-use-ido and org-completion-use-iswitchbp. --- doc/org.texi | 6 ------ 1 file changed, 6 deletions(-) diff --git a/doc/org.texi b/doc/org.texi index 88c506c..36ab999 100644 --- a/doc/org.texi +++ b/doc/org.texi @@ -16931,12 +16931,6 @@ emacs -Q --batch \ @cindex tag completion @cindex link abbreviations, completion of -Emacs would not be Emacs without completion, and Org mode uses it whenever it -makes sense. If you prefer an @i{iswitchb}- or @i{ido}-like interface for -some of the completion prompts, you can specify your preference by setting at -most one of the variables @code{org-completion-use-iswitchb} -@code{org-completion-use-ido}. - Org supports in-buffer completion. This type of completion does not make use of the minibuffer. You simply type a few letters into the buffer and use the key to complete text right there. -- 2.8.3 --=-=-=--