From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Have SRC_BLOCK :padline accept numbers
Date: Tue, 18 Apr 2017 10:37:53 +0200
Message-ID: <871ssq157i.fsf@nicolasgoaziou.fr>
References: <CAJTMgxg0+bub2OzaKhUVN32O3iLWe44OkyS1P0nb-4H8z-PT=w@mail.gmail.com>
	<878tnoqne3.fsf@nicolasgoaziou.fr>
	<CAJTMgxgwF=MjdpbtUNJtWnaKcJm9Y64g3uMYjT5fJ2+6Oj=CUw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45753)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1d0Prq-0005Ud-VO
	for emacs-orgmode@gnu.org; Tue, 18 Apr 2017 05:56:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1d0Prn-0006Vg-Rp
	for emacs-orgmode@gnu.org; Tue, 18 Apr 2017 05:56:14 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:60221)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1d0Prn-0006Uu-Li
	for emacs-orgmode@gnu.org; Tue, 18 Apr 2017 05:56:11 -0400
Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net
	[217.70.183.195])
	by relay7-d.mail.gandi.net (Postfix) with ESMTPS id BB6633839
	for <emacs-orgmode@gnu.org>; Tue, 18 Apr 2017 11:56:08 +0200 (CEST)
In-Reply-To: <CAJTMgxgwF=MjdpbtUNJtWnaKcJm9Y64g3uMYjT5fJ2+6Oj=CUw@mail.gmail.com>
	(Daniel P. Gomez's message of "Wed, 29 Mar 2017 18:03:12 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Daniel P Gomez <gomez.danp@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Daniel P Gomez <gomez.danp@gmail.com> writes:

> I've amended the commit including the changes you've mentioned.
> I did not change the following, though:
>
> (numberp (string-to-int padlines)) -> (string-match-p "\\`[0-9]+\\'" padlines)
>
> because that changed the behaviour of org-babel-tangle. Having a
> string-match-p as a
> match condition broke the default of adding no padlines in the
> first tangled SRC block (when passed with no arguments).

`string-to-int' will fail the same way as `string-match-p' if `padlines'
is nil. So I do not see how the behaviour could differ. Could you
elaborate on the issue?

> I also noticed that adding this functionality to ob-tangle breaks eldoc
> for me. I guess all org babel header arguments have to be strings?

I didn't check, but that seems a reasonable assumption.

BTW, you didn't include the patch, did you?

Regards,

-- 
Nicolas Goaziou                                                0x80A93738