From: Tim Cross <theophilusx@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Re: Shouldn't ob-shell's org-babel-expand-src-block prepend the :shebang value?
Date: Thu, 10 Sep 2020 17:30:25 +1000 [thread overview]
Message-ID: <871rjaytpq.fsf@gmail.com> (raw)
In-Reply-To: <CA+A2iZbhCpefdO21agGW=wfNKY4nuYdkTcjO6XsJs8WequhP3A@mail.gmail.com>
Vladimir Nikishkin <lockywolf@gmail.com> writes:
> So, my point is the following. A shebang is an almost universally
> accepted way to specify which interpreter should be used for code
> evaluation.
>
> In the ob-core.el, at line 787, the function called
> org-babel-expand-src-block makes a buffer out of the noweb-expanded
> code.
> (I am working with org 20200907)
>
> The sexp is looking like this:
>
> (org-edit-src-code
> expanded (concat "*Org-Babel Preview " (buffer-name) "[ " lang " ]*"))
>
> I suggest replacing this sexp with
>
> (org-edit-src-code
> (seq-concatenate 'string (or (alist-get :shebang params) "") "\n"
> expanded) (concat "*Org-Babel Preview " (buffer-name) "[ " lang "
> ]*"))
>
> This way the expanded buffer would respect the shebang, and the
> resulting buffer would be saveable as a runnable file.
>
> I suspect that the second branch of the (if) should be left as it is,
> because non-interactive usage probably means that the code will be
> used later as a part of something, and therefore does not need a
> shebang.
>
> Vlad
>
I'm not sure about this one.
- I often have multiple src blocks which make up one final script once
tangled. When editing these blocks, I don't want a shebang line for
each of them.
- Would this work with different shells? I write scripts in multiple
shell dialects e.g. bash, sh, zsh, ksh etc. Will this add the correct
shebang?
- Which form of shebang e.g #!/bin/<shell> or #!/usr/bin/env <shell>?
The only thing worse than having to add the shebang manually is having
to remember to remove/change it when not needed :)
Perhaps this could be a user configurable option that you can turn on if
you want it rather than a default action?
--
Tim Cross
prev parent reply other threads:[~2020-09-10 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 1:03 Shouldn't ob-shell's org-babel-expand-src-block prepend the :shebang value? Vladimir Nikishkin
2020-09-05 5:00 ` Bastien
[not found] ` <CA+A2iZbJrNC3Rx5oAvyamBM_BObP8bxyTiFKtzxDrJhqe1MKsQ@mail.gmail.com>
[not found] ` <87d030ae7g.fsf@bzg.fr>
2020-09-10 6:52 ` Vladimir Nikishkin
2020-09-10 7:10 ` Tom Gillespie
2020-09-10 7:29 ` Vladimir Nikishkin
2020-09-10 7:30 ` Tim Cross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rjaytpq.fsf@gmail.com \
--to=theophilusx@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).