[PROPOSED-PATCH] ox-publish: fix typo in function name

[PROPOSED-PATCH] ox-publish: fix typo in function name

[Paul Eggert]

* lisp/ox-publish.el (org-publish-cache-mtime-of-src):
Rename from org-publish-cache-ctime-of-src, since it
has always cached mtime not ctime.  All uses changed.
---
 lisp/ox-publish.el | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/lisp/ox-publish.el b/lisp/ox-publish.el
index 5c6ad94c9..e3d67b695 100644
--- a/lisp/ox-publish.el
+++ b/lisp/ox-publish.el
@@ -379,7 +379,7 @@ still decide about that independently."
   "Update publishing timestamp for file FILENAME.
 If there is no timestamp, create one."
   (let ((key (org-publish-timestamp-filename filename pub-dir pub-func))
-	(stamp (org-publish-cache-ctime-of-src filename)))
+	(stamp (org-publish-cache-mtime-of-src filename)))
     (org-publish-cache-set key stamp)))
 
 (defun org-publish-remove-all-timestamps ()
@@ -1287,7 +1287,7 @@ the file including them will be republished as well."
   (let* ((key (org-publish-timestamp-filename filename pub-dir pub-func))
 	 (pstamp (org-publish-cache-get key))
 	 (org-inhibit-startup t)
-	 included-files-ctime)
+	 included-files-mtime)
     (when (equal (file-name-extension filename) "org")
       (let ((visiting (find-buffer-visiting filename))
 	    (buf (find-file-noselect filename))
@@ -1308,15 +1308,15 @@ the file including them will be republished as well."
 				       (substring m 0 (match-beginning 0))
 				     m)))))
 		      (when filename
-			(push (org-publish-cache-ctime-of-src
+			(push (org-publish-cache-mtime-of-src
 			       (expand-file-name filename))
-			      included-files-ctime)))))))
+			      included-files-mtime)))))))
 	  (unless visiting (kill-buffer buf)))))
     (or (null pstamp)
-	(let ((ctime (org-publish-cache-ctime-of-src filename)))
-	  (or (time-less-p pstamp ctime)
-	      (cl-some (lambda (ct) (time-less-p ctime ct))
-		       included-files-ctime))))))
+	(let ((mtime (org-publish-cache-mtime-of-src filename)))
+	  (or (time-less-p pstamp mtime)
+	      (cl-some (lambda (ct) (time-less-p mtime ct))
+		       included-files-mtime))))))
 
 (defun org-publish-cache-set-file-property
   (filename property value &optional project-name)
@@ -1361,8 +1361,8 @@ does not exist."
     (error "`org-publish-cache-set' called, but no cache present"))
   (puthash key value org-publish-cache))
 
-(defun org-publish-cache-ctime-of-src (file)
-  "Get the ctime of FILE as an integer."
+(defun org-publish-cache-mtime-of-src (file)
+  "Get the mtime of FILE as an integer."
   (let ((attr (file-attributes
 	       (expand-file-name (or (file-symlink-p file) file)
 				 (file-name-directory file)))))
-- 
2.37.1

Re: [PROPOSED-PATCH] ox-publish: fix typo in function name

[Ihor Radchenko]

Paul Eggert <eggert@cs.ucla.edu> writes:

> * lisp/ox-publish.el (org-publish-cache-mtime-of-src):
> Rename from org-publish-cache-ctime-of-src, since it
> has always cached mtime not ctime.  All uses changed.

Thanks! mtime is indeed more accurate.

Note that your patch does not apply onto main.

Also, please define obsolete alias linking the old function name to the
new one in org-compat.el. We do not want to break the existing code.

Best,
Ihor

Re: [PROPOSED-PATCH] ox-publish: fix typo in function name

[Paul Eggert]

Thanks for the review. Pushed with the changes you suggested.