Hi, Ihor, Ihor Radchenko writes: > Thanks! I have some minor comments on the patch. > >> From b06cdd45198f470a135efad2cd1d8b22ab7e2f22 Mon Sep 17 00:00:00 > 2001 >> From: Juan Manuel Macias >> Date: Sun, 31 Jul 2022 02:31:08 +0200 >> Subject: [PATCH] lisp/ox-latex.el: `org-latex-language-alist' > improved. > > No dot after the firs message line, please. > >> + '(("am" . (:babel-ini-only "amharic" :polyglossia "amharic" : > lang-name "Amharic")) >> + ("ar" . (:babel "arabic" :polyglossia "arabic" :lang-name > "Arabic")) > > A simpler form would be > ("am" :babel-ini-only "amharic" :polyglossia "amharic" :lang-name > "Amharic") > >> + "Alist between language code and corresponding properties, such >> +as Babel/Polyglossia options and language names. > > The first line of the docstring should fit 80 characters and be a full > sentence. It is needed to make sure that eldoc can display the short > docstring in the message area. > >> +- `:poliglosia' the name of the language loaded by the Polyglossia > LaTeX package > > `:polyglossia', I think. > >> +- `:babel-ini-only' the name of the language loaded by Babel >> + exclusively through the new ini files method. > > May we put some kind of reference to LaTeX docs here? > >> + (let ((language (let* ((lang (plist-get info :language)) >> + (plist (cdr >> + (assoc lang org-latex-language-alist)))) >> + ;; Here the actual name of the LANGUAGE or LANG > is used > > Please end the comment sentence with ".". Thanks for your comments and patience, and sorry again for the typos. I am attaching a new fixed version of the patch. If everything is ok, I get down to work with the Manual and NEWS. I think it would be nice to add a few usage examples, and some links to the Babel and Polyglossia documentation. Best regards, Juan Manuel