From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sMocE88YC2QLHAAASxT56A (envelope-from ) for ; Fri, 10 Mar 2023 12:47:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KHQ8E88YC2QlKwEAauVa8A (envelope-from ) for ; Fri, 10 Mar 2023 12:47:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 54ED413462 for ; Fri, 10 Mar 2023 12:47:26 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pabCq-0003aH-JI; Fri, 10 Mar 2023 06:46:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabCo-0003Zm-0a for emacs-orgmode@gnu.org; Fri, 10 Mar 2023 06:46:38 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pabCl-0006NM-Ur for emacs-orgmode@gnu.org; Fri, 10 Mar 2023 06:46:37 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A5AA12405F5 for ; Fri, 10 Mar 2023 12:46:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1678448793; bh=bANKrAUz50IcrQyhpfVdL/fwkZ0aMSywW7HO8/kfKpI=; h=From:To:Cc:Subject:Date:From; b=ekfHD2VFJqyZNk9J6ijM6TigDv73L34b+0M+gY+SgY7rrzPHauy8zVQJDU7U1zPuk fdQT6PbxaburfoR259Dl+wEL5TAiVdvpJnC25gvDLplrgOOTd3I2+nzphxcdwQDAUI mR08iAh9EFhy0rYJfC+EpdRqo109FoY5B7H6fTKO7iIxutcFNzSpMv4DpQXEO8Uq18 pqjzkZYyxJbMbT/bkC9mtru8tolGZgvmmPUx3EP4Vdngz4iQdeONk+zxlw7Sl9qBR8 Fv5A+ZH73wfLsKjP3eViGYwVXOtf0gJFUPglD6S9zYpH517e3HpaIYLIlb0J2JFFC6 J0Z++mGOfobSw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PY45N4pDNz9rxB; Fri, 10 Mar 2023 12:46:32 +0100 (CET) From: Ihor Radchenko To: Tim Ruffing Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Don't reset `org-todo-keywords-for-agenda' when org-agenda-multi In-Reply-To: <55a16edf3c8e04e9f1f7be7ab281ddacac81d9c1.camel@timruffing.de> References: <55a16edf3c8e04e9f1f7be7ab281ddacac81d9c1.camel@timruffing.de> Date: Fri, 10 Mar 2023 11:48:03 +0000 Message-ID: <871qlwzv2k.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1678448847; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MuIXWq7jwXTckwXAUz7qQkUgjOsbsnpuCvOJGr+Uu40=; b=ZscnOb+5NNxlUAK3HJeorNN4Y8556DAhrbs3xNtyIv2chHZPZ6uNcC1bgNURlFQdkrrLMe r2w+uS1YNQhLtaOBOJ2G77cMbt5vxVF8buT2igbBrn0jLGqlxnCPOl7m83+fAGYWsnicT2 b1adgD0tfcq2aeAQSxcnwPu5vHiJ9FS8KyPiTpCRONraKkvOVcjCAE18MTyf1FWKNMt6mH 5bKq40l9bCK6/9Rh9mNSycKIUktIAAssRXV5pmTJwLEdF8MWhXpSjW4918fpeKXS9cDHIz lZnFKyBz3A+sB04EB8/a+BMaRPTjk9QhBgbB3JjhQ1vwFnqJ04Mv8iCDybqmsw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ekfHD2VF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1678448847; a=rsa-sha256; cv=none; b=VjB8+uenwCOevSuA+nWhld2HVn65tEkuvdca7IHuP2r0IiPSloSY9oE7G6+ojjqQX96GSY 7kzIglQlU7/t9ZiXmm+ua78Fa2ORhDgXBC8GM5zkTDjxpiiwedMHgg+2kA6MhQ2fUfmsrl hhP2YcP8qz11gPV4FSO6mccbKLmlnXkLhmdTU4Y4h7jdcpPrMQRUyUzZ3AKQvnREJDGTQR 6y68KXHDmKiD/x7XqVp8DDsMi3anLx6oy2gf1feIF+dHz485Ps9zq82gTBkOFG7oBj5VUN uInxhHon7ZOcrGQZrLjEfZ0Ag+acG7zAlgsB0ag6nXNf7I2CG+VkvsaQE1Z2vg== Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=ekfHD2VF; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Spam-Score: -6.19 X-Spam-Score: -6.19 X-Migadu-Queue-Id: 54ED413462 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZfqXjwTXcm1T Tim Ruffing writes: > * org-agenda.el (org-prepare-agenda): Don't reset > `org-todo-keywords-for-agenda' when org-agenda-multi. > > Fixes a bug with TODO keywords that came to light in org-modern, > see https://github.com/minad/org-modern/issues/26. > > This is very similar to cd2d138883a55cad48394a3f473da8b973a99a5e, > which fixed the same for `org-done-keywords-for-agenda` (to fix > a similar styling issue). Thanks for the patch! Unfortunately, it does not apply. Could you re-send the patch as attachment? In addition, may you add TINYCHANGE cookie to the commit message if you don't have FSF assignment done (see https://orgmode.org/worg/org-contribute.html#first-patch)? And, if you can, write a test. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at