From: Arash Esbati <arash@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix one remaining emacs-30 byte-compile warning
Date: Wed, 25 Jan 2023 16:45:31 +0100 [thread overview]
Message-ID: <86tu0ety78.fsf@gnu.org> (raw)
In-Reply-To: <87r0vin7vi.fsf@localhost> (Ihor Radchenko's message of "Wed, 25 Jan 2023 11:58:25 +0000")
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
Ihor Radchenko <yantar92@posteo.net> writes:
> Could you please write a full patch with commit message? See
> https://orgmode.org/worg/org-contribute.html#first-patch
Thanks for your response. I hope I've got it right.
Best, Arash
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-ox.el-Pacify-compiler-warning.patch --]
[-- Type: text/x-patch, Size: 1200 bytes --]
From c550ed05d29cf163c286cffc328e5860423c7cde Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Wed, 25 Jan 2023 16:34:42 +0100
Subject: [PATCH] lisp/ox.el: Pacify compiler warning
* lisp/ox.el (org-export-to-buffer): Escape single quote in the
example given in docstring.
Add missing '.' after the abbreviation.
---
lisp/ox.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/ox.el b/lisp/ox.el
index ebf89bb..4c84686 100644
--- a/lisp/ox.el
+++ b/lisp/ox.el
@@ -6683,14 +6683,14 @@ see.
Optional argument POST-PROCESS is a function which should accept
no argument. It is always called within the current process,
from BUFFER, with point at its beginning. Export back-ends can
-use it to set a major mode there, e.g,
+use it to set a major mode there, e.g.,
(defun org-latex-export-as-latex
(&optional async subtreep visible-only body-only ext-plist)
(interactive)
(org-export-to-buffer \\='latex \"*Org LATEX Export*\"
async subtreep visible-only body-only ext-plist
- #'LaTeX-mode))
+ #\\='LaTeX-mode))
When expressed as an anonymous function, using `lambda',
POST-PROCESS needs to be quoted.
--
2.39.1
next prev parent reply other threads:[~2023-01-25 15:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 9:29 [PATCH] Fix one remaining emacs-30 byte-compile warning Arash Esbati
2023-01-25 11:58 ` Ihor Radchenko
2023-01-25 15:45 ` Arash Esbati [this message]
2023-01-26 9:22 ` Ihor Radchenko
2023-01-26 10:43 ` Arash Esbati
2023-01-27 13:01 ` Ihor Radchenko
2023-03-22 14:00 ` Bastien Guerry
2023-03-22 14:38 ` Ihor Radchenko
2023-01-25 13:48 ` Robert Pluim
2023-01-25 15:53 ` Arash Esbati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tu0ety78.fsf@gnu.org \
--to=arash@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).