From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kCdJOyNaYGNPgwAAbAwnHQ (envelope-from ) for ; Tue, 01 Nov 2022 00:28:36 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KFVmOiNaYGNoMQEAG6o9tA (envelope-from ) for ; Tue, 01 Nov 2022 00:28:35 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ABE4914BEA for ; Tue, 1 Nov 2022 00:28:35 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opeBu-0002Go-Nj; Mon, 31 Oct 2022 19:27:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opeBt-0002CE-DL for emacs-orgmode@gnu.org; Mon, 31 Oct 2022 19:27:37 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opeBr-0007Ku-IS; Mon, 31 Oct 2022 19:27:37 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 78so11966465pgb.13; Mon, 31 Oct 2022 16:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=5DYW2j29C4m6yhQBjeNkCUVG3/ckckPWeu9LNDev7B0=; b=EB1183/A87Pv0SqbRHF0VRa2RDDFa/z3wuZoTRQEU1qTLisS+Y0wqHMN/04rRYJqL4 RcOraee/Sq9Z+aE6Mj3xJnA8pxc0KWYuSsN+m1AzbEmompiwU2SS8Knrp9M4dP1B2ltK 0BTm75fB67KCFIrqGmxdkuBEtiIy4WIyWPwOpI5eDcN39uiAw/i+g1ydcJZg9T1xV/NM dC5U6JakDEKMILgvloUSiXP9p7TvBBUeBbmnhbURJVcj13OjvLQnO5QB154qq9vO6jID TaShdntyYCpkfFZqvl5mCf1mdE77QKwd5f8fx1+4K2WcUhuVlR/quOrB1PdDBPIuwQqT k1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5DYW2j29C4m6yhQBjeNkCUVG3/ckckPWeu9LNDev7B0=; b=u+gG+p8NIdG5PuxEFZ/wl5cHNUNBMqdvCdfj+WO6pkEccE6iC5/dYWS/vmfNNdNZTS abTDNWJTwgOfG5DVKanCZEFjjBJdgvVlqBcjiDcUcycP83bAN5LlRBVsRMgfB8CAYxBf Vwc69h4o30Cxbbxk9MU34I9aT2fg3K39RRF58XMSpNq1Xu+o3/HguKwbG9izE/BR6VxB pRj1LEFgMtnO+QXTTNcZRe3BAPu8OKMMknGJwiXew+sI1M3Tm6LSpWvXpjmvz98OOwpQ teXyfhqq7zEjQXtyCUXq3e0eMM7Z2oU5EI2GcpJPJeAOxGazmLnrnHpFNzjzzGXQCy7W /45w== X-Gm-Message-State: ACrzQf2Zaus5HeASELFvlRUaYLc8ZsC04Ob861s6Cx/P1w4mEEoppY4s LposttNCQZZMH7kKI4Qe88Mxjmld1jw= X-Google-Smtp-Source: AMsMyM5ZeHPB6rT5cL5jf0cPAhu80oFC+JRzFTFBa8xsn0n4xZ+rvyGDvg9j8b29dKgJLZpvb5IHyw== X-Received: by 2002:a63:1b16:0:b0:46b:8e7:3e0a with SMTP id b22-20020a631b16000000b0046b08e73e0amr14491288pgb.86.1667258853281; Mon, 31 Oct 2022 16:27:33 -0700 (PDT) Received: from dingbat (220-235-181-183.dyn.iinet.net.au. [220.235.181.183]) by smtp.gmail.com with ESMTPSA id kk2-20020a17090b4a0200b0020d48bc6661sm4735636pjb.31.2022.10.31.16.27.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 16:27:32 -0700 (PDT) References: <875yhsujkq.fsf@localhost> <87h71ct10n.fsf@localhost> <87tu5bbajh.fsf@localhost> <87r10ey8ov.fsf@localhost> <87o7v4dvon.fsf@gnu.org> <87pmfijrvw.fsf@localhost> <87y1u4ec18.fsf@gnu.org> User-agent: mu4e 1.9.1; emacs 29.0.50 From: Tim Cross To: "Cook, Malcolm" Cc: 'Bastien' , Ihor Radchenko , Stefan Monnier , emacs-orgmode@gnu.org Subject: Re: org-assert-version considered harmful Date: Tue, 01 Nov 2022 10:16:35 +1100 In-reply-to: Message-ID: <86k04fbmlb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=theophilusx@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667258915; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5DYW2j29C4m6yhQBjeNkCUVG3/ckckPWeu9LNDev7B0=; b=GLhr5wKi+eQt/IWPVWBQUBrcJGuA2FMlpucp4W6faD5lbnrzgrhv0wl04AJxAVS0ACMO/s vNyaR8AzJ+ZDVtRUddHgbRPOz9caO5/dF4mTkrrSfLyj04Pm27U/4PpchEUyJwXQJ7VCPi lxOf0TUXZuYpBLQeLMbv9uDXJfBl1f7FpPmLtaWl1nAcGZiDQOiV7omUSRKQQfgIx0k4JE I9t8CbALWsQUk0z08KKMwMZSooACiIZtkAQOo0ZGu1Hr4ouxY7DeHu+qu/YWnTjkEVQr/t 3g9XCR1VRFgF7CTrxb8Oob0OlEDumS1Og7dr3kpRz5UzyAdu08mMt4Eo6Fd80w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667258915; a=rsa-sha256; cv=none; b=ru2n2aWAQtA4bnjKRYoN2G8KFU78W1xONNRmH4m7lZUUt+NBmDZvKyK3jueZ4NwL8/C3aA Otlsquia7G3pV9889x/fcbTjVtOjz6LjXS8TTzfjyA5JvP7tk0EWf+TN2POu07GxPLAVuQ uVLDyoSesoGA7UKsplXK37uj+ClKXtaYvurC1cCRY62KVzy2Dt+Qyk3L9JosDqcUVb5gqi uAFHnDufThdrF/mxOrgSh4IMO2dooAPmm90rIdEdYV4eQ78z5HXJyD7HhB7ecnJhQHJLPv fV4focgV0NSI1w96U9ZFrpNdL2rJxYkzig95BND+MUmxLOSpr0KO76qtOetYYw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="EB1183/A"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.27 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="EB1183/A"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: ABE4914BEA X-Spam-Score: -4.27 X-Migadu-Scanner: scn0.migadu.com X-TUID: seshK73BNi3z "Cook, Malcolm" writes: > Hello, > > I found this recent thread researching why my strategy for staying abreast with org head had started failing with invalid-function > "org-assert-version" > > My strategy had been to build org initially with > > ` cd ~/.emacs.d && git clone https://git.savannah.gnu.org/git/emacs/org-mode.git && cd org-mode && make autoloads && make > ` > and ensure this clone of org was picked up in my "~/.emacs.d/org-mode/lisp by including the following in my .init.el very early > (right after bootstrapping the package system and use-package): > > (use-package > > :pin manual > > :load-path "~/.emacs.d/org-mode/lisp" > > ) > > Then, when I occasionally wished to update org, I would > > `cd ~/.emacs.d/org-mode && git pull && make autoloads && make` > > Recently I started getting errors invalid-function "org-assert-version". > > Upon cursory reading of this thread I guessed that I could fix them by adding a `make clean` to my update mantra. > > It worked. > > Am I advised to do otherwise? Is there a best/better practice? > I think it is good practice to always do make clean for any code you build from sources yourself. There is a reason most Makefiles have a 'clean' target and when it comes to building software, starting from a known clean state is critical. This can make the build slower, but for small packages like org mode, the difference is insignificant. Always safer to do make clean before make. Alternative approaches really only necessary in larger and more complex source trees where there can be significant time differences between full and incremental builds (i.e. Emacs source tree has 4 different 'clean' targets; clean, extraclean, distclean and bootstrap).