28.0.50; [bug] Inside help buffers escaped symbol[s] causing a problem.

[Achilles Yuce <ayuce@posteo.mx>]

Hello Everyone,

After using `org-store-link`; i was expecting to jump back to what i
stored which is the buffer to see after evaluating (describe-symbol '\`)
but instead i got an `user-error` as you can see in [Recent messages:]
section in this report. I believe this shouldn't be the case. My exact
steps included in [Losage:] section.

FWIW I somehow managed to fix it by removing the '\'s from the captured
string defined in lisp/org/ol.el file. Also adding diff output.

Sincerely,

--
Achilles Yuce                               GPG: B631 00A1 35BC 97C2 24A1
                                                 3306 44F9 71F3 1CCF 32E2

=========================================================================

Emacs Command:
emacs -Q

Starting Buffer:
*scratch*

Lossage: [`self-insert-command`s simplified for readability]
 M-x			;; execute-extended-command
 org-mode		;; self-insert-command
 <return>		;; minibuffer-complete-and-exit
 C-h o			;; describe-symbol
 `			;; self-insert-command
 <return>		;; minibuffer-complete-and-exit
 C-x o			;; other-window
 M-x			;; execute-extended-command
 org-store-link		;; self-insert-command
 <return>		;; minibuffer-complete-and-exit
 C-x o                  ;; other-window
 C-c C-l		;; org-insert-link
 M-p			;; previous-history-element
 <return>		;; exit-minibuffer
 backquote		;; self-insert-command
 <return>		;; exit-minibuffer
 C-b			;; backward-char
 C-c C-o		;; org-open-at-point

Recent messages:
Stored: help:\`
user-error: Unknown function or variable: \`

Diff:
--- a/lisp/org/ol.el
+++ b/lisp/org/ol.el
@@ -1465,10 +1465,11 @@ org-store-link
          (org-link-store-props :type "calendar" :date cd)))

        ((eq major-mode 'help-mode)
-       (setq link (concat "help:" (save-excursion
-                                    (goto-char (point-min))
-                                    (looking-at "^[^ ]+")
-                                    (match-string 0))))
+       (setq link (replace-regexp-in-string "\\\\" ""
+                     (concat "help:" (save-excursion
+                                     (goto-char (point-min))
+                                     (looking-at "^[^ ]+")
+                                     (match-string 0)))))
        (org-link-store-props :type "help"))

        ((eq major-mode 'w3-mode)


In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3)
 of 2020-04-26 built on machine
Repository revision: 9dccaf8a5cdb10dae597345ec3741475477a7d97
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12008000
System Description: Arch Linux

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY
INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS
GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Org

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail timezone eieio-opt cl-extra
speedbar ezimage dframe thingatpt help-fns radix-tree help-mode
org-element avl-tree generator ol-eww ol-rmail ol-mhe ol-irc ol-info
ol-gnus nnir gnus-sum url url-proxy url-privacy url-expand url-methods
url-history mailcap shr url-cookie url-domsuf url-util url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs json map
url-vars svg xml dom browse-url gnus-group gnus-undo gnus-start
gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601
gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec
password-cache epa derived epg epg-config mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus
nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums
text-property-search seq byte-opt gv bytecomp byte-compile cconv
mail-utils mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr
image-mode exif dired dired-loaddefs ol-bibtex bibtex ol-bbdb ol-w3m org
ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote
org-src ob-comint org-pcomplete pcomplete comint ansi-color ring
org-list org-faces org-entities time-date subr-x noutline outline
easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table ol
org-keys org-compat advice org-macs org-loaddefs format-spec find-func
cal-menu easymenu calendar cal-loaddefs cl-loaddefs cl-lib tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify lcms2 dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 16 160413 38075)
 (symbols 48 18241 1)
 (strings 32 61281 2269)
 (string-bytes 1 2009141)
 (vectors 16 28851)
 (vector-slots 8 326560 14198)
 (floats 8 197 289)
 (intervals 56 249 0)
 (buffers 1000 12))